patch for tabindex on send button (compose email page)

dmandell dmandell at gristle.org
Fri Dec 8 20:22:30 CET 2006


Hi all,

I prefer to use keyboard navigation whenever possible.  RC currently allows tabbing between recipient, subject and body, but the send button doesn't allow tabindex.  In other webmail applications (yahoo, gmail, etc) send is next after tab, and it's quite convenient that way.  I'm assuming you didn't purposely make it difficult to tab to the Send button, so I've created a patch for your approval.

Below is a patch that allows tabindex in buttons and makes "Send" and "Cancel" next in the tab order after the email body.

Please let me know if I'm not submitting the patch right or if you have any issues.

Thanks a bunch,

Doug

Index: roundcubemail/program/include/main.inc
===================================================================
--- roundcubemail/program/include/main.inc      (revision 400)
+++ roundcubemail/program/include/main.inc      (working copy)
@@ -1501,7 +1501,7 @@
     if ($attrib['label'])
       $attrib['value'] = $attrib['label'];

-    $attrib_str = create_attrib_string($attrib, array('type', 'value', 'onclick', 'id', 'class', '$
+    $attrib_str = create_attrib_string($attrib, array('type', 'value', 'onclick', 'id', 'class', '$
     $out = sprintf('<input%s disabled />', $attrib_str);
     }

Index: roundcubemail/skins/default/templates/compose.html
===================================================================
--- roundcubemail/skins/default/templates/compose.html  (revision 400)
+++ roundcubemail/skins/default/templates/compose.html  (working copy)
@@ -100,15 +100,15 @@
 <table border="0" cellspacing="0" width="100%" summary=""><tbody><tr>

 <td>
-<roundcube:button type="input" command="send" class="button" label="sendmessage" />
-<roundcube:button type="input" command="list" class="button" label="cancel" />
+<roundcube:button type="input" command="send" class="button" label="sendmessage" tabindex="8" />
+<roundcube:button type="input" command="list" class="button" label="cancel" tabindex="9" />
 </td>
 <td align="right">
-<roundcube:label name="charset" />: <roundcube:object name="charsetSelector" tabindex="8" />
+<roundcube:label name="charset" />: <roundcube:object name="charsetSelector" tabindex="10" />
 </td>
 <td align="right">
  <roundcube:label name="editortype" />: </td>
-<roundcube:object name="editorSelector" tabindex="9" />
+<roundcube:object name="editorSelector" tabindex="11" />
 </tr></tbody></table>

 </td>





More information about the Dev mailing list