shift-select and control-select patch

[Charles McNulty]

Fixed bug with Internet Explorer.  Firefox doesn't mind const, but IE chokes on it.  My bad.  Who uses IE anyway :)

-Charles

PS. This is the code that allows you to use shift-click, control-click or shift-control-click on message lists, and makes it behave the exact same way as Outlook and Thunderbird.

PPS.  In answer to the person that asked how you apply patches, you simply put the patch file in the same directory as the file you want to patch and then type:

patch app.js app.js.patch 

from a command line.




> -----Message d'origine-----
> De : Charles McNulty [mailto:charles at charlesmcnulty.com] 
> Envoyé : mercredi 18 janvier 2006 03:18
> À : dev at lists.roundcube.net
> Objet : Re: shift-select and control-select patch
> 
> Here is the promised patch for control-shift-click on lists (in addition
> to
> the other changes with shift-click and control-click).  I'd never even
> heard
> of control-shift-click behavior until I started playing around with this,
> but it's only a change to a couple of lines of code over the previous
> patch,
> so I figured might as well.
> 
> -Charles
> 
> Charles McNulty wrote:
> 
>>Glad to hear it, I've made one further change to allow the seldom-used 
>>control-shift-click behavior which works like shift select but which 
>>doesn't unselect anything (try it in outlook or thunderbird). I'll post 
>>that patch tonight.
>>
>>-Charles
>>
>>On Tue, 17 Jan 2006 12:58:33 +0100, Begzudin Omerovic
> <begzudin.omerovic at gmail.com> wrote:
>>  
>>
>>>2006/1/16, popquizh at popquizhotshot.com <popquizh at popquizhotshot.com>:
>>>    
>>>
>>>>I tried sending this message with RoundCube, but I don't think the 
>>>>attachment was working.  Anyway, this patch changes the 
>>>>control-select and shift-select behavior for lists to emulate that of 
>>>>standard windows applications (or at least Outlook and Thunderbird 
>>>>which is what I tested it against).  Please give it a try and let me
> know
> how it turns out.
>>>>Also let me know if any further steps need to be taken to have this 
>>>>patch considered for merge into the main code.
>>>>
>>>>      
>>>>
>>>have tested this patch, works perfect with firefox
>>>
>>>    
>>>
>>>>-Charles
>>>>
>>>>
>>>>
>>>>      
>>>>
>>>--
>>>Begzudin Omerovic
>>>
>>>www.oglasi.com - najveci izbor nekretnina na Balkanu !!!!
>>>    
>>>
>>
>>
>>
>>  
>>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: app.js.patch
URL: <http://lists.roundcube.net/pipermail/dev/attachments/20060118/3710d759/attachment.ksh>