Search bug

Jon Daley roundcube at jon.limedaley.com
Mon May 15 20:49:52 CEST 2006


/var/www/secure/webmail>svn diff program/ 
Index: program/include/rcube_imap.inc
===================================================================
--- program/include/rcube_imap.inc      (revision 1636)
+++ program/include/rcube_imap.inc      (working copy)
@@ -876,10 +876,11 @@
      $a_messages = iil_C_Search($this->conn, $mailbox, $criteria);

      // clean message list (there might be some empty entries)
-    foreach ($a_messages as $i => $val)
-      if (empty($val))
-        unset($a_messages[$i]);
-
+    if($a_messages){
+      foreach ($a_messages as $i => $val)
+        if (empty($val))
+          unset($a_messages[$i]);
+    }
      return $a_messages;
      }

/var/www/secure/webmail>svn commit -m "need to check value before passing
    to foreach.  search is also broken, so this might not be the real fix"



Maybe I will get a chance to see what is broken with the search too.





More information about the Dev mailing list