[RCD] [PATCH] Theaded view mode

Vladislav Bogdanov bubble at hoster-ok.com
Thu Aug 27 16:10:04 CEST 2009


Hi Nathan

Thanks, I'll try to reuse and test your patch.

It is transparent for me that copy/move operations should touch nested
messages as well. I incline to use the same approach for a delete
operation, so nested messages will be deleted as well.

That would be a great surprise for me that there are copy/move
operations which should be thread-aware. Thank you for pointing me :)


Best,
Vladislav

P.S. Quick debugging session showed me that there are duplicate HTML
rows with the same ID. I'll try to find where they appear from.

Nathan Kinkade wrote:
>>
>> More, here is a nasty problem when deleting thread-leading message while
>> it's not expanded. Children are neither shown nor deleted. Mailbox
>> reload shows them then.
>>
>> There two possible ways: either delete child messages too, or show next
>> level of depth (and mode if that messages are in expanded state)
>> immediately.
>>
>> Question to all: What way is a preferred one?
>>
>> I'm not sure yet if these problems are related or not.
>> Will dig deeper.
>>
>> Vladislav
> 
> I worked on Chris' threading patches a while back.  I can't remember if
> I did something about the delete issue, but here was something I did
> about moving and copying whole threads:
> 
> http://code.nkinka.de/gitweb?p=roundcube.git;a=commitdiff;h=f3bb47d0e30a2e581b5017f5b7da7bb4290b60cc;hp=104e16492cfac7c170446f888995ee989d492db2
> 
> I haven't been using Roundcube for some time now, and I can't remember
> whether this patch was 100% working.
> 
> Nathan
> _______________________________________________
> List info: http://lists.roundcube.net/dev/

_______________________________________________
List info: http://lists.roundcube.net/dev/



More information about the Dev mailing list