[RCD] 0.4-beta has broken automatic_addressbook, google_contacts and plaxo_contacts plugins

Roland Liebl roland at roland-liebl.de
Mon Apr 26 13:33:40 CEST 2010


On Mon, 26 Apr 2010 13:01:45 +0200, "A.L.E.C" <alec at alec.pl> wrote:
> Roland Liebl wrote:
>> class automatic_addressbook_backend extends rcube_contacts
>> {
>>     function __construct($dbconn, $user)
>>     {
>>         parent::__construct($dbconn, $user);
>>         $this->db_name = get_table_name('collected_contacts');
>>     }
>> }
>> ?>
>> Now I have to insert before parent::__contstruct ...
>>         $rcmail = rcmail::get_instance();
>>         $rcmail->config->set('db_table_contacts', 
>> $rcmail->config->get('db_table_collected_contacts'));
>> Otherwise it will use the default contacts table. Is this a bug or 
>> intended behavior?
> 
> No, it isn't, but what exactly is the issue? I see a one possible bug in

> rcube_contacts. In insert() method we're using hardcoded 'contacts' name
> in:
> $insert_id = $this->db->insert_id('contacts');
> 
> So, this will be fixed. Probably groups handling should be improved for 
> class inheritance, something more?

Fixing rcube_contacts does not solve the problem.

_______________________________________________
List info: http://lists.roundcube.net/dev/



More information about the Dev mailing list