[RCD] Messagetoolbar Icon State

chasd chasd at silveroaks.com
Thu Jan 28 18:49:54 CET 2010


I'm working on porting my " iPhone " patch ( Trac ticket #1484680 )  
to revision 3235.
I don't want to edit the sprite image so the patch isn't intrusive,  
and an upstream update to the sprite image doesn't overwrite my changes.

I can't get my " Open Message " icon to initialize properly.

It is displayed at 0.99 opacity when no messages are selected in the  
list. It should be set to 0.35 opacity if no messages are selected.  
However if I select a message, then click on the " Select None "  
button at the bottom, the icon is in the correct state. If I navigate  
to a mailbox that has no messages, the icon is in the correct state.  
It just doesn't get the 0.35 opacity CSS applied when the button is  
initialized if there are messages in the list.

I'm missing something somewhere, but I can't see it.

If this should be / could be a plugin, I'd appreciate some pointers  
to plugins that manipulate the messagetoolbar <div>.



Below is a svn diff

[chasd at webdev trunk]$ svn diff
Index: roundcubemail/skins/default/templates/mail.html
===================================================================
--- roundcubemail/skins/default/templates/mail.html     (revision 3235)
+++ roundcubemail/skins/default/templates/mail.html     (working copy)
@@ -103,6 +103,7 @@
  <div id="messagetoolbar">
  <roundcube:button command="checkmail" type="link" class="button  
checkmail" classAct="button checkmail" classSel="button checkmailSel"  
title="checkmail" content=" " />
  <roundcube:button command="compose" type="link" class="button  
compose" classAct="button compose" classSel="button composeSel"  
title="writenewmessage" content=" " />
+<roundcube:button command="show" type="link" class="buttonPas show"  
classAct="button show" classSel="button showSel" title="openmessage"  
content=" " />
  <roundcube:button command="reply" type="link" class="buttonPas  
reply" classAct="button reply" classSel="button replySel"  
title="replytomessage" content=" " />
  <roundcube:button command="reply-all" type="link" class="buttonPas  
replyAll" classAct="button replyAll" classSel="button replyAllSel"  
title="replytoallmessage" content=" " />
  <roundcube:button command="forward" type="link" class="buttonPas  
forward" classAct="button forward" classSel="button forwardSel"  
title="forwardmessage" content=" " />
Index: roundcubemail/skins/default/images/buttons/open_pas.png
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream

Property changes on: roundcubemail/skins/default/images/buttons/ 
open_pas.png
___________________________________________________________________
Added: svn:mime-type
    + application/octet-stream

Index: roundcubemail/skins/default/images/buttons/open_sel.png
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream

Property changes on: roundcubemail/skins/default/images/buttons/ 
open_sel.png
___________________________________________________________________
Added: svn:mime-type
    + application/octet-stream

Index: roundcubemail/skins/default/images/buttons/open_act.png
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream

Property changes on: roundcubemail/skins/default/images/buttons/ 
open_act.png
___________________________________________________________________
Added: svn:mime-type
    + application/octet-stream

Index: roundcubemail/skins/default/mail.css
===================================================================
--- roundcubemail/skins/default/mail.css        (revision 3235)
+++ roundcubemail/skins/default/mail.css        (working copy)
@@ -37,6 +37,14 @@
    opacity: 0.35;
  }

+#messagetoolbar a.show {
+  background: url('images/buttons/open_act.png') 0 0 no-repeat  
transparent;
+}
+#messagetoolbar a.showSel {
+  background: url('images/buttons/open_sel.png') 0 0 no-repeat  
transparent;
+  opacity: 0.35;
+}
+
  #messagetoolbar a.checkmailSel {
    background-position: 0 -32px;
  }
Index: roundcubemail/program/localization/en_US/labels.inc
===================================================================
--- roundcubemail/program/localization/en_US/labels.inc (revision 3235)
+++ roundcubemail/program/localization/en_US/labels.inc (working copy)
@@ -121,6 +121,7 @@
  // toolbar buttons
  $labels['checkmail']        = 'Check for new messages';
  $labels['writenewmessage']  = 'Create a new message';
+$labels['openmessage']      = 'Open message';
  $labels['replytomessage']   = 'Reply to sender';
  $labels['replytoallmessage'] = 'Reply to sender and all recipients';
  $labels['forwardmessage']   = 'Forward the message';
[chasd at webdev trunk]$


-- 
Charles Dostale
System Admin - Silver Oaks Communications
http://www.silveroaks.com/
824 17th Street, Moline  IL  61265

_______________________________________________
List info: http://lists.roundcube.net/dev/



More information about the Dev mailing list