[RCD] simple login form improvement

Melih Taşdizen melihme at gmail.com
Wed Jun 16 08:28:48 CEST 2010


Hi,

I try to make a roundcube skin for my university. Our designers made a
fine job, but they had located the login inputs below the labels, that
means I need 4 rows for login screen.

then I noticed that the login form was placed into a table :(, it is
kidna difficult to manipulate via CSS and impossible to get 4 rows
without editing the rcube_template.php file.

so, i wrote a simple patch to convert login form's table structure to
list( and add an extra div for each <li> to end float -if needed-).

I think this form is much more easy to manipulate, even it may be a
plus for the ones who make skins for rtl languges.

regards,

Melih

diff against 0.4-beta:

1051,1060c1051,1060
<
<         // create HTML table with two cols
<         $table = new html_table(array('cols' => 2));
<
<         $table->add('title', html::label('rcmloginuser',
Q(rcube_label('username'))));
<         $table->add(null, $input_user->show(get_input_value('_user',
RCUBE_INPUT_POST)));
<
<         $table->add('title', html::label('rcmloginpwd',
Q(rcube_label('password'))));
<         $table->add(null, $input_pass->show());
<
---
> 		
>
>         // create FORM html
>         $form_html = sprintf("<ul><li>%s%s<div class=\"clear\" /></li><li>%s%s<div class=\"clear\" /></li>",
>         					html::label('rcmloginuser', Q(rcube_label('username'))),
>         					$input_user->show(get_input_value('_user', RCUBE_INPUT_POST)),
>         					html::label('rcmloginpwd', Q(rcube_label('password'))),
>         					$input_pass->show()
>         );
>
1063,1064c1063,1066
<             $table->add('title', html::label('rcmloginhost',
Q(rcube_label('server'))));
<             $table->add(null,
$input_host->show(get_input_value('_host', RCUBE_INPUT_POST)));
---
> 			$form_html .= sprintf("<li>%s%s<div class=\"clear\" /></li>",
> 					 html::label('rcmloginhost', Q(rcube_label('server'))),
> 					 $input_host->show(get_input_value('_host', RCUBE_INPUT_POST))
> 			);
1066a1069,1070
>         $form_html .= '</ul>';
>
1070c1074
<         $out .= $table->show();
---
>         $out .= $form_html;
_______________________________________________
List info: http://lists.roundcube.net/dev/



More information about the Dev mailing list