[RCD] [Svn] r3299 - in trunk/roundcubemail: . program/js program/steps/mail

A.L.E.C alec at alec.pl
Tue Mar 2 09:13:57 CET 2010


trac at roundcube.net wrote:
> Author: thomasb
> Date: 2010-03-02 01:54:11 -0600 (Tue, 02 Mar 2010)
> New Revision: 3299

> Modified: trunk/roundcubemail/program/steps/mail/check_recent.inc
> ===================================================================
> --- trunk/roundcubemail/program/steps/mail/check_recent.inc	2010-03-02 07:46:52 UTC (rev 3298)
> +++ trunk/roundcubemail/program/steps/mail/check_recent.inc	2010-03-02 07:54:11 UTC (rev 3299)
> @@ -22,6 +22,17 @@
>  $a_mailboxes = $IMAP->list_mailboxes();
>  $check_all = (bool)$RCMAIL->config->get('check_all_folders');
>  
> +// check if unread count of INBOX changed and refresh message list if so
> +if (!empty($_GET['_refresh'])) {
> +  $unread_count = $IMAP->messagecount('INBOX', 'UNSEEN', TRUE);
> +  if ($unread_count > $_SESSION['unseen_count']['INBOX']) {
> +    $OUTPUT->command('set_unread_count', 'INBOX', $unread_count, true);
> +    $OUTPUT->command('list_mailbox', 'INBOX', 1);  // let the client switch to INBOX and get the message list
> +    $OUTPUT->send();
> +  }
> +}
> +
> +// check recent/unseen counts for all mailboxes
>  foreach ($a_mailboxes as $mbox_name) {
>    if ($mbox_name == $IMAP->get_mailbox_name()) {
>      if ($recent_count = $IMAP->messagecount(NULL, 'RECENT', TRUE)) {

I don't like this changeset at all. This doesn't fix the issue. We're 
still checking RECENT for other folders. I also don't like switching to 
INBOX. I use server-side filters and got new mail in other folders, not 
only in INBOX. When I have other folder opened I don't like to change 
it. We must find better solution. Please, revert this change.

-- 
Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252
LAN Management System Developer http://lms.org.pl
Roundcube Webmail Developer http://roundcube.net
_______________________________________________
List info: http://lists.roundcube.net/dev/



More information about the Dev mailing list