[RCD] Skin unaware plugins

Kees de Keizer (RC) kees at de-keizer.net
Mon May 2 11:19:56 CEST 2011


On Mon, 02 May 2011 10:24:40 +0200, A.L.E.C wrote:

>> I use (and develop) the skin Groupvice4. I've just upgraded to 
>> v0.5.2
>> and noticed that the buttons for the plugins Archive and MarkAsJunk
>> have code in the plugin which is skin unaware:
>>
>>          'width' => 32,
>>          'height' => 32,
>>
>> The cause of the problem are these width and the height values. why
>> are they added? Can this be fixed?
>
> http://trac.roundcube.net/changeset/4458

Hardcoded heights and widths in the code are not a nice workaround to
support an ancient browser. This breaks the skin-awareness for these
plugins.
-- 
Kees de Keizer
kees at de-keizer.net
http://www.de-keizer.net/
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80



More information about the Dev mailing list