[RCD] tiny/marginal enigma plugin improvement

Mono monoatroundcubelists at zancudo.dyndns.org
Tue Apr 10 21:06:43 CEST 2012


ahoi rc devel team,

i was curious of the enigma plugin for rc, so i took a look at it.

well, still not even alpha as the readme file states. but hey it looks 
great to me!
is there anyone actively working on this one?

i tried to upload some public keys and checked the ability to verify 
signatures. yes it works.

what i didn't like is that in enigma keys settings panel the "Basic 
Information" of some key is limited to just one user id.
i insisted in it showing me all user ids within any key and therefore 
added two lines of code and modified one.


*** 
/Library/WebServer/SSL_Documents/mail_dev/plugins/enigma/lib/enigma_ui.php 
   Mon Apr  9 23:06:20 2012
--- 
/Library/WebServer/SSL_Documents/mail/plugins/enigma/lib/enigma_ui.php   
   Fri Dec  2 10:58:03 2011
***************
*** 300,309 ****
           $table = new html_table(array('cols' => 2));

           // Key user ID
!         foreach($this->data->users as $user) {
!               $table->add('title', 
$this->enigma->gettext('keyuserid'));
!               $table->add(null, Q($user->name . ' <' . $user->email . 
'>'));
!         }
           // Key ID
           $table->add('title', $this->enigma->gettext('keyid'));
           $table->add(null, $this->data->subkeys[0]->get_short_id());
--- 300,307 ----
           $table = new html_table(array('cols' => 2));

           // Key user ID
!         $table->add('title', $this->enigma->gettext('keyuserid'));
!         $table->add(null, Q($this->data->name));
           // Key ID
           $table->add('title', $this->enigma->gettext('keyid'));
           $table->add(null, $this->data->subkeys[0]->get_short_id());



ok, i like it. maybe others do as well.

cheers
Mono


More information about the dev mailing list