[RCD] Hard-coded references to larry

Rob Sheldon rob at associatedtechs.com
Tue Aug 28 08:18:33 CEST 2012


On 2012-08-27 22:57, A.L.E.C wrote:
> On 08/28/2012 07:51 AM, Rob Sheldon wrote:
>
>> The error wasn't showing up in any of RC's various logs, even with 
>> all
>> the knobs turned up. A quick grep found rcube_template to be the 
>> most
>> likely cause; on a whim I decided to grep the installation for 
>> "larry"
>> and found a half-dozen or so references there. Changing them all to
>> "default" made everything happy again.
>>
>> Is it possible to not hard-code the name of a theme, and instead 
>> grab it
>> from the config file?
>
> No, there always be a need to hardcoded fallback. You just 
> encountered a
> bug in 0.8.0, which was fixed in 0.8.1. It means in 0.8.1 you 
> shouldn't
> need to change anything.

A hardcoded fallback would be OK, but there was no reason for 0.8.1 to 
be "falling back"; there was a folder in /skins called "default", the 
user preferences were set to "default". I don't understand why crashing 
would be the preferred behavior here.

- R.

-- 
[__ Robert Sheldon
[__ No Problem
[__ Information technology support and services
[__ (530) 575-0278


More information about the dev mailing list