[RCD] Codebase cleanup, PSR-1/2 compliance - and before you say no, I'm offering to do the work

A.L.E.C alec at alec.pl
Sun Aug 25 12:36:17 CEST 2013


On 08/20/2013 09:15 PM, David Deutsch wrote:
> So - in a nutshell, that's what I'm offering to do for Roundcube.

In general we accept such contribution.

> I'd be happy to accommodate to special customs, of course, although I do
> think that sticking to PSR - flawed as it may be in spots - really helps
> enable collaboration by convention. Let me know if this sounds like
> something that would at all be welcome in this project.

I don't like some of your style, precisely, space after/before brackets.
I also prefer a new line before else/catch.

If you want to learn Roundcube code, consider also creation of more test
scripts.

-- 
Aleksander 'A.L.E.C' Machniak
LAN Management System Developer [http://lms.org.pl]
Roundcube Webmail Developer  [http://roundcube.net]
---------------------------------------------------
PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl


More information about the dev mailing list