[RCD] Codebase cleanup, PSR-1/2 compliance - and before you say no, I'm offering to do the work

David Deutsch skoremail at gmail.com
Thu Aug 29 17:33:25 CEST 2013

First pull request is up:

There were a couple of things that might turn out to be controversial, I
think mostly with calling on the html class - those seem to have a tendency
to get out of hand, so I decided to split it over multiple lines.

For CSS, I went with a two spaces indent, which seems to be the most
commonly used in the codebase. Let me know if you want four spaces instead.


On Thu, Aug 29, 2013 at 3:44 PM, David Deutsch <skoremail at gmail.com> wrote:

> A.L.E.C > This is not so exciting for some of us ;)
> Yes, I understand that. Gabor from RedBeanPHP (the other thing I cleaned
> up recently) is also very hesitant about namespaces, actually published a
> thing on his roadmap saying it would never happen and linking to a popular
> article that I now can't find since he removed it after I persuaded him.
> Well, not persuaded him that namespaces in PHP are super great, just that
> they're the best we can do for now, so we might as well roll with them ;-)
> A.L.E.C > If you will install it a lot you'll most likely do not use
> installer at all.
> True, but I haven't given all that much of a shot yet, so I don't know
> what will end up... catching my fancy.
> Cor Bosman > combination of composer, blade (template engine), less, and
> automated css/js creation is just so very smooth. Would love for RCM to
> head the same way.
> Absolutely agree. Things are moving quite rapidly in PHP at the moment,
> particularly driven by composer. Would love to be on board and chip in the
> knowledge that I have if/when RC makes that switch.
> And yes, particularly asset management is one of the fields where you
> start not minding it that much, then you start working out a number of
> approaches and then you just, over the years, accumulate lots and lots of
> technological debt. Having a good way to just write assets very
> conveniently and then utilize a build or setup process to manage everything
> properly is absolute bliss when you're used to hand-coding everything until
> you want to pull out your hairs so you can finally do something that more
> pleasant than manual asset management.
> Not sure how RCM will get there eventually, but I'm a big fan of taking
> the concept of semantic versioning as an invitation, where major version
> jumps are those where you are allowed to breaks lots of stuff. Otherwise
> you just end up in a codebase that spirals downwards because you both don't
> really can, but also don't really want to change anything too major.
> cheers,
> David
> On Thu, Aug 29, 2013 at 2:47 PM, Cor Bosman <cor at xs4all.nl> wrote:
>> This all sounds like some very exciting changes. I have been doing a lot
>> of work with Laravel lately, and the combination of composer, blade
>> (template engine), less, and automated css/js creation is just so very
>> smooth. Would love for RC to head the same way.
>> Cor
>> _______________________________________________
>> Roundcube Development discussion mailing list
>> dev at lists.roundcube.net
>> http://lists.roundcube.net/mailman/listinfo/dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.roundcube.net/pipermail/dev/attachments/20130829/f864c534/attachment.html>

More information about the dev mailing list