[RCD] Codebase cleanup, PSR-1/2 compliance - and before you say no, I'm offering to do the work

David Deutsch skoremail at gmail.com
Sat Aug 31 22:53:38 CEST 2013


Thanks.

And find them I did!

It's just that Thomas said earlier they were the standard in the codebase
and me changing them would confuse existing developers. So I remain
unconvinced there is what I'm saying... ;-)

-David


On Sat, Aug 31, 2013 at 10:43 PM, Cor Bosman <cor at xs4all.nl> wrote:

>
> On Aug 31, 2013, at 2:00 PM, David Deutsch <skoremail at gmail.com> wrote:
>
> Another possibly neat comparison:
>
> Original:
> https://github.com/roundcube/roundcubemail/blob/master/plugins/managesieve/lib/Roundcube/rcube_sieve_engine.php#L206
> Cleanup:
> https://github.com/daviddeutsch/roundcubemail/blob/37167c5ce1c00cb4f42b7f59a9ff56b81b3cd874/plugins/managesieve/lib/Roundcube/rcube_sieve_engine.php#L219
>
> The code may be /slightly/ less DRY, but, I find, a lot more readable.
>
>
> Definitely more readable.
>
>
> I must also say that so far, I find very few yoda conditions! ;-)
>
>
> Find them you will.
>
> Cor
>
>
> _______________________________________________
> Roundcube Development discussion mailing list
> dev at lists.roundcube.net
> http://lists.roundcube.net/mailman/listinfo/dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.roundcube.net/pipermail/dev/attachments/20130831/39812663/attachment-0001.html>


More information about the dev mailing list