[RCD] Custom Session Handlers

Reindl Harald h.reindl at thelounge.net
Wed Jun 5 09:19:30 CEST 2013



Am 05.06.2013 09:15, schrieb Thomas Bruederli:
> Reindl Harald wrote:
>>
>> Am 30.05.2013 12:32, schrieb Thomas Bruederli:
>>>>>> Am 26.05.2013 19:23, schrieb Thomas Bruederli:
>>>>>>> Will PHP just sleep B) until session-files are unlocked or will it just
>>>>>>> fail in writing the session data? And do database backends of PHPs session
>>>>>>> handler do locking as well?
>>>>>> it sleeps
>>>>> And mysql or mongodb handlers, too?
>>>> no, it's the job of the handler implement locking
>>>> are you not doing this currently?
>>>>
>>>>>> it should be quite simple to skip the custom session handler
>>>>> Should be, although there's some more functionality and checking attached
>>>>> to it. But I'll look into it.
>>>> thanks!
>>> Please find attached a patch that adds the option to use the native PHP
>>> session save handlers in Roundcube. Could you give it a try before we
>>> commit it to git?
>>>
>>> Hint: you need to set
>>> $rcmail_config['session_storage'] = 'php';
>>
>> thank you!
>>
>> i included the patch im my RPM-SPEC, changed the config and the
>> session-table keeps empty while read messages, lists and compose
>> a message with a attachment works, even after RC said the target
>> adress wiht "@test.rh" is wrong while the SMTP has a transport :-)
> 
> Thanks for testing! However, the sending issue most likely isn't session
> related.

i know, but it shows that the session is stable if the attachment got not lost

> I've not committed the patch to git master. Please note that some cleanup
> jobs within Roundcube are tied to the session garbage collector calls which
> do not happen when using the native php session save handler. Thus you
> should call bin/gc.sh periodically with a cron job.

ok, i take a look what this script does while i can not imagine
cleanups at the moment except temporary stored attachments

> I hope this finally adds the amount of flexibility you're requesting

of course - thank you!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.roundcube.net/pipermail/dev/attachments/20130605/40cb8698/attachment.sig>


More information about the dev mailing list