[RCD] BUG: program/lib/Roundcube/rcube_imap.php on line 1845

Reindl Harald h.reindl at thelounge.net
Mon May 26 10:46:30 CEST 2014


Am 26.05.2014 10:41, schrieb A.L.E.C:
> On 05/26/2014 10:31 AM, Reindl Harald wrote:
>> hopefully console() and $headers exists at that level :-)
> 
> Oops, it looks that we were looking at different lines of code.

how comes? the line number is part of the subject :-)

>>          // regular part
>> -        $struct->ctype_primary = strtolower($part[0]);
>> -        $struct->ctype_secondary = strtolower($part[1]);
>> +        if(is_array($part[0]) || is_array($part[1]))
>> +        {
>> +         console($_SESSION['username'].":$folder:$uid");
>> +         console($headers);
>> +        }
> 
> 
> Here, none of used variables exist. You need to change this to
> 
> console($_SESSION['username'].":".$this->folder.":".$this->msg_uid);
> console($part); 

[builduser at buildserver64:/rpmbuild/SOURCES]$ cat roundcubemail-str_to_lower_warning.patch
--- roundcubemail-1.0.1-dep-original/program/lib/Roundcube/rcube_imap.php       2014-05-09 16:09:02.000000000 +0200
+++ roundcubemail-1.0.1-dep-patched/program/lib/Roundcube/rcube_imap.php        2014-05-26 10:45:10.103016023 +0200
@@ -1841,8 +1841,13 @@
         */

         // regular part
-        $struct->ctype_primary = strtolower($part[0]);
-        $struct->ctype_secondary = strtolower($part[1]);
+        if(is_array($part[0]) || is_array($part[1]))
+        {
+         console($_SESSION['username'].":".$this->folder.":".$this->msg_uid);
+         console($part);
+        }
+        $struct->ctype_primary = @strtolower($part[0]);
+        $struct->ctype_secondary = @strtolower($part[1]);
         $struct->mimetype = $struct->ctype_primary.'/'.$struct->ctype_secondary;

         // read content type parameters

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 246 bytes
Desc: OpenPGP digital signature
URL: <http://lists.roundcube.net/pipermail/dev/attachments/20140526/94133632/attachment-0001.sig>


More information about the dev mailing list