[RCD] Patch

A.L.E.C alec at alec.pl
Wed Apr 8 09:40:55 CEST 2015


On 04/08/2015 09:20 AM, Барсуков Сергей wrote:
> There are an error in function rcmail_message_list_smart_column_name in
> module func.inc

Next time please use unified diff format.

>     if (((strpos($mbox.$delim, $sent_mbox.$delim) === false) ||
> (strpos($mbox.$delim, $drafts_mbox.$delim) === false))
>         && (strpos(strtoupper($mbox.$delim), 'INBOX'.$delim) === false)
>     ) {

I do not agree with this. There are servers where all folders are
subfolders of INBOX. The second line will just not work as expected for
them.
Also, in the first line the point is to do prefix matching, so "===
false" is not what we want here.

Sorry, proposed change completely does not make sense for me.

-- 
Aleksander 'A.L.E.C' Machniak
Kolab Groupware Developer        [http://kolab.org]
Roundcube Webmail Developer  [http://roundcube.net]
---------------------------------------------------
PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl


More information about the dev mailing list