[RCD] Patch

Sergey Barsukov sbars at inbox.ru
Sat Apr 11 15:24:05 CEST 2015


Thank you for answer!
It was my first try. I`am sorry for mistakes.

The main problem in original code is in comparison result of function strpos and 0.
So, if you have an Archive folder then for all subfolders of Archive it is showing 'from address' in from/to column.
Even if this one folder is 'Archive\Send'. I think this is wrong.

Среда,  8 апреля 2015, 9:40 +02:00 от "A.L.E.C" <alec �� alec.pl>:
>On 04/08/2015 09:20 AM, Барсуков Сергей wrote:
>> There are an error in function rcmail_message_list_smart_column_name in
>> module func.inc
>
>Next time please use unified diff format.
>
>>     if (((strpos($mbox.$delim, $sent_mbox.$delim) === false) ||
>> (strpos($mbox.$delim, $drafts_mbox.$delim) === false))
>>         && (strpos(strtoupper($mbox.$delim), 'INBOX'.$delim) === false)
>>     ) {
>
>I do not agree with this. There are servers where all folders are
>subfolders of INBOX. The second line will just not work as expected for
>them.
>Also, in the first line the point is to do prefix matching, so "===
>false" is not what we want here.
>
>Sorry, proposed change completely does not make sense for me.
>
>-- 
>Aleksander 'A.L.E.C' Machniak
>Kolab Groupware Developer        [ http://kolab.org ]
>Roundcube Webmail Developer  [ http://roundcube.net ]
>---------------------------------------------------
>PGP: 19359DC1 @@ GG: 2275252 @@ WWW:  http://alec.pl
>_______________________________________________
>Roundcube Development discussion mailing list
>dev �� lists.roundcube.net
>http://lists.roundcube.net/mailman/listinfo/dev
----------- �������� ����� -----------
�������� � ������� HTML ���� ���������…
URL: <http://lists.roundcube.net/pipermail/dev/attachments/20150411/c770fdfb/attachment.html>


More information about the dev mailing list