[RCD] 'preferences' column initialization in user_create

Jacques Belin jbelin at oryva.net
Fri Oct 23 02:41:51 CEST 2020



Le mercredi 21 octobre 2020 16:08:08,
Aleksander Machniak <alec at alec.pl> a écrit:

> On 12.10.2020 15:34, Jacques Belin wrote:
> 
> > @@ -621,6 +621,7 @@
> >              'user_email' => $user_email,
> >              'email_list' => $email_list,
> >              'language'   =>  $_SESSION['language'],
> > +            'preferences'   =>  serialize(array()),
> 
> At this stage it would be better to use an array, and serialize later
> (on insert).

True, and it is a little more simple to manage on the plugin's side...

> 
> > And even beyond the squirrelmail_usercopy plugin, I think this change
> > could help others user-creation related plugins.
> 
> Please, create a pull request. I don't have much time recently, but the
> feature makes sense, so we'll most likely accept it.

The pull request is on its way. :-)


Jacques.
-- 
The last man connected to the Internet was browsing some old Web sites.
"You have new mail" appeared on the screen...
--------------------------- adapted from a short Fredric Brown's story


More information about the dev mailing list