<div dir="ltr"><div><div><div><div><div><div><div><div><div><div><div><div><div><div><div><div>Hey everybody,<br><br></div>I'm David and I would like to help out. Starting on any project, it's usually best to get familiar with the codebase.<br>
<br>Now - I really enjoy combing through and cleaning up codebases and that's usually a great way to do just that.<br><br>To give an example, I've recently done this to RedBeanPHP, you can check out the details here:<br>
</div><br></div>Discussion: <a href="https://groups.google.com/forum/#!topic/redbeanorm/S8EnZTIZPDE">https://groups.google.com/forum/#!topic/redbeanorm/S8EnZTIZPDE</a><br></div><br>Repository: <a href="https://github.com/gabordemooij/redbean">https://github.com/gabordemooij/redbean</a><br>
<br></div>Pull Requests:<br><br><a href="https://github.com/gabordemooij/redbean/pull/281">https://github.com/gabordemooij/redbean/pull/281</a><br><a href="https://github.com/gabordemooij/redbean/pull/282">https://github.com/gabordemooij/redbean/pull/282</a><br>
<a href="https://github.com/gabordemooij/redbean/pull/289">https://github.com/gabordemooij/redbean/pull/289</a><br><br></div>So - in a nutshell, that's what I'm offering to do for Roundcube.<br><br></div>Examples, picked at random:<br>
<br></div>/plugins/archive/archive.php<br></div>Original: <a href="https://github.com/roundcube/roundcubemail/blob/master/plugins/archive/archive.php">https://github.com/roundcube/roundcubemail/blob/master/plugins/archive/archive.php</a><br>
</div>Cleanup: <a href="https://gist.github.com/daviddeutsch/6285028">https://gist.github.com/daviddeutsch/6285028</a><br><br></div><div>/installer/rcube_install.php<br></div><div>Original: <a href="https://github.com/roundcube/roundcubemail/blob/master/installer/rcube_install.php">https://github.com/roundcube/roundcubemail/blob/master/installer/rcube_install.php</a><br>
</div>Cleanup: <a href="https://gist.github.com/daviddeutsch/6285286">https://gist.github.com/daviddeutsch/6285286</a><br><br>/program/lib/Roundcube/rcube_vcard.php<br></div><div>Original: <a href="https://github.com/roundcube/roundcubemail/blob/master/program/lib/Roundcube/rcube_vcard.php">https://github.com/roundcube/roundcubemail/blob/master/program/lib/Roundcube/rcube_vcard.php</a><br>
</div>Cleanup: <a href="https://gist.github.com/daviddeutsch/6285504">https://gist.github.com/daviddeutsch/6285504</a><br><br></div><div>All as one commit: <a href="https://github.com/daviddeutsch/roundcubemail/commit/568051120f98070b554bc0879dd8854fb0e204c5">https://github.com/daviddeutsch/roundcubemail/commit/568051120f98070b554bc0879dd8854fb0e204c5</a><br>
<br></div><div><br></div>I like code concise and self explanatory. I think if there are more than three indents (within a function), you can usually simplify the code and make it easier to understand while you're at it. I actually, weirdly, enjoy a 80 character line limit and while I usually prefer tabs (I disagree with PSR-2 on that), I'm fine coding with 4 spaces for indentation.<br>
<br></div>I'd be happy to accommodate to special customs, of course, although I do think that sticking to PSR - flawed as it may be in spots - really helps enable collaboration by convention. Let me know if this sounds like something that would at all be welcome in this project.<br>
<br></div>best regards,<br></div>David Deutsch<br></div>