[Svn] r1344 bugs

till klimpong at gmail.com
Wed Apr 30 16:14:58 CEST 2008


On Wed, Apr 30, 2008 at 4:12 PM, Thomas Bruederli <roundcube at gmail.com> wrote:
> till wrote:
>
> >
> > Err, how does it break it?
> >
> > It just wraps all the $class->var calls so you can access protected
> vars/etc. ?
> >
>
>  I just got an (almost) empty html page on my screen after updating. The
> template was present but there was no form. Also I don't see an improvement
> in implementing __get() and __set() just to provide access to private vars.
>
>  Here we better use the existing methods and keep those vars protected.

I don't agree, __get()/__set() are used to make some variables - not
all - available through $foo->varname.

I think rcube_template needs to be adjusted and then it would work.

Till
_______________________________________________
http://lists.roundcube.net/mailman/listinfo/svn



More information about the Svn mailing list