[Svn] r1344 bugs

Eric Stadtherr estadtherr at gmail.com
Wed May 7 14:56:00 CEST 2008


A.L.E.C wrote:
> till wrote:
>   
>>>  Ok, I know when it isn't working. When you click Compose before browser
>>>  gets _action=getunread response (I must wait few seconds). So, it's not
>>>  related to r1344.
>>>     
>>>       
>> Race conditions!
>>
>>   
>>     
>
> Yup. How about something like that?:
>
> --- app.js.old  2008-05-07 11:16:25.000000000 +0200
> +++ app.js      2008-05-07 11:59:27.280399044 +0200
> @@ -226,6 +226,7 @@
>          if (this.gui_objects.mailboxlist)
>          {
>            this.gui_objects.folderlist = this.gui_objects.mailboxlist;
> +         this.enable_command('compose', false);
>            this.http_request('getunread', '');
>          }
>
> @@ -3531,6 +3532,7 @@
>
>        case 'check-recent':
>        case 'getunread':
> +       this.enable_command('compose', true);
>         this.enable_command('show', 'expunge', 'select-all', 
> 'select-none', 'sort', (this.env.messagecount > 0));
>         this.enable_command('purge', (this.env.messagecount && 
> (this.env.mailbox==this.env.trash_mailbox || 
> this.env.mailbox==this.env.junk_mailbox)));
>
>   

My only reservation with this solution is that it makes message 
composition (which should be able to occur on its own) dependent on the 
"get unread" query. There is no technical reason for imposing this 
constraint. What is it about the "getunread" command that makes 
composition work?


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.roundcube.net/pipermail/svn/attachments/20080507/c7f9bc31/attachment-0001.html>
-------------- next part --------------
_______________________________________________
http://lists.roundcube.net/mailman/listinfo/svn


More information about the Svn mailing list