[Svn] r3038 - in trunk/roundcubemail: . config plugins plugins/force_https
roundcube at gmail.com
Thu Oct 15 18:43:03 CEST 2009
On 15.10.2009, at 08:59, "A.L.E.C" <alec at alec.pl> wrote:
> Thomas Bruederli wrote:
>> Hi Alec,
>> What was the intention to move this config option to a plugin?
>> The proposed patch in #1486091 was IMO good enough and now some
>> (including me) need to change their configuration when they upgrade.
>> It's a bit dangerous because not everybody will notice this change.
> I just don't like to have a thousand options in config. I think it's
> better to have this as a plugin. Maybe adding info in UPGRADING
> would be enought? If no, re-implement this as a core feature or
> revert and postpone to 0.4.
I agree that having thousand config options is not what we want and we
should definitely think about creating plugins when new requests come
But on the other side we should keep existing options where they are
and make sure that installations of Roundcube do not change their
behavoir when applying minor upgrades.
The simplest change in this particular case would be to accept integer
values for the existing config option and take them as port number.
Boolean values stand for the default port.
More opinions are welcome...
More information about the Svn