[Svn] r4472 - in trunk/plugins: managesieve password

trac at roundcube.net trac at roundcube.net
Sun Jan 30 21:33:44 CET 2011


Author: alec
Date: 2011-01-30 14:33:44 -0600 (Sun, 30 Jan 2011)
New Revision: 4472

Modified:
   trunk/plugins/managesieve/Changelog
   trunk/plugins/managesieve/managesieve.js
   trunk/plugins/password/package.xml
   trunk/plugins/password/password.js
Log:
- Fix double request and onclick behaviour on tabs using Firefox


Modified: trunk/plugins/managesieve/Changelog
===================================================================
--- trunk/plugins/managesieve/Changelog	2011-01-30 19:43:26 UTC (rev 4471)
+++ trunk/plugins/managesieve/Changelog	2011-01-30 20:33:44 UTC (rev 4472)
@@ -4,6 +4,7 @@
 - Fix multi-line strings parsing (#1487685)
 - Added tests for script parser
 - Rewritten script parser
+- Fix double request when clicking on Filters tab using Firefox
 
 * version 2.10 [2010-10-10]
 -----------------------------------------------------------

Modified: trunk/plugins/managesieve/managesieve.js
===================================================================
--- trunk/plugins/managesieve/managesieve.js	2011-01-30 19:43:26 UTC (rev 4471)
+++ trunk/plugins/managesieve/managesieve.js	2011-01-30 20:33:44 UTC (rev 4472)
@@ -7,12 +7,10 @@
     var button = $('<a>').attr('href', rcmail.env.comm_path+'&_action=plugin.managesieve')
       .attr('title', rcmail.gettext('managesieve.managefilters'))
       .html(rcmail.gettext('managesieve.filters'))
-      .bind('click', function(e){ return rcmail.command('plugin.managesieve', this) })
       .appendTo(tab);
 
     // add button and register commands
     rcmail.add_element(tab, 'tabs');
-    rcmail.register_command('plugin.managesieve', function() { rcmail.goto_url('plugin.managesieve') }, true);
     rcmail.register_command('plugin.managesieve-save', function() { rcmail.managesieve_save() }, true);
     rcmail.register_command('plugin.managesieve-add', function() { rcmail.managesieve_add() }, true);
     rcmail.register_command('plugin.managesieve-del', function() { rcmail.managesieve_del() }, true);

Modified: trunk/plugins/password/package.xml
===================================================================
--- trunk/plugins/password/package.xml	2011-01-30 19:43:26 UTC (rev 4471)
+++ trunk/plugins/password/package.xml	2011-01-30 20:33:44 UTC (rev 4472)
@@ -35,6 +35,7 @@
 - ldap/ldap_simple drivers: support %dc variable in config
 - ldap/ldap_simple drivers: support Samba password change
 - Fix extended error messages handling (#1487676)
+- Fix double request when clicking on Password tab in Firefox
     </notes>
 	<contents>
 		<dir baseinstalldir="/" name="/">

Modified: trunk/plugins/password/password.js
===================================================================
--- trunk/plugins/password/password.js	2011-01-30 19:43:26 UTC (rev 4471)
+++ trunk/plugins/password/password.js	2011-01-30 20:33:44 UTC (rev 4472)
@@ -7,13 +7,11 @@
   rcmail.addEventListener('init', function(evt) {
     // <span id="settingstabdefault" class="tablink"><roundcube:button command="preferences" type="link" label="preferences" title="editpreferences" /></span>
     var tab = $('<span>').attr('id', 'settingstabpluginpassword').addClass('tablink');
-    
-    var button = $('<a>').attr('href', rcmail.env.comm_path+'&_action=plugin.password').html(rcmail.gettext('password')).appendTo(tab);
-    button.bind('click', function(e){ return rcmail.command('plugin.password', this) });
+    var button = $('<a>').attr('href', rcmail.env.comm_path+'&_action=plugin.password')
+      .html(rcmail.gettext('password')).appendTo(tab);
 
     // add button and register commands
     rcmail.add_element(tab, 'tabs');
-    rcmail.register_command('plugin.password', function() { rcmail.goto_url('plugin.password') }, true);
     rcmail.register_command('plugin.password-save', function() { 
       var input_curpasswd = rcube_find_object('_curpasswd');
       var input_newpasswd = rcube_find_object('_newpasswd');

_______________________________________________
http://lists.roundcube.net/mailman/listinfo/svn



More information about the Svn mailing list