[Svn] [roundcube/roundcubemail] 545a15: Steps -> Actions refactoring (#7688)

Aleksander Machniak noreply at github.com
Sun Nov 1 11:25:52 CET 2020


  Branch: refs/heads/master
  Home:   https://github.com/roundcube/roundcubemail
  Commit: 545a1569f115b5c8aa0be78061258d5f116d7b4b
      https://github.com/roundcube/roundcubemail/commit/545a1569f115b5c8aa0be78061258d5f116d7b4b
  Author: Aleksander Machniak <alec at alec.pl>
  Date:   2020-11-01 (Sun, 01 Nov 2020)

  Changed paths:
    M .ci/install.sh
    M .ci/run.sh
    M .ci/setup.sh
    M index.php
    M plugins/acl/acl.php
    M plugins/archive/archive.php
    M plugins/debug_logger/runlog/runlog.php
    M plugins/enigma/lib/enigma_engine.php
    M plugins/enigma/lib/enigma_ui.php
    M plugins/managesieve/lib/Roundcube/rcube_sieve.php
    M plugins/managesieve/lib/Roundcube/rcube_sieve_engine.php
    M plugins/managesieve/lib/Roundcube/rcube_sieve_forward.php
    M plugins/managesieve/lib/Roundcube/rcube_sieve_vacation.php
    M plugins/managesieve/managesieve.php
    M plugins/vcard_attachments/vcard_attachments.php
    M plugins/zipdownload/zipdownload.php
    A program/actions/contacts/copy.php
    A program/actions/contacts/delete.php
    A program/actions/contacts/edit.php
    A program/actions/contacts/export.php
    A program/actions/contacts/group_addmembers.php
    A program/actions/contacts/group_create.php
    A program/actions/contacts/group_delete.php
    A program/actions/contacts/group_delmembers.php
    A program/actions/contacts/group_rename.php
    A program/actions/contacts/import.php
    A program/actions/contacts/index.php
    A program/actions/contacts/list.php
    A program/actions/contacts/mailto.php
    A program/actions/contacts/move.php
    A program/actions/contacts/photo.php
    A program/actions/contacts/print.php
    A program/actions/contacts/qrcode.php
    A program/actions/contacts/save.php
    A program/actions/contacts/search.php
    A program/actions/contacts/search_create.php
    A program/actions/contacts/search_delete.php
    A program/actions/contacts/show.php
    A program/actions/contacts/undo.php
    A program/actions/contacts/upload_photo.php
    A program/actions/login/oauth.php
    A program/actions/mail/addcontact.php
    A program/actions/mail/attachment_delete.php
    A program/actions/mail/attachment_display.php
    A program/actions/mail/attachment_rename.php
    A program/actions/mail/attachment_upload.php
    A program/actions/mail/autocomplete.php
    A program/actions/mail/bounce.php
    A program/actions/mail/check_recent.php
    A program/actions/mail/compose.php
    A program/actions/mail/copy.php
    A program/actions/mail/delete.php
    A program/actions/mail/folder_expunge.php
    A program/actions/mail/folder_purge.php
    A program/actions/mail/get.php
    A program/actions/mail/getunread.php
    A program/actions/mail/group_expand.php
    A program/actions/mail/headers.php
    A program/actions/mail/import.php
    A program/actions/mail/index.php
    A program/actions/mail/list.php
    A program/actions/mail/list_contacts.php
    A program/actions/mail/mark.php
    A program/actions/mail/move.php
    A program/actions/mail/pagenav.php
    A program/actions/mail/search.php
    A program/actions/mail/search_contacts.php
    A program/actions/mail/send.php
    A program/actions/mail/sendmdn.php
    A program/actions/mail/show.php
    A program/actions/mail/viewsource.php
    A program/actions/settings/about.php
    A program/actions/settings/folder_create.php
    A program/actions/settings/folder_delete.php
    A program/actions/settings/folder_edit.php
    A program/actions/settings/folder_purge.php
    A program/actions/settings/folder_rename.php
    A program/actions/settings/folder_save.php
    A program/actions/settings/folder_size.php
    A program/actions/settings/folder_subscribe.php
    A program/actions/settings/folder_unsubscribe.php
    A program/actions/settings/folders.php
    A program/actions/settings/identities.php
    A program/actions/settings/identity_create.php
    A program/actions/settings/identity_delete.php
    A program/actions/settings/identity_edit.php
    A program/actions/settings/identity_save.php
    A program/actions/settings/index.php
    A program/actions/settings/prefs_edit.php
    A program/actions/settings/prefs_save.php
    A program/actions/settings/response_create.php
    A program/actions/settings/response_delete.php
    A program/actions/settings/response_edit.php
    A program/actions/settings/response_save.php
    A program/actions/settings/responses.php
    A program/actions/settings/upload.php
    A program/actions/settings/upload_display.php
    A program/actions/utils/error.php
    A program/actions/utils/html2text.php
    A program/actions/utils/killcache.php
    A program/actions/utils/modcss.php
    A program/actions/utils/save_pref.php
    A program/actions/utils/spell.php
    A program/actions/utils/spell_html.php
    A program/actions/utils/text2html.php
    M program/include/iniset.php
    M program/include/rcmail.php
    A program/include/rcmail_action.php
    A program/include/rcmail_attachment_handler.php
    M program/include/rcmail_output.php
    M program/include/rcmail_output_cli.php
    M program/include/rcmail_output_html.php
    M program/include/rcmail_output_json.php
    M program/include/rcmail_sendmail.php
    M program/lib/Roundcube/db/oracle.php
    M program/lib/Roundcube/rcube.php
    M program/lib/Roundcube/rcube_addressbook.php
    M program/lib/Roundcube/rcube_addresses.php
    M program/lib/Roundcube/rcube_config.php
    M program/lib/Roundcube/rcube_db.php
    M program/lib/Roundcube/rcube_image.php
    M program/lib/Roundcube/rcube_imap.php
    M program/lib/Roundcube/rcube_imap_cache.php
    M program/lib/Roundcube/rcube_imap_generic.php
    M program/lib/Roundcube/rcube_ldap.php
    M program/lib/Roundcube/rcube_mime_decode.php
    M program/lib/Roundcube/rcube_output.php
    M program/lib/Roundcube/rcube_result_set.php
    M program/lib/Roundcube/rcube_smtp.php
    M program/lib/Roundcube/rcube_user.php
    M program/lib/Roundcube/rcube_utils.php
    M program/lib/Roundcube/rcube_vcard.php
    M program/lib/Roundcube/rcube_washtml.php
    M program/lib/Roundcube/session/redis.php
    R program/steps/addressbook/copy.inc
    R program/steps/addressbook/delete.inc
    R program/steps/addressbook/edit.inc
    R program/steps/addressbook/export.inc
    R program/steps/addressbook/func.inc
    R program/steps/addressbook/groups.inc
    R program/steps/addressbook/import.inc
    R program/steps/addressbook/list.inc
    R program/steps/addressbook/mailto.inc
    R program/steps/addressbook/move.inc
    R program/steps/addressbook/photo.inc
    R program/steps/addressbook/print.inc
    R program/steps/addressbook/qrcode.inc
    R program/steps/addressbook/save.inc
    R program/steps/addressbook/search.inc
    R program/steps/addressbook/show.inc
    R program/steps/addressbook/undo.inc
    R program/steps/addressbook/upload_photo.inc
    R program/steps/login/oauth.inc
    R program/steps/mail/addcontact.inc
    R program/steps/mail/attachments.inc
    R program/steps/mail/autocomplete.inc
    R program/steps/mail/bounce.inc
    R program/steps/mail/check_recent.inc
    R program/steps/mail/compose.inc
    R program/steps/mail/copy.inc
    R program/steps/mail/folders.inc
    R program/steps/mail/func.inc
    R program/steps/mail/get.inc
    R program/steps/mail/getunread.inc
    R program/steps/mail/headers.inc
    R program/steps/mail/import.inc
    R program/steps/mail/list.inc
    R program/steps/mail/list_contacts.inc
    R program/steps/mail/mark.inc
    R program/steps/mail/move_del.inc
    R program/steps/mail/pagenav.inc
    R program/steps/mail/search.inc
    R program/steps/mail/search_contacts.inc
    R program/steps/mail/sendmail.inc
    R program/steps/mail/sendmdn.inc
    R program/steps/mail/show.inc
    R program/steps/mail/viewsource.inc
    R program/steps/settings/about.inc
    R program/steps/settings/edit_folder.inc
    R program/steps/settings/edit_identity.inc
    R program/steps/settings/edit_prefs.inc
    R program/steps/settings/edit_response.inc
    R program/steps/settings/folders.inc
    R program/steps/settings/func.inc
    R program/steps/settings/identities.inc
    R program/steps/settings/responses.inc
    R program/steps/settings/save_folder.inc
    R program/steps/settings/save_identity.inc
    R program/steps/settings/save_prefs.inc
    R program/steps/settings/upload.inc
    R program/steps/utils/error.inc
    R program/steps/utils/html2text.inc
    R program/steps/utils/killcache.inc
    R program/steps/utils/modcss.inc
    R program/steps/utils/save_pref.inc
    R program/steps/utils/spell.inc
    R program/steps/utils/spell_html.inc
    R program/steps/utils/text2html.inc
    A tests/ActionTestCase.php
    A tests/Actions/Contacts/Copy.php
    A tests/Actions/Contacts/Delete.php
    A tests/Actions/Contacts/Edit.php
    A tests/Actions/Contacts/Export.php
    A tests/Actions/Contacts/GroupAddmembers.php
    A tests/Actions/Contacts/GroupCreate.php
    A tests/Actions/Contacts/GroupDelete.php
    A tests/Actions/Contacts/GroupDelmembers.php
    A tests/Actions/Contacts/GroupRename.php
    A tests/Actions/Contacts/Import.php
    A tests/Actions/Contacts/Index.php
    A tests/Actions/Contacts/List.php
    A tests/Actions/Contacts/Mailto.php
    A tests/Actions/Contacts/Move.php
    A tests/Actions/Contacts/Photo.php
    A tests/Actions/Contacts/Print.php
    A tests/Actions/Contacts/Qrcode.php
    A tests/Actions/Contacts/Save.php
    A tests/Actions/Contacts/Search.php
    A tests/Actions/Contacts/SearchCreate.php
    A tests/Actions/Contacts/SearchDelete.php
    A tests/Actions/Contacts/Show.php
    A tests/Actions/Contacts/Undo.php
    A tests/Actions/Contacts/UploadPhoto.php
    A tests/Actions/Login/Oauth.php
    A tests/Actions/Mail/Addcontact.php
    A tests/Actions/Mail/AttachmentDelete.php
    A tests/Actions/Mail/AttachmentDisplay.php
    A tests/Actions/Mail/AttachmentRename.php
    A tests/Actions/Mail/AttachmentUpload.php
    A tests/Actions/Mail/Autocomplete.php
    A tests/Actions/Mail/Bounce.php
    A tests/Actions/Mail/CheckRecent.php
    A tests/Actions/Mail/Compose.php
    A tests/Actions/Mail/Copy.php
    A tests/Actions/Mail/Delete.php
    A tests/Actions/Mail/FolderExpunge.php
    A tests/Actions/Mail/FolderPurge.php
    A tests/Actions/Mail/Get.php
    A tests/Actions/Mail/Getunread.php
    A tests/Actions/Mail/GroupExpand.php
    A tests/Actions/Mail/Headers.php
    A tests/Actions/Mail/Import.php
    A tests/Actions/Mail/Index.php
    A tests/Actions/Mail/List.php
    A tests/Actions/Mail/ListContacts.php
    A tests/Actions/Mail/Mark.php
    A tests/Actions/Mail/Move.php
    A tests/Actions/Mail/Pagenav.php
    A tests/Actions/Mail/Search.php
    A tests/Actions/Mail/SearchContacts.php
    A tests/Actions/Mail/Send.php
    A tests/Actions/Mail/Sendmdn.php
    A tests/Actions/Mail/Show.php
    A tests/Actions/Mail/Viewsource.php
    A tests/Actions/Settings/About.php
    A tests/Actions/Settings/FolderCreate.php
    A tests/Actions/Settings/FolderDelete.php
    A tests/Actions/Settings/FolderEdit.php
    A tests/Actions/Settings/FolderPurge.php
    A tests/Actions/Settings/FolderRename.php
    A tests/Actions/Settings/FolderSave.php
    A tests/Actions/Settings/FolderSize.php
    A tests/Actions/Settings/FolderSubscribe.php
    A tests/Actions/Settings/FolderUnsubscribe.php
    A tests/Actions/Settings/Folders.php
    A tests/Actions/Settings/Identities.php
    A tests/Actions/Settings/IdentityCreate.php
    A tests/Actions/Settings/IdentityDelete.php
    A tests/Actions/Settings/IdentityEdit.php
    A tests/Actions/Settings/IdentitySave.php
    A tests/Actions/Settings/Index.php
    A tests/Actions/Settings/PrefsEdit.php
    A tests/Actions/Settings/PrefsSave.php
    A tests/Actions/Settings/ResponseCreate.php
    A tests/Actions/Settings/ResponseDelete.php
    A tests/Actions/Settings/ResponseEdit.php
    A tests/Actions/Settings/ResponseSave.php
    A tests/Actions/Settings/Responses.php
    A tests/Actions/Settings/Upload.php
    A tests/Actions/Settings/UploadDisplay.php
    A tests/Actions/Utils/Error.php
    A tests/Actions/Utils/Html2text.php
    A tests/Actions/Utils/Killcache.php
    A tests/Actions/Utils/Modcss.php
    A tests/Actions/Utils/SavePref.php
    A tests/Actions/Utils/Spell.php
    A tests/Actions/Utils/SpellHtml.php
    A tests/Actions/Utils/Text2html.php
    M tests/Browser/Components/Dialog.php
    M tests/Browser/Mail/ComposeTest.php
    M tests/Browser/Settings/Preferences/GeneralTest.php
    M tests/Browser/Settings/Preferences/ServerTest.php
    M tests/Browser/bootstrap.php
    A tests/ExitException.php
    M tests/Framework/Addresses.php
    M tests/Framework/Bootstrap.php
    M tests/Framework/Washtml.php
    R tests/MailFunc.php
    A tests/OutputHtmlMock.php
    A tests/OutputJsonMock.php
    A tests/Rcmail/AttachmentHandler.php
    A tests/Rcmail/RcmailAction.php
    A tests/StorageMock.php
    M tests/bootstrap.php
    M tests/phpunit.xml
    A tests/src/sql/contacts.sql
    A tests/src/sql/init.sql

  Log Message:
  -----------
  Steps -> Actions refactoring (#7688)

* Move action handling code to rcmail class
* Add rcmail_action class
* Add action aliases
* Get rid of $OUTPUT global
* Move some methods from rcmail to rcmail_action
* PHP8 compat. fixes
* Add framework for testing actions
* Fix obvious code mistakes



More information about the svn mailing list