[Svn] [roundcube/roundcubemail] 67825e: MySQL: Don't reissue query after deadlock error (#...

Michael Stilkerich noreply at github.com
Fri Sep 25 12:32:42 CEST 2020


  Branch: refs/heads/master
  Home:   https://github.com/roundcube/roundcubemail
  Commit: 67825e6320a8fbe860750679d07ce11e354d6675
      https://github.com/roundcube/roundcubemail/commit/67825e6320a8fbe860750679d07ce11e354d6675
  Author: Michael Stilkerich <ms at mike2k.de>
  Date:   2020-09-25 (Fri, 25 Sep 2020)

  Changed paths:
    M program/lib/Roundcube/db/mysql.php

  Log Message:
  -----------
  MySQL: Don't reissue query after deadlock error (#7529)

When a deadlock error occurs, MySQL rolls back the _entire_ ongoing
transaction. The application would have to restart the transaction from
the beginning to retry if wanted.

Now roundcube in that case simply retries the statement that raised the
deadlock error, even though everything else in the transaction was
rolled back. This breaks transaction isolation, leaves the database in a
potentially inconsistent state (from the application's data consistency
model point of view), and does not indicate to the application there was
a problem at all to it may even continue executing other potentially
remaining statements of a transaction that has already been rolled back.

-> Remove the retries from roundcube. Retries have to be initiated by
the application if desired, not only retrying the last statement but the
entire transaction from the beginning.



More information about the svn mailing list