Dev

dev@lists.roundcube.net

2 participants
4310 discussions

Ticket #1485659
by Robin Elfrink 24 Apr '09

24 Apr '09

Hi, Trying to fix ticket #1485659. There's a race condiction, in session handling. I think I got that with attached patch. Session data is stored serialized(), but not exactly. So I had to create extra unserialize/serialize functions for that. Downside is that unset($_SESSION['var']) will not work reliable anymore, so an extra rcube_sess_unset('var') was needed as well. Please point me at any mistakes I made :) Robin --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/xp/kFPRx0aF/_1485659.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

4 10

Fwd: Re: GMail Bug
by Sandro Pazzi 23 Apr '09

23 Apr '09

Sorry, for error I have send directly to alec ... -------- Original Message -------- Subject: Re: [RCD] GMail Bug Date: Thu, 23 Apr 2009 11:40:09 +0200 From: Sandro Pazzi <sandro(a)idweb.it> To: "A.L.E.C" <alec(a)alec.pl> Reply-To: sandro.pazzi(a)idweb.it Hi alec, but why RC don't use uid? UID COPY <sequence uid> "folder" UID STORE <sequence uid> +FLAGS.SILENT (\Deleted) UID FETCH <sequence uid> (<params>) ... was a standard IMAP command that use directly uid instead of id of messages. In this way all the problems with gmail was resolved. Thanks On Thu, 23 Apr 2009 10:07:23 +0200, "A.L.E.C" <alec(a)alec.pl> wrote: > Sandro Pazzi wrote: > >> I'm using gmail like imap server with RC and I find a bug (I think gMail >> bug). >> Seems related the open tiket 1485746. >> >> RC use the message position for deleting and not it's UID. When a message >> was copy in the trash folder google expunge it automatically. Than RC set >> the flag /deleted at the message that was just expunged and it flag the >> previous message that now have the same position. RC in this way delete 2 >> messages. >> >> This is my workorund. > >> foreach ($a_messages as $uid) >> $a_oldmessagesuid[] = iil_C_ID2UID($conn, $from, $uid); > ... >> $r = iil_C_Copy($conn, $messages, $from,$to); > ... >> foreach ($a_messages as $uid) >> $a_newmessagesuid[] = iil_C_ID2UID($conn, $from, $uid); > > An expensive workaround. Perfect opportunity to use COPYUID feature from > UIDPLUS extension, also id-to-uid conversion could be done in one FETCH > command. Does gmail support UIDPLUS? -- Sandro Pazzi IdWeb s.r.l. Viale Romagna 69/A - 06012 Citta' di Castello (PG) Tel. 075 851 97 28 Fax 075 851 97 30 _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

GMail Bug
by Sandro Pazzi 23 Apr '09

23 Apr '09

Hi all, I'm using gmail like imap server with RC and I find a bug (I think gMail bug). Seems related the open tiket 1485746. RC use the message position for deleting and not it's UID. When a message was copy in the trash folder google expunge it automatically. Than RC set the flag /deleted at the message that was just expunged and it flag the previous message that now have the same position. RC in this way delete 2 messages. This is my workorund. I've modify the imap.inc in the program/lib folder in this way: function iil_C_Move(&$conn, $messages, $from, $to) { $fp = $conn->fp; if (!$from || !$to) { return -1; } /* IDWEB START Modify */ // Check for GMail auto expunge messages when copied in trash folder $a_messages = explode(',', $messages); $a_oldmessagesuid = array(); foreach ($a_messages as $uid) $a_oldmessagesuid[] = iil_C_ID2UID($conn, $from, $uid); $oldmessagesuid = join(',', $a_oldmessagesuid); /* IDWEB STOP Modify */ $r = iil_C_Copy($conn, $messages, $from,$to); if ($r==0) { /* IDWEB START Modify */ $a_newmessagesuid = array(); foreach ($a_messages as $uid) $a_newmessagesuid[] = iil_C_ID2UID($conn, $from, $uid); $newmessagesuid = join(',', $a_newmessagesuid); if($newmessagesuid == $oldmessagesuid) // Delete only if there is not autoexpunge action by IMAP server /* IDWEB STOP Modify */ return iil_C_Delete($conn, $from, $messages); } return $r; } I can't open directly a tiket becouse I can't create a new account. I hope that u can include a workaround like this in the next release. Thanks all -- Sandro _______________________________________________ List info: http://lists.roundcube.net/dev/

2 2

BUG #1485777 Wrongly displayed UTF-8 encoded HTML emails
by Galo Xucro 22 Apr '09

22 Apr '09

Dear Sirs The attatched file is the source code of mail message that can help solving bug #1485777. Just put this file into your 'Maildir' folder of your mail server, fix its ownership and file permissions and open it in Roundcube. Instead of: 'Política de Segurança' , Roundcube will display: 'PolÃtica de SeguranÃ§a' If you open the message in Thunderbird, Outlook Express or Squirrelmail the message will be displayed correctly. Galo Xucro --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/uJ/xjWUCt8k/msg-bug-1485777.txt Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

3 6

Plugin API questions
by Naveen Gavini 20 Apr '09

20 Apr '09

We are trying to experiment with the new Plugin API and have come across several questions. We are trying to have our plugin act as its own task and have its own page with a button in the taskbar. I was reading through the mailing list to figure out how to do this, and could not find anything substantial. I found an email stating: this->add_button(..., 'taskbar'); or client side with rcmail.add_element('<a href...', 'taskbar'); I added this-> add_button('asd', 'taskbar'); to the init function of the new plugin but it did not add anything to the taskbar. Secondly how would we create the page for this new task? Also, I was curious if anyone has ported some of the existing patches on the roundcube forums into a plugin format (such as sieve). Thanks. Naveen Gavini Student Systems Programmer OSS/CSS - OIT Rutgers ngavini(a)jla.rutgers.edu _______________________________________________ List info: http://lists.roundcube.net/dev/

2 3

jquery performance
by A.L.E.C 20 Apr '09

20 Apr '09

Hi! Displaying messages list via Ajax using jquery is 4-5 times slower than previous solution using DOM methods (function rcmail.add_message_row() and some code in list.js). For 100 messages per page it tooks: Firefox: jquery 1100ms, DOM 250 ms Opera: jquery 400ms, DOM 80ms. Conclusion: don't use jquery everywhere (specially in code executed many times)! -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Project Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Error: log in two different syslog files
by Zhang Huangbin 18 Apr '09

18 Apr '09

Hi, all. I use syslog as log_driver, but it sent the same message to /var/log/messages and /var/log/roundcube.log. I just want to make it log to /var/log/roundcube.log. How can i solve this issue? My settings in config/main.inc.php: ---- $rcmail_config['debug_level'] = 1; $rcmail_config['log_driver'] = "syslog"; $rcmail_config['syslog_id'] = "roundcube"; $rcmail_config['syslog_facility'] = LOG_LOCAL3; ---- /etc/syslog.conf: ---- *.info;mail.none;authpriv.none;cron.none /var/log/messages authpriv.* /var/log/secure mail.* -/var/log/maillog cron.* /var/log/cron *.emerg * uucp,news.crit /var/log/spooler local7.* /var/log/boot.log local4.* -/var/log/openldap.log local0.* -/var/log/roundcube.log ---- Thanks very much. :) -- Best regards. Zhang Huangbin - Open Source Mail Server Solution for RHEL/CentOS 5.x: http://code.google.com/p/iredmail/ _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Safari: input type="search"
by A.L.E.C 17 Apr '09

17 Apr '09

I see it's used in quicksearchbox. Is this really useful? I don't like it here. -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Project Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

3 3

Ticket #1485393: timezones are not localized
by Frank van den Brink 17 Apr '09

17 Apr '09

Heya! I implemented this by making some small changes to roundcubemail/program/include/rcmail.php to load a separate timezones.inc file from the language's localization directory. I also moved the names of the timezones from roundcubemail/program/steps/settings/func.inc to an initial timezones.inc for en_US, and made it load them from rcube_label() instead. I also added timezones.inc files for all the other localizations with just an empty array, to prevent include errors. Patch is attached. Criticism welcomed. Best wishes, Frank van den Brink P.S. I tried using trac, but its registration page told me that "No handler matched request to /register". --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Dk/V83gEBww/0001-Added-timezone-.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

3 6

Updated Latvian translation
by Lauris Bukšis-Haberkorns 16 Apr '09

16 Apr '09

Updated missing keys for Latvian translation Lauris --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/1s/exRNBa72/labels.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 1

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev