Dev

dev@lists.roundcube.net

2 participants
4310 discussions

structural change proposal and LDAP issues
by Daniel Mealha Cabrita 17 Oct '08

17 Oct '08

hi there, There are some changes I find appropriate to do regarding the classes, which are stored in the include directory. The motivation is to improve the modularization _and_ to avoid flooding the include directory with dozens of small files. I've got features which use LDAP (yet structurally extensible to additional mechanisms) and I need a more basic and standard LDAP class for that. 1. - I'm currently splitting the rcube_ldap class in two: 1.1 One specific to the addressbook feature (with the very same behavior as before), with inheritance from the classe described in 1.2. 1.2 - Another one being a superclass, for generic ldap access. >From what I could understand on the philosophy of the classes used in RC, although we may have several classes in the same file, only one is supposed to be externally accessible (and it seems that the filename itself is used to determine which one). Once we start modularizing things (like allowing a different mechanism for external addressbooks, instead of only LDAP as currently it is), if we follow this logic we may end with too many files. 2. Now about what I am proposing. I'll give an example which, hopefully, will clarify what I have in mind: 2.1 - To create a new rcube_ldap.php file with a generic LDAP class only (yes, addressbook code would have to the moved to another place, or we could call the former rcube_ldap_generic.php to simplify the transition). 2.2 - A rcube_XYZ.php file providing a specific feature (addressbook, user identity etc). In that same file there are additional classes providing services according the mechanism chosen (LDAP etc). This file would have the XYZ-specific code when dealing with LDAP (through the generic LDAP class) and any other mechanism which could be added in the future. It _seems_ to me that the current philosophy expects the item 2.2 to be broken in two or more pieces, from what I see no practical benefit (and it would add lots of files once we start to support extra mechanisms). If my understanding is incorrect on this, please someone tell me so. Comments? Suggestions? -- Daniel Mealha Cabrita Divisao de Suporte Tecnico AINFO / Reitoria / UTFPR http://www.utfpr.edu.br _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Disclaimer in html and text implemented
by Jonathan Batista de Araujo Neto 17 Oct '08

17 Oct '08

Dears, I have using roundcube 0.2 beta in production environment and works fine. I did a couple of small changes to customize for our needs, I'd like to share. Here's one. I used $rcmail_config['generic_message_footerl'] = 'disclaimer.html'; as a disclaimer but the problem is that the text only mails were with html codes. So, I modified the config to: $rcmail_config['generic_message_footer_html'] = 'disclaimer.html'; $rcmail_config['generic_message_footer_txt'] = 'disclaimer.txt'; Then I changed the file: program/steps/mail/sendmail.inc I removed the original line as: if (!$savedraft && !empty($CONFIG['generic_message_footer']) && ($footer = file_get_contents(realpath($CONFIG['generic_message_footer'])))) $message_body .= "\r\n" . rcube_charset_convert($footer, 'UTF-8', $message_charset); And added it right below: if ($isHtml) { # MOD START if (!$savedraft && !empty($CONFIG['generic_message_footer_html']) && ($footer = file_get_contents(realpath($CONFIG['generic_message_footer_html'])))) $message_body .= "\r\n" . rcube_charset_convert($footer, 'UTF-8', $message_charset); # MOD END $MAIL_MIME->setHTMLBody($message_body); // add a plain text version of the e-mail as an alternative part. $h2t = new html2text($message_body); $plainTextPart = wordwrap($h2t->get_text(), 998, "\r\n", true); if (!strlen($plainTextPart)) { // empty message body breaks attachment handling in drafts $plainTextPart = "\r\n"; } $MAIL_MIME->setTXTBody(html_entity_decode($plainTextPart, ENT_COMPAT, 'utf-8')); // look for "emoticon" images from TinyMCE and copy into message as attachments rcmail_attach_emoticons($MAIL_MIME); } else { # MOD START if (!$savedraft && !empty($CONFIG['generic_message_footer_txt']) && ($footer = file_get_contents(realpath($CONFIG['generic_message_footer_txt'])))) $message_body .= "\r\n" . rcube_charset_convert($footer, 'UTF-8', $message_charset); # MOD END Hope it helps someone. Maybe it would be usefull to be included in next release. Thanks in advnce. Jonathan Araújo Administrador de Infra-estrutura de TI Gerência de TI - INDG S.A. -------------------------------------------------------------------------------- Este documento pode incluir informação confidencial e de propriedade restrita do Instituto de Desenvolvimento Gerencial-INDG e apenas pode ser lido por aquele(s) a quem sido endereçado. Se você recebeu esta mensagem de e-mail indevidamente, por favor avise-nos imediatamente. Quaisquer opiniões ou informações contidas neste e-mail pertencem ao seu remetente e não necessariamente coincidem com as do Instituto de Desenvolvimento Gerencial-INDG. Este documento não pode ser reproduzido, copiado, distribuído, publicado ou modificado por terceiros, sem a prévia autorização por escrito do Instituto de Desenvolvimento Gerencial-INDG. This document may include proprietary and confidential information of Instituto de Desenvolvimento Gerencial-INDG, and may only be read by those persons to whom it is addressed. If you have received this e-mail message in error, please notify us immediately. Any views or opinions expressed in this e-mail are those of the sender and do not necessarily coincide with those of the Instituto de Desenvolvimento Gerencial - INDG. This document may not be reproduced, copied, distributed, published, modified or furnished to third parties, without the prior written consent of Instituto de Desenvolvimento Gerencial-INDG. -------------------------------------------------------------------------------- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Galician translation
by David Garabana Barro 16 Oct '08

16 Oct '08

Corrected one word in "messages.inc" This one is the good one -- David Garabana Barro jabber & google talk ID: david(a)garabana.com Clave pública PGP/GPG: http://davide.garabana.com/pgp.html --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/gq/WhKPJZqi/messages.inc http://detached.gigo.com/rc/gq/WhKPJZqi/signature.asc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Updated galician translation
by David Garabana Barro 16 Oct '08

16 Oct '08

-- David Garabana Barro jabber & google talk ID: david(a)garabana.com Clave pública PGP/GPG: http://davide.garabana.com/pgp.html --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/E8/45cRFr9C/messages.inc http://detached.gigo.com/rc/E8/45cRFr9C/labels.inc http://detached.gigo.com/rc/E8/45cRFr9C/signature.asc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Updated Danish language translation
by Hans Christian Saustrup 16 Oct '08

16 Oct '08

Hi, Just installed RC. Love it, but found a 40-50 missing entries in the Danish language file. I've added them with the translate-o-matic script on the site, and attached it. Enjoy. Cheers, HC --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/tR/tRpc6VYj/labels.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Cymraeg language translation
by Dafydd Tomos 16 Oct '08

16 Oct '08

Hi, I've translated RoundCube 0.2beta to Cymraeg (Welsh) - cy_GB I'm attaching the translation files. I've tested these on my local copy and looks sensible so far. I'd suggest 'Cymraeg' as the label in the options. Any intention to move to .po files for translations? There are a lot of tools for gettext catalogs to make translation an easier job. thanks Dafydd --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/d6/zurcd6QG/cy.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Who is in charge of committing patches ?
by Luc Andre 15 Oct '08

15 Oct '08

Hi everybody, I posted a patch 2 months ago (http://trac.roundcube.net/ticket/1485274) I update it as regular bases to avoid conflicts, but it seems that nobody cares about committing it :-( The patch enables USB dongle hardware authentication, it has already been integrated in other open source projects (squirrelmail, phpMyAdmin, phpBB...) I already sent free swekey USB dongles to some you to validate the patch, but I didn't receive any feedback. Did I miss something in the roundcube project's policy ? Cheers, Luc _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Who is in charge of committing patches ?
by Luc Andre 15 Oct '08

15 Oct '08

1 0

Re: [RCD] on rcube_ldap (was LDAP class)
by Thomas Bruederli 14 Oct '08

14 Oct '08

Daniel Mealha Cabrita wrote: > Thomas, > > I've sent an email on this very subject to the devel mailing list, > unfortunately I've got no response. I'm sorry for that but I cannot answer every post there. Don't expect your mails being answered within a couple of days. > > Since you're the author of that code, there are some things I would like to > ask you about rcube_ldap.php. Well, others had implemented a lot of functions as well. I'm not very experienced with LDAP even if my name is found in that file. > > I'm copy-pasting the original message I sent to that list: > > > --- > I've been implementing an extension to RC which may use LDAP (depending on how > it was configured). > > There's already the > include/rcube_ldap.php > which _seems_ to present itself as a generic interface to LDAP. > > One problem is that it was implemented with addressbook in mind, so there are > lots of fields and behaviors which are useless in other cases when accessing > LDAP. Correct. What do you wanna use it for? > > The code I'm working on is intended to be integrated into the main tree of RC > (so it's not supposed to be just a quick'n'dirty patch). > With that in mind, I have two questions: > > 1. - Is the rcube_ldap class really the standard one for other > (non-addressbook) LDAP accesses? No. > 2. - If "yes" to #1, how is the "standard" way to use that to avoid future > code breakage? (a code example would be nice) > 3. - If "no" to #1, what could be an acceptable solution? A parallel and more > generic LDAP class implementation? I don't unferstand what you intend to do with LDAP and therefore I cannot answer that question. ~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] session table
by A.L.E.C 13 Oct '08

13 Oct '08

Ondřej Žára wrote: > Are you using Debian? Debian doesn't use the session GC in PHP - instead, > it cleans sessions in a cronjob. To enable PHP GC in Roundcube, one must > add (to main.inc.php) these lines: > > ini_set('session.gc_probability', 5); > ini_set('session.gc_divisor', 100); > > Values '5' and '100' were chosen experimentaly by me, use your own if you > want :) > Someone should add above info to installation manual. By the way, reading rcube_sess_gc() I found an improvement possibility. Function could be simpler and speed increased if we'll create index on cache.session_id column with "ON DELETE CASCADE" reference, but it needs innodb in mysql (foreign keys not supported by myisam tables), and triggers in sqlite (foreign keys not supported at all). -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Project Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

4 6

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev