Dev

dev@lists.roundcube.net

1 participants
4298 discussions

Log logins
by Robin Elfrink 06 Jun '08

06 Jun '08

Hi all, For various reasons I need to know who logged into RoundCube when and from where. I can't imagine any other admin not wanting to know, and I don't understand how I got to run RoundCube for so long without knowing :) I'd like to propose something like this: --- index.php (revision 1480) +++ index.php (working copy) @@ -86,6 +86,10 @@ // send auth cookie if necessary $RCMAIL->authenticate_session(); + // log successful login + if ($RCMAIL->config->get('debug_level') & 1) + console(sprintf('Successful login for %s from %s', trim(get_input_value('_user', RCUBE_INPUT_POST), ' '), $_SERVER['REMOTE_ADDR'])); + // send redirect header("Location: {$RCMAIL->comm_path}"); exit; This results in a line like this in logs/console: [06-Jun-2008 10:08:45 +0200]: Successful login for robin (id 8) from 16.35.94.15 Robin _______________________________________________ List info: http://lists.roundcube.net/dev/

3 3

attachments with national characters
by A.L.E.C 06 Jun '08

06 Jun '08

There're problems with attachment names in parts without charset specification. Example message can be found here http://trac.roundcube.net/ticket/1484969 I think we have two solutions: 1. Check charset of first (all) part(s) of message and convert filename according to it, but what when there's no charset data? 2. Detect charset using ie. mb_detect_encoding(). Here's a patch for 2. diff -ruN rc-beta3/program/include/rcube_imap.php rc-beta2/program/include/rcube_imap.php --- rc-beta3/program/include/rcube_imap.php 2008-06-06 10:20:39.672800689 +0200 +++ rc-beta2/program/include/rcube_imap.php 2008-06-06 09:39:49.031952834 +0200 @@ -1159,10 +1159,13 @@ if (is_array($part[8]) && empty($struct->parts)) $struct->parts[] = $this->_structure_part($part[8], ++$count, $struct->mime_id); } - + // normalize filename property if ($filename_mime = $struct->d_parameters['filename'] ? $struct->d_parameters['filename'] : $struct->ctype_parameters['name']) - $struct->filename = rcube_imap::decode_mime_string($filename_mime, $this->default_charset); + { + $struct->filename = rcube_imap::decode_mime_string($filename_mime, + $struct->charset ? $struct->charset : rc_detect_encoding($filename_mime, $this->default_charset)); + } else if ($filename_encoded = $struct->d_parameters['filename*'] ? $struct->d_parameters['filename*'] : $struct->ctype_parameters['name*']) { // decode filename according to RFC 2231, Section 4 @@ -1170,7 +1173,8 @@ $struct->filename = rcube_charset_convert(urldecode($filename_urlencoded), $filename_charset); } else if (!empty($struct->headers['content-description'])) - $struct->filename = rcube_imap::decode_mime_string($struct->headers['content-description'], $this->default_charset); + $struct->filename = rcube_imap::decode_mime_string($struct->headers['content-description'], + $struct->charset ? $struct->charset : rc_detect_encoding($struct->headers['content-description'],$this->default_charset)); return $struct; } diff -ruN rc-beta3/program/include/rcube_shared.inc rc-beta2/program/include/rcube_shared.inc --- rc-beta3/program/include/rcube_shared.inc 2008-06-06 10:20:39.416799300 +0200 +++ rc-beta2/program/include/rcube_shared.inc 2008-06-06 10:07:39.177963387 +0200 @@ -581,4 +581,33 @@ return $mime_type; } -?> \ Brak znaku nowej linii na koĹ�cu pliku + +/** + * A method to guess encoding of a string. + * + * @param string $string String. + * @param string $failover Default result for failover. + * + * @return string + */ +function rc_detect_encoding($string, $failover='') +{ + if (!function_exists('mb_detect_encoding')) { + return $failover; + } + + // FIXME: the order is important, because sometimes + // iso string is detected as euc-jp and etc. + $enc = array( + 'UTF-8', 'ISO-8859-1', 'ISO-8859-2', 'ISO-8859-3', 'ISO-8859-4', + 'ISO-8859-5', 'ISO-8859-6', 'ISO-8859-7', 'ISO-8859-8', 'ISO-8859-9', + 'ISO-8859-10', 'ISO-8859-13', 'ISO-8859-14', 'ISO-8859-15', 'ISO-8859-16', + 'WINDOWS-1252', 'WINDOWS-1251', 'EUC-JP', 'EUC-TW', 'KOI8-R' + ); + + $result = mb_detect_encoding($string, join(',', $enc)); + + return $result ? $result : $failover; +} + +?> -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Project Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

3 3

Enable config files download from installer
by Robin Elfrink 06 Jun '08

06 Jun '08

Hi all, Please test attached patch, which enables downloading of freshly created config files from the installer. Robin --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/35/rDnkUEMQ/config-download.2008.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 2

Fw: not able to read forwarded messages that are attachments
by Jason Levine 06 Jun '08

06 Jun '08

I narrowed the problem down a little further. I successfully was able to read an eml attachment that was sent from google webmail. but when I send from a standalone outlook express client the same attachment is not readable. Thanks, Jason Levine ----- Original Message ----- From: "Jason Levine" <jason(a)wiredhosting.com> To: "till" <klimpong(a)gmail.com> Cc: "RoundCube Dev" <dev(a)lists.roundcube.net> Sent: Thursday, May 08, 2008 7:05 AM Subject: Fw: [RCD] not able to read forwarded messages that are attachments >I don't seem to be making any headwinds into the mysterious eml files are >unreadable error. > Do you have any suggestions on where I might start looking. I keep > thinking it is a MIME error, but I don't see anything wrong. > > > Thanks, > Jason > _______________________________________________ List info: http://lists.roundcube.net/dev/

3 8

Updated Arabic Translation
by Ossama Khayat 05 Jun '08

05 Jun '08

Hi, Attached is the updated Arabic translation of both messages.inc and labels.inc in zip format. regards, Ossama Khayat --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/j4/v8IuP9MD/roundcube-ar.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

patch to autogenerate real user name
by Nik Soggia 03 Jun '08

03 Jun '08

Hello everybody, this is my first post in this list. As soon as I installed roundcubemail, I really appreciated the virtuser_file/virtuser_query config options to automatically fill-in the email address when auto_create_user is set to true, but I was a little disappointed to see that there is no way to automatically set the user's real name. Moreover silently setting the login name as the sender's real name reveals to mail recipients an information that should be usually kept secret. For these two reasons I wrote this very little patch to add some more automation. you can apply it to svn 1452 directly, with "patch -p1 <this_message" or you can apply it to release 0.1.1 tweaking a file name: "sed 's/rcube_user\.php/rcube_user.inc/g' <this_message | patch -p1" there are two new config entries, leaving both empty preserves the actual behavior. "passwd_query" works exactly as "virtuser_query", a example query may be: select real_name from some_table where login_name="%u" "passwd_file" will extract the "gecos" field from a passwd-like file, a example line may be: unixname:x:1000:100:John Doe:/usr/share/empty:/bin/false I hope that this very little unintrusive patch will be included in the next release :) diff -Naubr roundcubemail.old/config/main.inc.php.dist roundcubemail.new/config/main.inc.php.dist --- roundcubemail.old/config/main.inc.php.dist 2008-05-29 17:21:51.000000000 +0200 +++ roundcubemail.new/config/main.inc.php.dist 2008-05-29 17:19:21.000000000 +0200 @@ -61,6 +61,14 @@ // The query should select the user's e-mail address as first col $rcmail_config['virtuser_query'] = ''; +// Path to a passwd-like file to get real name from user name +$rcmail_config['passwd_file'] = ''; + +// Query to get real name from user name +// %u will be replaced with the current username for login. +// The query should select the user's real name as first col +$rcmail_config['passwd_query'] = ''; + // use this host for sending mails. // to use SSL connection, set ssl://smtp.host.com // if left blank, the PHP mail() function is used diff -Naubr roundcubemail.old/program/include/rcube_user.php roundcubemail.new/program/include/rcube_user.php --- roundcubemail.old/program/include/rcube_user.php 2008-05-29 17:21:54.000000000 +0200 +++ roundcubemail.new/program/include/rcube_user.php 2008-05-29 17:39:45.000000000 +0200 @@ -368,6 +368,25 @@ $user_email = strpos($user, '@') ? $user : sprintf('%s@%s', $user, $mail_domain); $user_name = $user != $user_email ? $user : ''; + if (!empty($CONFIG['passwd_file'])) { + if ($fp = fopen ($CONFIG['passwd_file'], 'r')) { + do { + $line = explode (':', fgets ($fp)); + if ((count ($line) >= 5) && ($line[0] == $user)) { + $user_name = $line[4]; + break; + } + } while (feof ($fp) == FALSE); + fclose ($fp); + } + } + if (!empty($CONFIG['passwd_query'])) { + if ($sql_result = $DB->query (preg_replace('/%u/', $DB->escapeSimple($user), $CONFIG['passwd_query']))) { + while ($sql_arr = $DB->fetch_array($sql_result)) { + $user_name = $sql_arr[0]; + } + } + } // try to resolve the e-mail address from the virtuser table if ($virtuser_query = $rcmail->config->get('virtuser_query') && _______________________________________________ List info: http://lists.roundcube.net/dev/

2 2

Updated Slovak translation
by Peter Mann 31 May '08

31 May '08

Heyaaa!!! here is updated Slovak translation -- 5o Peter.Mann at tuke.sk --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Um/DJfLVH5Z/labels.inc http://detached.gigo.com/rc/Um/DJfLVH5Z/messages.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

localization -> setlocale
by A.L.E.C 30 May '08

30 May '08

Currently I'm working on folders list sorting and see locale issue. In roundcube we've got setlocale(LC_ALL, 'xx') where 'xx' is a selected language. For Polish it's 'pl', but we need 'pl_PL.UTF-8' for proper sorting. I propose to add locale.inc file with that definition in localization folders or just add label 'localename' with specified value. Not sure what will be better. -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Project Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

5 8

interface package changes
by Horváth Balázs 30 May '08

30 May '08

HTML composer: Did you consider using Fckeditor? I checked the archives and I saw that there was a discussion about that in Oct 2005, and the conclusion was that the goal is to support plugging any editor with plugins API, what's being developped. What's the status of this? I used both TinyMCE and FCKeditor and I prefer FCK. JS interface: Did you consider using a JS framework? I've been working quite much with prototype and after that JQuery. My personal preference is JQuery, based on experiences. Rewriting would be a big job, but could be done continuously, during the process both packages would exist. There are some benefits, I think even the code would become smaller, and pre-created interface plugins could be used. (And the packed version is just 16k.) What do you think? balázs -- *Horváth Balázs* *Balázs Horváth* Fejlesztési vezető Development Manager WG Informatika Kft. WG Informatics Ltd. H-1123 Budapest, Alkotás utca 53. (MOM Park, "D torony" II.em) Mobil: +36/20-971-2904 E-mail: horvath.balazs(a)wgi.hu <mailto:horvath.balazs@wgi.hu> Web: http://wgi.hu <http://wgi.hu?adid=145> _______________________________________________ List info: http://lists.roundcube.net/dev/

3 2

Updated lithuanian translation
by Martynas Bendorius 28 May '08

28 May '08

labels.inc attached. --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/5X/zYuA4UmT/labels.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev