Dev

dev@lists.roundcube.net

4296 discussions

Re: [RCD] Is anyone using multiple domains on a single IMAP server
by Martin Kealey 18 Oct '07

18 Oct '07

On Wed, 17 Oct 2007 17:20:29 +0200, "Thomas Bruederli" <roundcube(a)gmail.com> wrote: > 2007/10/17, Martin Kealey <roundcube-maint(a)ihug.co.nz>: >> Our RoundCube service replaced 3 previous webmail systems where users >> just used a bald username to log in. > > In case your users access the webmail on different domains Unfortunately no. They all use the one webmail URL, even if the "login" page is in another domain. And the marketing department are seriously discouraging the users from even that, preferring them to use the "One True Brand". (But of course, making users to change their email address is to be avoided at all costs.) > I assume that your IMAP server does require a full e-mail address as > user name. In this case the login should always work with full > addresses. The 'username_domain' is only added if the user name does > not contain an @ sign. It adds its own idea of a default (which is reasonable, given that 90% are in one domain), but provision has to be made for the others. > You can also maintain a patch that can be applied on the latest > release instead of adding this to the trunk. True the edit has survived "svn update" since r804, but development will get messy if our patches for other bugs touch the same files. -Martin (PS: "us" and "our" in this case is me and a contractor I have working with me on RoundCube, paid for by my employer.) _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] Is anyone using multiple domains on a single IMAP server?
by Thomas Bruederli 17 Oct '07

17 Oct '07

2007/10/17, Martin Kealey <roundcube-maint(a)ihug.co.nz>: > > Our RoundCube service replaced 3 previous webmail systems where users just > used a bald username to log in. It's far simpler -- and less error prone -- > for us to have a drop-down, than to get our users to change how they log > in. (We have custom login pages for each domain, but in the event that the > user gets their password wrong, or their session times out, we need to have > the main login page work obviously.) In case your users access the webmail on different domains, you can set $rcmail_config['username_domain'] using a host-specific config file. In order to get this work, you have to enable $rcmail_config['include_host_config']. > > At some future stage we will figure out how to let them log in using their > actual email address, but in the meantime this is what we need; in the > interests of not forking the project for our internal use, we're opting to > make this functionality available in the core product, but disabled unless > you put the appropriate option in the main.conf.inc file. > I assume that your IMAP server does require a full e-mail address as user name. In this case the login should always work with full addresses. The 'username_domain' is only added if the user name does not contain an @ sign. You can also maintain a patch that can be applied on the latest release instead of adding this to the trunk. ~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

bug in rcmail_save_passwd()
by mk＠ambsoft.pl 17 Oct '07

17 Oct '07

Hi, Not sure if this is a known issue. I found my rc installation unable to change email accounts passwords in the db. A short digging revealed that the mysql query uses wrong variable. $newpasswd vs. $newpassword (line 44 and 48) Changing $newpasswd to $newpassword fixes the issue. This is version roundcubemail-0.1-rc1.1. Second issue is that there is polish translation missing for texts like 'change password' etc. I checked this via www interface and it says nothing is missing. Anyway I added them manually. BTW. Nice work. Thanks. _______________________________________________ List info: http://lists.roundcube.net/dev/

2 2

Is anyone using multiple domains on a single IMAP server?
by Martin Kealey 16 Oct '07

16 Oct '07

(Apart from us, of course.) We need a drop-down list to select a domain on the login page, but *not* to change the IMAP server. So this would be separate from the option to choose an IMAP server, and by implication, a domain associated with it. I have a patch to implement this, but it has no effect unless enabled in program/include/main.inc. I wondered if anyone else had implemented anything similar and would be willing to compare notes and/or swap patches. Otherwise does anyone object to this being included in trunk? -Martin _______________________________________________ List info: http://lists.roundcube.net/dev/

5 5

Temporary imap connection loss -> unable to login
by Harold Aling 16 Oct '07

16 Oct '07

Dear devs, When I stop my imap server (dovecot) and open something on Roundcube, I get a 'connection error' and I'm forwarded to the login screen. Obviously, login fails then... After restarting my imap server, login is still denied! I have to manually remove my session from the session table in mysql before I can log in again. Weird behaviour: * When imap is unavailable, RC just sais 'Login failed' upon login, instead of 'Connection to imap failed, contact your administrator ...' * After a lost connection to imap, RC just sais 'Login failed' upon login, instead of removing the bogus session and allowing me to login again * I have to manually remove the session from the session table to be able to login again. I'm using Roundcube from svn r870... -H- _______________________________________________ List info: http://lists.roundcube.net/dev/

3 2

Getting ready for 0.1-rc2
by Thomas Bruederli 14 Oct '07

14 Oct '07

Hi everybody I just moved most of the remaining tickets to 0.1-stable in order to get this release ready. Now I'd like to request the testers to test the current trunk on their environments, especially creating and updating the database. I can only test mysql and sqlite but there are others... Also all translators are requested to check for missing texts using our online tool: http://translator.roundcube.net/ Thanks so far! ~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/

5 6

Re: [RCD] "Always display images" option
by Ben 09 Oct '07

09 Oct '07

Thanks for your assistance, Harold and Fahrzin. I've developed the patch and have attached it to this message (let me know if there's someplace else I should send it instead). A few concerns: 1) The search() method in rcube_contacts.inc; I think while testing this patch, I think I found a glitch in it. If you have a contact in your address book and you delete it by mistake, then try to add the same contact again, it will see it as a duplicate and won't let you add it. This is because the search() method searches all contacts, even those with the `del` flag set. Should I try to fix this, or just file a bug report? Does anybody more familiar with the source know if it will break anything if I make it only search records not deleted? Or maybe when instructed to add a duplicate contact, Roundcube should simply turn off the 'del' flag if it's set? 2) I didn't know the best way to get the raw email address from the $MESSAGE headers, so I wrote a simple method that uses preg_match to extract it. If there's a better way, please let me know and I'll update my patch. 3) Caching causes a bit of a glitch in my patch. If you click a message with remote objects, click Always display, it will add the sender to the address book and display the images. If you go right back to the message however it will show the cached version so you have to Shift-Reload or it will appear it was unsuccessful. I'd be grateful if anybody knows a way around this. 4) As I'm monolinguistic, I've only added the message for it ($messages['alwaysshow']) to the en_US locale, so it won't display properly if your locale is different. Sorry. Let me know what you think. Thanks, Ben On Mon, 8 Oct 2007 23:12:20 +0200, Harold Aling <h.aling(a)home.nl> wrote: > > On Mon, 8 Oct 2007 15:57:12 -0400, Ben <ben(a)forlent.com> wrote: >> to start by writing a patch that allows you to "always display" images > in >> messages from specific senders, so you don't have to click "display >> images" >> each time you open their message. >> >> Being kind of new to this, my questions are as follows: >> >> 1) is anybody already working on this feature? > > Check the bug reports/feature requests on trac... > >> 2) If I do develop it, would it likely be added to the project? > > If it's well written, modulair and easy to implement: sure... > >> 3) How would I go about implementing it? Just download the SVN and patch >> it? Then do I send this list the patched files or just the snippets I >> modified or something else? > > I believe that's the best way to do it. It'll probably won't make it into > 1.0, so I'd guess writing it against SVN would give you the best base... > >> 4) From a technical standpoint, what would be the best way to store the >> whitelist of email senders? Flatfile, new database table, or in the >> address >> book? > > I'd go for the addressbook option. Email addresses which are stored in the > addressbook are in my case always trusted... > >> >> Thanks, >> Ben > > Good luck! > > > -H- --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/mW/maW5sP0T/display_images.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

"Always display images" option
by Ben 09 Oct '07

09 Oct '07

Hey everybody, I've been using Roundcube for a couple weeks now and am absolutely thrilled to have a real replacement for GMail. There are a couple features I'd like to see plus I've been meaning to get involved in FOSS development. I'd like to start by writing a patch that allows you to "always display" images in messages from specific senders, so you don't have to click "display images" each time you open their message. Being kind of new to this, my questions are as follows: 1) is anybody already working on this feature? 2) If I do develop it, would it likely be added to the project? 3) How would I go about implementing it? Just download the SVN and patch it? Then do I send this list the patched files or just the snippets I modified or something else? 4) From a technical standpoint, what would be the best way to store the whitelist of email senders? Flatfile, new database table, or in the address book? Thanks, Ben _______________________________________________ List info: http://lists.roundcube.net/dev/

3 2

Right-to-Left Layout
by Mohammad Ebrahim Mohammadi Panah 08 Oct '07

08 Oct '07

Hello, I got the latest code from Subversion and tested it to see how it looks in Persian. RoundCube seems to have no support for right-to-left languages such as Persian and Arabic. It didn't change the layout to right-to-left when I chose Persian or Arabic. Please correct me if I'm wrong. Is there any plan to implement it? -- Mohammad Ebrahim Mohammadi Panah _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Identities
by Brett Patterson 07 Oct '07

07 Oct '07

Got this in a private message on the forums. Thought I'd pass it along: You and the rest of the team are doing a great job. This might not be the right way to send this information but I have posted about this before with no results, so here it is for You and the rest of the team to do whatever You want with. My improvements to the identity section. The easy one is about the sort order in the indentity list. Code: /program/steps/settings/func.inc function rcmail_indentities_list..... // get contacts from DB ORDER BY standard DESC, name ASC, email ASC // this one is new.... The second one is a bit more. It improves the identity section in two ways. 1. You can NOT add an identity 'outside' your own domain. That is if You are logged in as 'mail(a)gunfro.com' You could only add identities to that domain. 2. You can NOT add an identity if it already exists in the domain. The domain You are logged into. I made this in one chunk so it easier to add. It might be better to put the code more where it belongs, hope You get my point. Code: /program/steps/settings/save_identities.php // check input if (empty($_POST['_name']) || empty($_POST['_email'])) { $OUTPUT->show_message('formincomplete', 'warning'); rcmail_overwrite_action('edit-identitiy'); return; } //********************************************************************* // MOD GUNFRO START $newa = explode("@", $_POST['_email']); $curr = explode("@", $_SESSION['username']); // Check valid domain. if ($newa[1] != $curr[1]) { $OUTPUT->show_message('domainnotvalid', 'warning'); rcmail_overwrite_action($_framed ? 'edit-identity' : 'identities'); return; } // Check if changing email and it exits. if ($_POST['_iid']) { $DB->query("SELECT * FROM ".get_table_name('identities')." WHERE identity_id=? AND del<>1", $_POST['_iid']); $curri = $DB->fetch_assoc(); if ($curri['email'] <> $_POST['_email']) { $DB->query("SELECT * FROM ".get_table_name('identities')." WHERE email=? AND del<>1", $_POST['_email']); if ($DB->fetch_assoc() != NULL) { $OUTPUT->show_message('emailexists', 'warning'); rcmail_overwrite_action($_framed ? 'edit-identity' : 'identities'); return; } } } else { // Just new a identity $DB->query("SELECT * FROM ".get_table_name('identities')." WHERE email=? AND del<>1", $_POST['_email']); if ($DB->fetch_assoc() != NULL) { $OUTPUT->show_message('emailexists', 'warning'); rcmail_overwrite_action($_framed ? 'edit-identity' : 'identities'); return; } } // MOD GUNFRO END //********************************************************************* // update an existing contact if ($_POST['_iid']) That was my contribution for now. Best regards Gunnar Frödin / GunFro -- ~ Brett Patterson _______________________________________________ List info: http://lists.roundcube.net/dev/

4 5

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev