Dev

dev@lists.roundcube.net

4296 discussions

[Fwd: [RCD] Attachment locking interface bug-patch (#1484496) I just submitted a bug to trac about downloading attachments that aren't of a correct mime type to spawn the window, ie the direct download, that causes the ui to lock up. (#1484496) Here is my patch to the solution from the latest svn checkout. It retains the original behavior of the redirect() function but adds in the lock that is sent to goto_url(). New to patches, so forgive if I did this improperly :) Patrick]
by Rich at Whidbey Telecom 10 Aug '07

10 Aug '07

Here's the patch that was submitted on July 31st and added to 667. :) -------- Original Message -------- Subject: [RCD] Attachment locking interface bug-patch (#1484496) I just submitted a bug to trac about downloading attachments that aren't of a correct mime type to spawn the window, ie the direct download, that causes the ui to lock up. (#1484496) Here is my patch to the solution from the latest svn checkout. It retains the original behavior of the redirect() function but adds in the lock that is sent to goto_url(). New to patches, so forgive if I did this improperly :) Patrick Date: Tue, 31 Jul 2007 15:30:12 -0600 From: Patrick Milvich <patrick(a)milvich.com> To: dev(a)lists.roundcube.net I just submitted a bug to trac about downloading attachments that aren't of a correct mime type to spawn the window, ie the direct download, that causes the ui to lock up. (#1484496) Here is my patch to the solution from the latest svn checkout. It retains the original behavior of the redirect() function but adds in the lock that is sent to goto_url(). New to patches, so please forgive if I did this improperly. Patrick Index: program/js/app.js =================================================================== --- program/js/app.js (revision 657) +++ program/js/app.js (working copy) @@ -694,7 +694,7 @@ } } - this.goto_url('get', qstring+'&_download=1'); + this.goto_url('get', qstring+'&_download=1', false); break; case 'select-all': @@ -3187,9 +3187,10 @@ /********* remote request methods *********/ /********************************************************/ - this.redirect = function(url) + this.redirect = function(url, lock) { - this.set_busy(true); + if (lock || lock == null) + this.set_busy(true); if (this.env.framed && window.parent) parent.location.href = url; else @@ -3198,11 +3199,8 @@ this.goto_url = function(action, query, lock) { - if (lock) - this.set_busy(true); - var querystring = query ? '&'+query : ''; - this.redirect(this.env.comm_path+'&_action='+action+querystring); + this.redirect(this.env.comm_path+'&_action='+action+querystring, lock); }; _______________________________________________ List info: http://lists.roundcube.net/dev/ -- Rich Sandberg richs(a)whidbey.net Whidbey Telecom Network Operations _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] Re: Problem when cancelling download of attachment RC1
by Rich at Whidbey Telecom 10 Aug '07

10 Aug '07

It looks like a patch was submitted for this by someone on July 31st. I'll see if I can apply it when I do some additional bug fixes today. Rich Jeff McClure wrote: > I can confirm as well. It doesn't always happen, but it also doesn't > require canceling the download to break it. This is with Firefox 2.0.0.6 on > Windows XP Pro SP2. RoundCube version is 0.1-rc1 running on Apache 2.2.3 > and PHP 4.4.4-8+etch4 under Debian stable. > > A possible clue: sometimes when I click on a download, a second tab > (window) that is obviously being generated by RoundCube pops up. When that > happens, I don't see the UI freeze. However, sometimes when I download, I > don't get that second window. In those cases it's more likely that the UI > will freeze up. > > --Jeff > > On Thu, 09 Aug 2007 12:44:30 -0700, Rich at Whidbey Telecom > <richs(a)whidbey.net> wrote: >> I can confirm this too. Sent myself a 9 MB zip, began the download of >> the attachment, and interface elements were unresponsive for several >> minutes. >> >> Feels like another set_busy not resetting. >> >> Rich >> >> Joan wrote: >>> After some more testing, I installed the last revision (666) to see if >>> the problem was still there. And yes, it's there ... >>> Whenever I download multiple attachments, roundcube stops responding >>> for a while after the first file is downloaded. >>> Same thing hapens when I cancell the download. >>> So It's a usual error, every time I receive a mail with attachments, >>> is the team aware of it? At this time this is the most annoying of the >>> bugs of roundcube (personal opinion, of course). >>> Cheers >>> >>> >>> 2007/8/8, Joan <aseques(a)gmail.com>: >>>> I already posted that to the forums, but didn't get any answer >>>> Whenever I cancel the download of an attachment (i.e. any .zip about >>>> 4Mb or larger), roundcube remains unresponsive for a while. >>>> It seems that is downloading it in background and until it finishes >>>> you have to wait, so for the 4Mb file I was testing i have to wait for >>>> about 30 seconds before I can continue working. >>>> Is it solved in the SVN? >>>> >>> _______________________________________________ >>> List info: http://lists.roundcube.net/dev/ >> -- >> >> Rich Sandberg >> richs(a)whidbey.net >> Whidbey Telecom Network Operations >> _______________________________________________ >> List info: http://lists.roundcube.net/dev/ -- Rich Sandberg richs(a)whidbey.net Whidbey Telecom Network Operations _______________________________________________ List info: http://lists.roundcube.net/dev/

4 6

Re: New translation - ukrainian
by Thomas Bruederli 10 Aug '07

10 Aug '07

Serhij S. Stasyuk wrote: > Hello all! > > Thanks a lot for the great product. > > Ukrainian translation attached. Thanks. I'll add it to the SVN trunk. > > One question - are there any plans to integrate some server-side > filtering (interface to procmail rules for example)? This is something very server specific and will not become part of RoundCube. You'll have to wait until we have a plugin-API... ~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: Localization for Simplified Chinese (zh_CN)
by Thomas Bruederli 10 Aug '07

10 Aug '07

Thanks! Will commit it to the SVN trunk. ~Thomas 薛忠胜 wrote: > Hi RoundCube crew: > > Attached please find the localization files for Simplified Chinese (zh_CN). > > If have any problem, don't hesitate contact me. > > Hunte > > > _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Problem when cancelling download of attachment RC1
by Joan 09 Aug '07

09 Aug '07

I already posted that to the forums, but didn't get any answer Whenever I cancel the download of an attachment (i.e. any .zip about 4Mb or larger), roundcube remains unresponsive for a while. It seems that is downloading it in background and until it finishes you have to wait, so for the 4Mb file I was testing i have to wait for about 30 seconds before I can continue working. Is it solved in the SVN? _______________________________________________ List info: http://lists.roundcube.net/dev/

4 4

roadmap dates? vNext?
by Mark D. Anderson 09 Aug '07

09 Aug '07

I know this is the kind of question people hate, but is there some sort of rough notion (say, to 6 month precision) of when the major releases might come out? And is "vNext" the same as 0.2 or 0.3? Looking at http://trac.roundcube.net/trac.cgi/roadmap the plugin API won't be til version 0.3. I ask because I'm contemplating using roundcube as the basis of a corporate messaging workflow app and would love it if my extensions could be implemented as plugins (for example, a plugin to generate and run forms to create documents to be emailed). I've looked at Zimbra and Joyent, and unfortunately they don't really have plugin support either; extensions require modification of numerous core files. -mda _______________________________________________ List info: http://lists.roundcube.net/dev/

5 4

New repository for nightly builds
by Thomas Bruederli 09 Aug '07

09 Aug '07

Hi everybody We kind of automated the publishing process of nightly builds and therefore removed them form the SourceForge downloads page. You can now find gzipped archives of SVN snapshots at http://nightly.roundcube.net Cheers! Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] [Patch] Problem emptying trash in non-english languages
by Joan 07 Aug '07

07 Aug '07

Yup, your're right, patch newie :P, that should be ok /skins/default/mail.css @@ -338,7 +338,7 @@ { position: absolute; left: 20px; - width: 160px; + width: 170px; bottom: 20px; height: 16px; overflow: hidden; Cheers PS: Raoul, sorry for the bunch of duplicate mails, forgot to change the reply 2007/8/7, Raoul Bhatia [IPAX] <r.bhatia(a)ipax.at>: > you should change the order of the argumens for diff as the patch below > would remove "width: 170px;" and add "width: 160px;". > > :) > > kind regards, > raoul bhatia > > Joan wrote: > > We are using Roundcube both in Catalan or spanish, due to larger > > words, "Compact empty" becomes "Compacta buida" and the second word > > cannot be readen using the default font sizes. > > Changing width to 170px in /skins/default/mail.css solves the problem > > > > > > @@ -338,7 +338,7 @@ > > { > > position: absolute; > > left: 20px; > > - width: 170px; > > + width: 160px; > > bottom: 20px; > > height: 16px; > > overflow: hidden; > > > > Cheers. > > _______________________________________________ > > List info: http://lists.roundcube.net/dev/ > > > -- > ____________________________________________________________________ > DI (FH) Raoul Bhatia M.Sc. E-Mail. r.bhatia(a)ipax.at > IPAX Web. http://www.ipax.at > Chief Technician, Support IRC. #ipax (quakenet) > ____________________________________________________________________ > _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

[Patch] Problem emptying trash in non-english languages
by Joan 07 Aug '07

07 Aug '07

We are using Roundcube both in Catalan or spanish, due to larger words, "Compact empty" becomes "Compacta buida" and the second word cannot be readen using the default font sizes. Changing width to 170px in /skins/default/mail.css solves the problem @@ -338,7 +338,7 @@ { position: absolute; left: 20px; - width: 170px; + width: 160px; bottom: 20px; height: 16px; overflow: hidden; Cheers. _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Javascript error when send message without body.
by Chen Lei 07 Aug '07

07 Aug '07

file: roundcubemail-0.1-rc1.1.tar /roundcubemail-0.1-rc1/program/js/app.js line 1683: if ((input_message.value=='')&&(tinyMCE.getContent()=='')) I don't have tinymce installed, the variable tinyMCE cause a javascript error when send message without body. Should it be if ((input_message.value=='')&&((!tinyMCE) true : tinyMCE.getContent()=='')) _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev