Dev

dev@lists.roundcube.net

4296 discussions

address book bug report
by David Koblas 10 Jun '07

10 Jun '07

Just upgraded (from the 0.1alpha) to the trunk version -- ok, it's been a while since I've had any time. Found the following bug, trying to add a second address to my address book, the address book contains an entry of: yyykoblas(a)example.com trying to add koblas(a)example.com Yeilds a 'contactexists' error, digging into it the problem it looks like: in steps/mail/addcontact.inc $existing = $CONTACTS->search('email', $contact['email'], false); does in include/rcube_contacts.inc $add_where[] = $this->db->quoteIdentifier($col)." LIKE ".$this->db->quote(strlen($value)>2 ? "%$value%" : "$ Of course koblas(a)example.com is a substring (but different address) of yyykoblas(a)extra.com. Not to mention that in this instance a case-insenstive search might be in order. I think it might be worthwhile to have a specific search for email address in the contacts -- possibly with a normalized column in the DB that facilitates it . --koblas

1 0

roundcube and quoting of username
by Nicolas Rachinsky 10 Jun '07

10 Jun '07

Hallo, program/include/main.inc, line 608: ($sql_result = $DB->query(preg_replace('/%u/', $user, $CONFIG['virtuser_query']))) && Shouldn't the username be quoted correctly before inserted into the database query? Nicolas

2 2

IMAP Subscribe
by till 08 Jun '07

08 Jun '07

Hi list, I implemented a new config setting (0, 1) on devel-vnext today, where the administrator of the RC install can select if always all mail folders should be displayed despite of SUBSCRIBE (2) status. The background is that we have a lot of users who use Apple Mail (exceptional many) and apparently Apple Mail does not know about SUBSCRIBE at all. So I implemented this switch since I "guess" users don't know what that is for anyway. Disclaimer: It's a "convenience feature" and not so good for performance. ;-) As in 1 - the diff is not so readable because I changed a lot of CS on rcube_imap.inc - but anyway, skip to the "green" portion in trac and go to 421-434 to see my changes. Feedback is very appreciated. If anyone needs help porting this to trunk, please let me know. Cheers, Till 0, http://trac.roundcube.net/trac.cgi/changeset/610/branches/devel-vnext/confi… 1, http://trac.roundcube.net/trac.cgi/changeset/610/branches/devel-vnext/progr… 2, http://tools.ietf.org/html/rfc3501#page-39

1 0

Weird Hanging problems (latest SVN)
by Ryan Rittenhouse 08 Jun '07

08 Jun '07

I've been having a weird issue with the SVN roundcube for a while. Sometimes a user logs in and then page just hangs. Can't click on anything: messages, folders, buttons, whatever. When this happens it is repeatable across different browsers and computers. It sometimes it seems to stop at a certain point (X number of messages down, cut off halfway across the page) and sometimes the page looks exactly right, but you can't do anything. Fixes have been largely inconsistent and range from changing the page size for the user (in the db since we can't do anything in browser) or moving mail out of their imap folder on the server, then moving it back. This has been very rare, probably rarer than 1 user in 20, but when it tends to happen to the same users again and again. Sometimes it'll go away after a day or so, then come back. I've tried copying user settings from working accounts and also tried comparing messages in affected accounts to find a pattern. So far, no dice. Anyone else having this problem or have a fix? -Ryan Rittenhouse -- Network Administrator Goshen College (574) 535-7004

3 5

Re: registry idea
by Brett Patterson 07 Jun '07

07 Jun '07

Chasd: I understand that line of thinking, but I wasn't saying that the command-line database is how it would be administered. I would suggest obviously a GUI interface with Roundcube (much like most forum software has). You can choose your method of editing, GUI or CLI. I was thinking that if we're going to be using a registry, why not switch the config file from being this PHP file, to a standard .ini file. Name it rcConfig.ini and then use PHPs ini parsing function (http://php.net/parse_ini_file) to get an array of options. That way, there's no need to know what an array is, or how to specify it. ~Brett chasd wrote: > > On Jun 6, 2007, at 2:07 PM, Brett Patterson wrote: > >> Hopefully this will aid in moving away from a config file, and more >> to holding config info in a database which would be easier for admins >> to modify. > > I don't think that opinion reflects what all admins want. I have seen > large flame wars on the Fedora devel list over integrating the Linux > registry project [1], which does what you are contemplating. > > I guess I am showing my age, but "vi > /var/www/roundcube/config/main.inc.php" is much quicker than > > psql roundcube > >\dt > <list of tables> > \d configtable > update configtable set foo = 'bar' where id = 'baz'; > > That is, the config file is rather self-documenting, a database table > will require some poking to figure out what needs to be changed where. > > Storing the config data in a database table is not a deal breaker for > me, but I personally don't consider it a positive step. > > [1] > <http://registry.sourceforge.net/> > > > Charles Dostale > System Admin - Silver Oaks Communications > http://www.silveroaks.com/ > 824 17th Street, Moline IL 61265 >

2 1

Mark as read and unread feature
by mat 07 Jun '07

07 Jun '07

Hello, I'm using Roundcube for more than one year, and I really enjoy using it. I recently added some features to my installation, so I made a patch. Maybe you could be interested in it. The patch answers to the #1457360 ticket [1]. Actually I posted some code in this ticket, but I think it is more comfortable for you in a patch, got from the last svn revision. I'm not an artist and I don't know how to make transparency with the gimp, so only "act" pictures are made, not "pas" and "sel". Cheers, Mat Links: ------ [1] http://trac.roundcube.net/trac.cgi/ticket/1457360

4 4

registry idea
by till 06 Jun '07

06 Jun '07

Hi, we've been toying with the idea to implement a registry to combat the "global" in RC. Here is the first draft/idea: http://trac.roundcube.net/trac.cgi/browser/branches/devel-vnext/program/inc… For right now the class is a bunch of static sets and gets to store and retrieve variables - optionally a namespace ($ns). In the first step it would be an "expensive" wrapper (Singleton) around $GLOBALS, until the entire code has been ported to use it. Further down the road, I think we should switch it to use sessions and then implement backends (e.g. database) to allow plugins to store their data or for example to make data persistent across logins, etc.. Thoughts anyone? Cheers, Till

3 3

bugs in rc1
by till 06 Jun '07

06 Jun '07

Hi, been playing with rc1 for about a week now, I noticed to bugs: 1) When I select a message in message view, and click reply/reply all, the subject and recipients are lost when the compose screen loaded. Message is there, also quoted etc.. 2) I don't seem to be able to send messages. 3) Randomly, my session is terminated (I get a login screen) and can not re-login until I close my browser and retry. I am investigating all issues, especially 2 - so if anyone is working on this as well, or maybe I seem to be the only one having those problems - please let me know. I am running my install with debug_level 8 and error_reporting(E_ALL) - which I hope catches everything. Just btw - so it doesn't look like I am ranting, cause I am not - outstanding work on the entire skinning feature of RC. It's really easy to customize the look. :) Cheers, Till

10 30

About Tags/Branches/Versions
by Raoul Bhatia [IPAX] 05 Jun '07

05 Jun '07

hello, as i am currently not happy with the rc1 in svn, i wonder which version should be used to stay close to the "next to be stable" version. trunk? branches/devel-vnext? please provide some information on the list and/or the wiki to clear things up :) kind regards, raoul bhatia -- ____________________________________________________________________ dipl.-ing. (fh) raoul bhatia email. r.bhatia(a)ipax.at IPAX web. http://www.ipax.at chief technician, support irc. #ipax (quakenet) ____________________________________________________________________

4 6

Changes in CS
by till 04 Jun '07

04 Jun '07

Hi lists, for those contributing patches, please review: http://trac.roundcube.net/trac.cgi/wiki/Dev_Guidelines (Hint: Code Style) Regards, Till

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev