Dev

dev@lists.roundcube.net

4296 discussions

Security: Why is user password stored in session?
by Stefan Rompf 05 Dec '06

05 Dec '06

Hi, I've just installed Roundcubemail on my server to replace another webmail package. First impression: Very nice work! However, I'm one of those who at least try to review the software they use, and there is one thing that really caught my eye: The user password is stored in the PHP session. I think authentication data should be end to end data, especially if you're running Roundcubemail over https as you should. The attached, slightly tested patch moves the password from the session into a browser cookie. Thoughts? Stefan

8 10

dragging messages while checking for new messages broken
by Jason 04 Dec '06

04 Dec '06

I was having this problem, then finially upgraded to revision 361, but I'm still seeing it. If I'm in my inbox, and I try to click and drag a message over to another folder it works normally, but not while the periodic "checking for new messages" message is at the top of the page. I searched the trac tickets and the mailing list and didn't find anything. Is anyone else having this problem? Is there a way to fix it?

1 1

conditional objects in templates
by Edgar Bueltemeyer 02 Dec '06

02 Dec '06

Hello, i would like to make following proposal to the conditional objects in templates: Its rather flexible and supports normal variables and Session-vars..... in the template file: <roundcube:button command="print" imageSel="/images/buttons/ print_sel.png" imageAct="/images/buttons/print_act.png" imagePas="/ images/buttons/print_pas.png" width="32" height="32" title="printmessage" condition="session:username:test"/> </div> in main.inc: function rcube_xml_command($command, $str_attrib, $add_attrib=array()) { global $IMAP, $CONFIG, $OUTPUT; $command = strtolower($command); $attrib = parse_attrib_string($str_attrib) + $add_attrib; //check if tag is conditional if($attrib['condition']) { $condition=explode(':',$attrib['condition']); $logmesg="condition:".$condition[0].'='.print_array($condition); //console($logmesg); if(strpos($condition[2],',')) $condition_array=explode(',', $condition[2]); else $condition_array=array(0=>$condition[2]); switch ($condition[0]) { case 'session': // if sesion var is not set -> switch off command if(!in_array($_SESSION[$condition[1]],$condition_array)) $command='none'; break; default: if(!$condition[0]==$condition[1])) $command='none'; // condition is not handled -> switch off command break; } } Regards!

3 5

A bug to report, and roundcubeforums down?
by Doug Mandell 02 Dec '06

02 Dec '06

Hi all, I wanted to log a bug on roundcubeforums.net but it looks like there's some sort of database error (it's been this way all day), so I'm going to report it here while I'm letting you know that that site's down. The bug: If I reply to an HTML email in plain text the quoted text doesn't get wrapped properly; occasionally a word will appear on a line by itself when there wasn't a line break. If I reply to an html email in HTML the text gets wrapped properly, and if I reply to a plain text email in plain text it works too. If necessary I can supply you with a snippet of text that causes the problem. I'm currently using revision 380, I'm pretty sure I noticed this in 361 also. If you need any more info from me please let me know, and if there's somewhere else I should be submitting bugs you can let me know that too. Thanks, Doug

3 2

Re: Conditional HTML and preview pane
by dmandell 29 Nov '06

29 Nov '06

I thought Robin and everybody else would like to know that I've been using the preview pane for the last few days in R380 in Firefox, and to a lesser extent IE7, with great results. Hopefully Robin will consider checking this code in so that it will get included with the next release. Thanks, Doug Mandell

2 1

(no subject)
by Kiril Dimeski 28 Nov '06

28 Nov '06

Hello, First > Sorry about my language, maybe I will make some mistakes in my e-mail. I'm web developer and I've heard about your webmail project, I've seen the screens and I've loved in it. But the main problem is, in your localisation packs there isn't Macedonian. I like to help you and change the language in Macedonian. Can you help me? Just send me the name of the software, with I can change the language. Thanks ----------------------------------- Kiril Dimeski Prilep WWW.SKORPION.ORG.MK WWW.TARATUR.COM WWW.FAUNA-SHOP.TK ------------------------------------

5 8

Time off by one hour
by Jason Dixon 27 Nov '06

27 Nov '06

RC is showing all messages with timestamps one hour fast. If I change my timezone to GMT -0600, it looks correct. I've tried turning the various main.inc.php knobs (timezone, dst_active), but they have no effect. I see this behavior on three different versions of RC, all on (mostly) different platforms: svn-373, OpenBSD 4.0 -stable svn-297, OpenBSD 3.7 svn-297, CentOS 3.8 It's entirely possible this is a sysadmin error, but I can't duplicate with Squirrelmail. Any ideas? Thanks, -- Jason Dixon DixonGroup Consulting http://www.dixongroup.net

2 3

Re: Delete open email button in svn 380
by Martin Marques 23 Nov '06

23 Nov '06

On Wed, 22 Nov 2006 08:17:45 -0600, Matt Kaatman <roundcube-dev(a)matt.kaatman.com> wrote: > Do we have any goals before we release the next beta? > > Maybe a feature freeze is in order to get a newer beta out? > > Grabbing the head from SVN will probably never be bug free but I know I > and many others are using it in a "production" environment which is > never a great idea. If you are doing it this way, probably the best > thing you can do is constantly grab the latest source. > > Robin and any other devs are impressively responsive to fixing problems > we find and discuss on here. > > Maybe we should make a list of features that need to be finished before > the next beta and once those are knocked out set a bug-scrub day or two > where everyone combs over everything to find any remaining issues. Like, when I click on an html link that's attached to my mail RC opens a new window with RC (the folder list). Very odd. Another one is that the behavior when deleting a mail in the message list changed again. Before, when you deleted a message, the next one got selected, which doesn't happen now. Trash and spam folders can't get emptied (empty botton is grey). Configuration (at least sone things) don't get applied. Example, changing the interval in which drafts get saved. It's always in a default of 5 minutes (could this be realted to DB changes I haven't applied yet?) -- --------------------------------------------------------- Lic. Martín Marqués | SELECT 'mmarques' || Centro de Telemática | '@' || 'unl.edu.ar'; Universidad Nacional | DBA, Programador, del Litoral | Administrador --------------------------------------------------------- -- --------------------------------------------------------- Lic. Martín Marqués | SELECT 'mmarques' || Centro de Telemática | '@' || 'unl.edu.ar'; Universidad Nacional | DBA, Programador, del Litoral | Administrador ---------------------------------------------------------

3 6

First & last buttons
by Robin Elfrink 22 Nov '06

22 Nov '06

Hi, I added first and last buttons to the main page, the single-email page and the address book. If it's OK I'll commit this. Robin Index: program/localization/en_US/labels.inc =================================================================== --- program/localization/en_US/labels.inc (revision 371) +++ program/localization/en_US/labels.inc (working copy) @@ -98,7 +98,9 @@ $labels['deletemessage'] = 'Move message to trash'; $labels['printmessage'] = 'Print this message'; $labels['previousmessages'] = 'Show previous set of messages'; +$labels['firstmessages'] = 'Show first set of messages'; $labels['nextmessages'] = 'Show next set of messages'; +$labels['lastmessages'] = 'Show last set of messages'; $labels['backtolist'] = 'Back to message list'; $labels['viewsource'] = 'Show source'; @@ -171,7 +173,9 @@ $labels['export'] = 'Export'; $labels['previouspage'] = 'Show previous set'; +$labels['firstpage'] = 'Show first set'; $labels['nextpage'] = 'Show next set'; +$labels['lastpage'] = 'Show last set'; // LDAP search Index: program/js/app.js =================================================================== --- program/js/app.js (revision 371) +++ program/js/app.js (working copy) @@ -141,9 +141,15 @@ { this.enable_command('show', 'reply', 'reply-all', 'forward', 'moveto', 'delete', 'viewsource', 'print', 'load-attachment', true); if (this.env.next_uid) + { this.enable_command('nextmessage', true); + this.enable_command('lastmessage', true); + } if (this.env.prev_uid) + { this.enable_command('previousmessage', true); + this.enable_command('firstmessage', true); + } } if (this.env.action=='show' && this.env.blockedobjects) @@ -478,10 +484,18 @@ this.list_page('next'); break; + case 'lastpage': + this.list_page('last'); + break; + case 'previouspage': this.list_page('prev'); break; + case 'firstpage': + this.list_page('first'); + break; + case 'expunge': if (this.env.messagecount) this.expunge_mailbox(this.env.mailbox); @@ -656,10 +670,20 @@ this.show_message(this.env.next_uid); break; + case 'lastmessage': + if (this.env.last_uid) + this.show_message(this.env.last_uid); + break; + case 'previousmessage': if (this.env.prev_uid) this.show_message(this.env.prev_uid); break; + + case 'firstmessage': + if (this.env.first_uid) + this.show_message(this.env.first_uid); + break; case 'checkmail': this.check_for_recent(); @@ -1095,8 +1119,12 @@ { if (page=='next') page = this.env.current_page+1; + if (page=='last') + page = this.env.pagecount; if (page=='prev' && this.env.current_page>1) page = this.env.current_page-1; + if (page=='first' && this.env.current_page>1) + page = 1; if (page > 0 && page <= this.env.pagecount) { @@ -2634,7 +2662,9 @@ this.set_page_buttons = function() { this.enable_command('nextpage', (this.env.pagecount > this.env.current_page)); + this.enable_command('lastpage', (this.env.pagecount > this.env.current_page)); this.enable_command('previouspage', (this.env.current_page > 1)); + this.enable_command('firstpage', (this.env.current_page > 1)); } Index: program/steps/mail/show.inc =================================================================== --- program/steps/mail/show.inc (revision 371) +++ program/steps/mail/show.inc (working copy) @@ -60,7 +60,7 @@ $javascript .= sprintf("%s.set_env('safemode', '%b');", $JS_OBJECT_NAME, $_GET['_safe']); $next = $prev = -1; - // get previous and next message UID + // get previous, first, next and last message UID if (!($_SESSION['sort_col'] == 'date' && $_SESSION['sort_order'] == 'DESC') && $IMAP->get_capability('sort')) { @@ -69,21 +69,29 @@ $MESSAGE['index'] = array_search((string)$MESSAGE['UID'], $a_msg_index, TRUE); $prev = isset($a_msg_index[$MESSAGE['index']-1]) ? $a_msg_index[$MESSAGE['index']-1] : -1 ; + $first = count($a_msg_index)>0 ? $a_msg_index[0] : -1; $next = isset($a_msg_index[$MESSAGE['index']+1]) ? $a_msg_index[$MESSAGE['index']+1] : -1 ; + $last = count($a_msg_index)>0 ? $a_msg_index[count($a_msg_index)-1] : -1; } else { // this assumes that we are sorted by date_DESC $seq = $IMAP->get_id($MESSAGE['UID']); $prev = $IMAP->get_uid($seq + 1); + $first = $IMAP->get_uid($IMAP->messagecount()); $next = $IMAP->get_uid($seq - 1); + $last = $IMAP->get_uid(1); $MESSAGE['index'] = $IMAP->messagecount() - $seq; } if ($prev > 0) $javascript .= sprintf("\n%s.set_env('prev_uid', '%s');", $JS_OBJECT_NAME, $prev); + if ($first >0) + $javascript .= sprintf("\n%s.set_env('first_uid', '%s');", $JS_OBJECT_NAME, $first); if ($next > 0) $javascript .= sprintf("\n%s.set_env('next_uid', '%s');", $JS_OBJECT_NAME, $next); + if ($last >0) + $javascript .= sprintf("\n%s.set_env('last_uid', '%s');", $JS_OBJECT_NAME, $last); $OUTPUT->add_script($javascript); } @@ -173,4 +181,4 @@ parse_template('printmessage'); else parse_template('message'); -?> \ No newline at end of file +?> Index: skins/default/templates/mail.html =================================================================== --- skins/default/templates/mail.html (revision 371) +++ skins/default/templates/mail.html (working copy) @@ -25,9 +25,11 @@ </div> <div id="messagecountbar"> +<roundcube:button command="firstpage" imageSel="/images/buttons/first_sel.png" imageAct="/images/buttons/first_act.png" imagePas="/images/buttons/first_pas.png" width="11" height="11" title="firstmessages" /> <roundcube:button command="previouspage" imageSel="/images/buttons/previous_sel.png" imageAct="/images/buttons/previous_act.png" imagePas="/images/buttons/previous_pas.png" width="11" height="11" title="previousmessages" />  <roundcube:object name="messageCountDisplay" />  <roundcube:button command="nextpage" imageSel="/images/buttons/next_sel.png" imageAct="/images/buttons/next_act.png" imagePas="/images/buttons/next_pas.png" width="11" height="11" title="nextmessages" /> +<roundcube:button command="lastpage" imageSel="/images/buttons/last_sel.png" imageAct="/images/buttons/last_act.png" imagePas="/images/buttons/last_pas.png" width="11" height="11" title="lastmessages" /> </div> <div id="mailboxlist-header"><roundcube:label name="mailboxlist" /></div> Index: skins/default/templates/message.html =================================================================== --- skins/default/templates/message.html (revision 371) +++ skins/default/templates/message.html (working copy) @@ -11,9 +11,11 @@ <roundcube:include file="/includes/header.html" /> <div id="messagecountbar"> +<roundcube:button command="firstmessage" imageSel="/images/buttons/first_sel.png" imageAct="/images/buttons/first_act.png" imagePas="/images/buttons/first_pas.png" width="11" height="11" title="firstmessages" /> <roundcube:button command="previousmessage" imageSel="/images/buttons/previous_sel.png" imageAct="/images/buttons/previous_act.png" imagePas="/images/buttons/previous_pas.png" width="11" height="11" title="previousmessages" />  <roundcube:object name="messageCountDisplay" />  <roundcube:button command="nextmessage" imageSel="/images/buttons/next_sel.png" imageAct="/images/buttons/next_act.png" imagePas="/images/buttons/next_pas.png" width="11" height="11" title="nextmessages" /> +<roundcube:button command="lastmessage" imageSel="/images/buttons/last_sel.png" imageAct="/images/buttons/last_act.png" imagePas="/images/buttons/last_pas.png" width="11" height="11" title="lastmessages" /> </div> <div id="messagetoolbar"> Index: skins/default/templates/addressbook.html =================================================================== --- skins/default/templates/addressbook.html (revision 371) +++ skins/default/templates/addressbook.html (working copy) @@ -20,9 +20,11 @@ </div> <div id="abookcountbar"> +<roundcube:button command="firstpage" imageSel="/images/buttons/first_sel.png" imageAct="/images/buttons/first_act.png" imagePas="/images/buttons/first_pas.png" width="11" height="11" title="firstpage" /> <roundcube:button command="previouspage" imageSel="/images/buttons/previous_sel.png" imageAct="/images/buttons/previous_act.png" imagePas="/images/buttons/previous_pas.png" width="11" height="11" title="previouspage" />  <roundcube:object name="recordsCountDisplay" />  <roundcube:button command="nextpage" imageSel="/images/buttons/next_sel.png" imageAct="/images/buttons/next_act.png" imagePas="/images/buttons/next_pas.png" width="11" height="11" title="nextpage" /> +<roundcube:button command="lastpage" imageSel="/images/buttons/last_sel.png" imageAct="/images/buttons/last_act.png" imagePas="/images/buttons/last_pas.png" width="11" height="11" title="lastpage" /> </div> <div id="addresslist">

2 1

Re: Delete open email button in svn 380
by Mark Bucciarelli 22 Nov '06

22 Nov '06

On Wed, Nov 22, 2006 at 08:17:45AM -0600, Matt Kaatman wrote: > Maybe we should make a list of features that need to be > finished before the next beta and once those are knocked out > set a bug-scrub day or two where everyone combs over everything > to find any remaining issues. There is still one issue open on the 0.1-beta2 milestone list (ticket #1349473). Not sure if this is still current, but I don't remember a more recent post on the same topic: Date: Fri, 14 Jul 2006 11:28:12 +0200 From: Thomas Bruederli <roundcube(a)gmail.com> Subject: Final round for 0.1beta2 Hi everybody I finally made it to go through the most tickets and assigned a set of bugs that IMO need to be fixed for the next milestone. There are now 16 pending tickets assigned to milestone 0.1beta2: http://trac.roundcube.net/trac.cgi/query?status=new&status=assigned&status=… It looks like I will have some time again to work on the project for the next couple of weeks. Let's try to get rid of those 16 tix and we're ready to publish a new release. This will also be the first release that is "planned" with the Trac system and a proof of success of that platform. Please catch yourself some unassigned tickets and help finish this milestone. Thanks! Thomas m

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev