Dev

dev@lists.roundcube.net

4296 discussions

Openning Attachments problem
by Chris Richardson 09 Nov '06

09 Nov '06

Hi guys i have been noticing a big issue with my install here i am using the current trunk. when one of my users get an attachment espicaly something like a pdf and they try to open it it causes a new window to load of there inbox. it they open in a new window the knows there is a known attachment but when it goes to open it says that the path can not be found. it does work if you right click and do save as. this is all through IE 6 and up. any help would be appreciated -Chris The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited. If you received this in error, please contact the sender and delete this material from any computer. In accordance with industry regulations, all messages are retained and are subject to monitoring. This message has been scanned for viruses and dangerous content and is believed to be clean. Securities offered through Cantella & Co., Inc., Member NASD/SIPC. Home Office: 2 Oliver Street, 11th Floor, Boston, MA 02109 Telephone: (617)521-8630

3 3

STARTTLS Service Extension
by tintax＠tintax.net 09 Nov '06

09 Nov '06

All, To scratch an itch, I\'ve written some code against the SVN codebase (rev 362) to connect to SMTP servers that use STARTTLS. This ought to resolve ticket #1483813 (or at least it does for me). Briefly, I\'ve: Added main.inc.php::$rcmail_config[\'smtp_starttls\'] to control use of STARTTLS Modified rcube_smtp.inc::smtp_mail() to check configuration variable and try STARTTLS if set Modified Net_SMTP::Net_SMTP() to accept an optional param indicating if STARTTLS should be used. Modified Net_SMTP::connect() to establish and negotiate TLS session if using STARTTLS. Added Net_SMTP::_starttls() to attempt TLS handshake and establish secure connection. Added Net_Socket::enableCrypto() to turn encryption on/off on the socket. Caveats: This relies on functionality only available in PHP 5.1.0rc1 (with OpenSSL support) and higher. The code checks for a suitable environment but I appreciate that this is higher than the minimum PHP requirements listed on your wiki. It\'s been a little while (about two years) since I last wrote any php code so it isn\'t as polished as I\'d like. If a developer is interested in the code, please let me know how to get it to you. Oh, and thanks for such great software. It says a lot that it was worth my while to roll up my sleeves and add support for a personal show stopper rather than switch to a different webmail client! Regards, Matt

1 0

Patch fixing newline-in-From:-bug
by Øystein Steimler 07 Nov '06

07 Nov '06

Hi! I'm not subscribed to the list, so I can't read replies without a cc: Also, please accept my apologies if this issue has already been discussed. After checking out rc to a new site from svn some days ago (rev 631), I found an odd bug in the mail-header-list. Some of my contacts send mails containing an newline or carriage return in the From: header, thus breaking the _parse_address_list() in rcube_imap.inc. I'm not quite sure exactly which method is failing, but the result is that quotes are not removed, and the newline is converted to a html break inside the html anchor's href attribute, thus breaking the HTML validity. I'm not sure if this newline is allowed in the From: header according to the RFCs, but it appeared. Anyway: adding this single line patch to rcube_imap the problem disappeared from my installation. Hopefully someone can use this knowledge to make RoundCube even better! Thanks! .øs Index: roundcubemail/program/include/rcube_imap.inc =================================================================== --- roundcubemail/program/include/rcube_imap.inc (revision 361) +++ roundcubemail/program/include/rcube_imap.inc (working copy) @@ -2377,6 +2377,10 @@ function _parse_address_list($str) { + + // Remove any newlines and carriage returns from address list + $str = preg_replace( "/[\r\n]/", " ", $str ); + $a = $this->_explode_quoted_string(',', $str); $result = array(); -- Øystein Steimler - EasyConnect AS - Opplysning1890 oystein.steimler(a)easyconnect.no - GPG: 0x784a7dea

2 1

Just Praise
by Shem Valentine 29 Oct '06

29 Oct '06

Hello devs, I just wanted to say how great I think this project is. It's a breath of fresh air in the world of open source webmail clients. I love how clean and intuitive the interface is. So simple that even my technologically impaired family can use it. It was a snap to install (the sendmail AUTH feature was the hardest part about it, but still fairly simple). Thanks for a wonderful web 2.0 app! -Shem Valentine

1 0

Roundcube Date Handling Error
by Rob Smith 28 Oct '06

28 Oct '06

I was showing a friend roundcube and discovered an interested error. He had received some quota warnings in the past, but when he logged into roundcube, they were all at the top of his email list. I'm assuming the email doesn't comply to some date specification, but other email programs are handling it correctly, so we might want to include it. The email headers are at the bottom of this email. They are so short because this email isn't actually sent, but it is inserted in the users mailbox directly when they are over quota. Rob -------- Original Message -------- Subject: Quota warning Date: Mon Aug 7 05:00:00 CDT 2006 From: root(a)ruf.rice.edu To: cwshep(a)ruf.rice.edu

1 0

A test framework for Webmail systems
by Rajesh Dorairajan 27 Oct '06

27 Oct '06

Greetings Roundcube devs, I'm doing a Master's project with three team-mates in San Jose State University, California and we're trying to develop an "Integrated Test framework" for Webmail systems. We're trying to achieve a generic web-based framework (using LAMP architecture) that will act as a single source of validation for a Webmail system such as Roundcube including the IMAP/POP3 server, SMTP server, LDAP/Database, and the front-end PHP layer. I wanted to see if you could share your thoughts on this issue. Being developers of the roundcube project you must've undergone some painful experience devising a test setup for your system. Do you think you could help us a little bit by telling us some of the difficulties that we might atrempt to solve by developing such as a framework? Any feedback would be deeply appreciated. Thank you very much for your time. Rajesh Dorairajan E-Mail:- rajeshd(a)tekzon.com http://tekzon.blogspot.com

3 2

Delete/move bug fixed
by NetOne - Doichin Dokov 25 Oct '06

25 Oct '06

Hi guys, I belive i've fixed bug #1484044 <http://trac.roundcube.net/trac.cgi/ticket/1484044>, please review it and and to SVN if the fix is OK. Regards, Doichin

5 7

Patch for having transparent server selection for multiple domains
by Clément Moulin 25 Oct '06

25 Oct '06

Hi I've already proposed this patch (in April), but you'd asked me to update it for current release. http://209.85.129.104/search?q=cache:HCto6VkAqNIJ:www.roundcubeforum.net/ind ex.php%3Ftopic%3D122.msg2162+round+cube+simplerezo&hl=fr&gl=fr&ct=clnk&cd=1 So here the patch for the current SVN version: --- index.php.old Tue Oct 17 17:18:46 2006 +++ index.php Tue Oct 17 17:19:28 2006 @@ -166,6 +166,23 @@ if ($_action=='login' && $_task=='mail') { $host = $_POST['_host'] ? $_POST['_host'] : $CONFIG['default_host']; + + // auto host + if (is_array($host) && is_array(reset($host))) + { + if (isset($_POST['_user'])) + { + $tmp = split('@', $_POST['_user']); + if (sizeof($tmp) > 1) + foreach ($host as $cur_host => $domains) + if (in_array($tmp[1], $domains)) + { + $host_ok = $cur_host; + break;; + } + $host = isset($host_ok) ? $host_ok : ''; + } + } // check if client supports cookies if (empty($_COOKIE)) --- config/main.inc.php.dist.old Tue Oct 17 17:20:09 2006 +++ config/main.inc.php.dist Tue Oct 17 17:21:39 2006 @@ -35,6 +35,12 @@ // leave blank to show a textbox at login, give a list of hosts // to display a pulldown menu or set one host as string. // To use SSL connection, enter ssl://hostname:993 +// auto-selection of host depending on domain specified can +// be enabled using a value like this: +// $rcmail_config['default_host'] = array( +// 'mail.server.com' = array('domaine1.com', 'domaine2.net'), +// 'mail.server2.com' = array('my.otherdomain.net'), +// 'host.hosting.com' = array('a.net', 'b.org', 'c.com')); $rcmail_config['default_host'] = ''; // TCP port used for IMAP connections --- program/include/main.inc.old Tue Oct 17 17:22:14 2006 +++ program/include/main.inc Tue Oct 17 17:23:10 2006 @@ -1717,10 +1717,13 @@ { $select_host = new select(array('name' => '_host', 'id' => 'rcmloginhost')); - foreach ($CONFIG['default_host'] as $key => $value) - $select_host->add($value, (is_numeric($key) ? $value : $key)); + if (!(is_array($CONFIG['default_host']) && is_array(reset($CONFIG['default_host'])))) + { + foreach ($CONFIG['default_host'] as $key => $value) + $select_host->add($value, (is_numeric($key) ? $value : $key)); - $fields['host'] = $select_host->show($_POST['_host']); + $fields['host'] = $select_host->show($_POST['_host']); + } } else if (!strlen($CONFIG['default_host'])) { I quote myself: [ Note: you can use in main.inc.php something like: $rcmail_config['default_host'] = include('mystuff.inc.php'); And in mystuff.inc.php doing whatever you like for building and returning the associative arrays (retrieving informations from a database for an example, like we do). Just be aware that this file is called for every HTTP request (so if you are using database as I said, it could have some performance issues....). ] I hope this will be committed soon. -- Clement Moulin SimpleRezo

2 1

Preview pane for SVN 361
by Robin Elfrink 24 Oct '06

24 Oct '06

Hi, I managed to spend some time on my preview pane, to make it work in the current SVN revision 361. Two options were added to config/main.inc.php: // Enable preview pane $rcmail_config['enable_preview'] = FALSE; // display preview pane if enabled $rcmail_config['preview'] = FALSE; Some issues that I have: - Attachment filenames are gone, even though the preview pane displays them correctly. - There should be a 'view source' button if a message is previewed. Robin Index: config/main.inc.php.dist =================================================================== --- config/main.inc.php.dist (revision 361) +++ config/main.inc.php.dist (working copy) @@ -171,6 +171,9 @@ // Leave empty for default set of Google spell check languages $rcmail_config['spellcheck_languages'] = NULL; +// Enable preview pane +$rcmail_config['enable_preview'] = FALSE; + // path to a text file which will be added to each sent message // paths are relative to the RoundCube root folder $rcmail_config['generic_message_footer'] = ''; @@ -216,6 +219,9 @@ // prefer displaying HTML messages $rcmail_config['prefer_html'] = TRUE; +// display preview pane if enabled +$rcmail_config['preview'] = FALSE; + // show pretty dates as standard $rcmail_config['prettydate'] = TRUE; Index: program/include/main.inc =================================================================== --- program/include/main.inc (revision 361) +++ program/include/main.inc (working copy) @@ -1200,6 +1200,7 @@ 'editorselector' => 'rcmail_editor_selector', 'searchform' => 'rcmail_search_form', 'receiptcheckbox' => 'rcmail_receipt_checkbox', + 'preview' => 'rcmail_message_preview', // ADDRESS BOOK 'addresslist' => 'rcmail_contacts_list', Index: program/localization/nl_NL/labels.inc =================================================================== --- program/localization/nl_NL/labels.inc (revision 361) +++ program/localization/nl_NL/labels.inc (working copy) @@ -202,6 +202,7 @@ $labels['pagesize'] = 'Rijen per pagina'; $labels['signature'] = 'Onderschrift'; $labels['dstactive'] = 'Zomertijd'; +$labels['preview'] = 'Voorbeeldvenster'; $labels['folder'] = 'Map'; $labels['folders'] = 'Mappen'; Index: program/localization/en_US/labels.inc =================================================================== --- program/localization/en_US/labels.inc (revision 361) +++ program/localization/en_US/labels.inc (working copy) @@ -207,6 +207,7 @@ $labels['dstactive'] = 'Daylight savings'; $labels['htmleditor'] = 'Compose HTML messages'; $labels['htmlsignature'] = 'HTML signature'; +$labels['preview'] = 'Preview message'; $labels['autosavedraft'] = 'Automatically save draft'; $labels['everynminutes'] = 'every $n minutes'; Index: program/js/app.js =================================================================== --- program/js/app.js (revision 361) +++ program/js/app.js (working copy) @@ -135,7 +135,7 @@ } // enable mail commands - this.enable_command('list', 'checkmail', 'compose', 'add-contact', 'search', 'reset-search', true); + this.enable_command('list', 'checkmail', 'compose', 'add-contact', 'search', 'reset-search', 'load-attachment', true); if (this.env.action=='show') { @@ -552,6 +552,7 @@ var input_pagesize = rcube_find_object('_pagesize'); var input_name = rcube_find_object('_name'); var input_email = rcube_find_object('_email'); + var input_preview = rcube_find_object('_preview'); // user prefs if (input_pagesize && isNaN(input_pagesize.value)) @@ -1039,6 +1040,8 @@ this.enable_command('show', 'reply', 'reply-all', 'forward', 'print', selected); this.enable_command('delete', 'moveto', list.selection.length>0 ? true : false); } + if (selected && this.env.enable_preview && this.env.preview) + this.show_preview(list.selection[0]); }; @@ -1067,6 +1070,30 @@ /*********************************************************/ + this.show_preview = function(id, safe) + { + var add_url = ''; + var target = window; + var contentframe = rcube_find_object('mailcontframe'); + var previewpane = rcube_find_object('previewpane'); + + if (id && contentframe && previewpane) + { + rcmail.set_busy(true, 'loading'); + if (previewpane.style.display=='none') + { + contentframe.style.height = (contentframe.offsetHeight/2) + 'px'; + previewpane.style.top = (contentframe.offsetTop+contentframe.offsetHeight) + 'px'; + previewpane.style.display = 'block'; + var message = rcube_find_object('rcmrow' + id); + message.scrollIntoView(); + } + var url = '_action=preview&_uid='+id; + rcmail.http_request('preview', url, true); + } + }; + + // when user doble-clicks on a row this.show_message = function(id, safe) { @@ -3115,6 +3142,12 @@ case 'expunge': this.enable_command('select-all', 'select-none', 'expunge', this.env.messagecount ? true : false); break; + + case 'preview': + var previewpane = rcube_find_object('previewpane'); + previewpane.innerHTML = request_obj.get_text(); + previewpane.scrollTop = 0; + break; } request_obj.reset(); Index: program/steps/settings/func.inc =================================================================== --- program/steps/settings/func.inc (revision 361) +++ program/steps/settings/func.inc (working copy) @@ -155,6 +155,17 @@ rep_specialchars_output(rcube_label('htmleditor')), $input_htmleditor->show($CONFIG['htmleditor']?1:0)); + // Show option for preview pane + if ($CONFIG['enable_preview']) + { + $field_id = 'rcmfd_preview'; + $input_preview = new checkbox(array('name' => '_preview', 'id' => $field_id, 'value' => 1)); + $out .= sprintf("<tr><td class=\"title\"><label for=\"%s\">%s</label></td><td>%s</td></tr>\n", + $field_id, + rep_specialchars_output(rcube_label('preview')), + $input_preview->show($CONFIG['preview']?1:0)); + } + if (!empty($CONFIG['drafts_mbox'])) { $field_id = 'rcmfd_autosave'; @@ -242,4 +253,4 @@ } -?> \ No newline at end of file +?> Index: program/steps/settings/save_prefs.inc =================================================================== --- program/steps/settings/save_prefs.inc (revision 361) +++ program/steps/settings/save_prefs.inc (working copy) @@ -29,8 +29,11 @@ $a_user_prefs['pagesize'] = is_numeric($_POST['_pagesize']) ? (int)$_POST['_pagesize'] : $CONFIG['pagesize']; $a_user_prefs['prefer_html'] = isset($_POST['_prefer_html']) ? TRUE : FALSE; $a_user_prefs['htmleditor'] = isset($_POST['_htmleditor']) ? TRUE : FALSE; +if ($CONFIG['enable_preview']) + $a_user_prefs['preview'] = isset($_POST['_preview']) ? TRUE : FALSE; $a_user_prefs['draft_autosave'] = isset($_POST['_draft_autosave']) ? intval($_POST['_draft_autosave']) : 0; + // MM: Date format toggle (Pretty / Standard) $a_user_prefs['prettydate'] = isset($_POST['_pretty_date']) ? TRUE : FALSE; Index: program/steps/mail/show.inc =================================================================== --- program/steps/mail/show.inc (revision 361) +++ program/steps/mail/show.inc (working copy) @@ -171,6 +171,8 @@ if ($_action=='print') parse_template('printmessage'); +else if ($_action=='preview') + parse_template('previewmessage'); else parse_template('message'); -?> \ No newline at end of file +?> Index: program/steps/mail/func.inc =================================================================== --- program/steps/mail/func.inc (revision 361) +++ program/steps/mail/func.inc (working copy) @@ -480,6 +480,8 @@ $javascript .= sprintf("%s.set_env('pagecount', %d);\n", $JS_OBJECT_NAME, ceil($message_count/$IMAP->page_size)); $javascript .= sprintf("%s.set_env('sort_col', '%s');\n", $JS_OBJECT_NAME, $sort_col); $javascript .= sprintf("%s.set_env('sort_order', '%s');\n", $JS_OBJECT_NAME, $sort_order); + if ($CONFIG['enable_preview']) + $javascript .= sprintf("%s.set_env('preview', '%s');\n", $JS_OBJECT_NAME, $CONFIG['preview']); if ($attrib['messageicon']) $javascript .= sprintf("%s.set_env('messageicon', '%s%s');\n", $JS_OBJECT_NAME, $skin_path, $attrib['messageicon']); Index: skins/default/templates/mail.html =================================================================== --- skins/default/templates/mail.html (revision 361) +++ skins/default/templates/mail.html (working copy) @@ -52,6 +52,8 @@ attachmentIcon="/images/icons/attachment.png" /> </div> +<div id="previewpane" style="display: none;"></div> + <div id="listcontrols"> <roundcube:label name="select" />:  <roundcube:button command="select-all" label="all" classAct="active" />  Index: skins/default/mail.css =================================================================== --- skins/default/mail.css (revision 361) +++ skins/default/mail.css (working copy) @@ -120,7 +120,30 @@ height: expression((parseInt(document.documentElement.clientHeight)-125)+'px'); } +#previewpane +{ + position: absolute; + display: none; + top: 85px; + left: 200px; + right: 40px; + bottom: 40px; + border: 1px solid #999999; + border-top: none; + background-color: #F9F9F9; + overflow: auto; + /* css hack for IE */ + width: expression((parseInt(document.documentElement.clientWidth)-240)+'px'); + height: expression(( + parseInt(document.documentElement.clientHeight) - + parseInt(document.getElementById('mailcontframe').clientHeight) - 125)+'px'); +} +body > div#previewpane +{ + height: auto; +} + #messagepartframe { border: 1px solid #999999; Index: index.php =================================================================== --- index.php (revision 361) +++ index.php (working copy) @@ -262,7 +262,7 @@ { include_once('program/steps/mail/func.inc'); - if ($_action=='show' || $_action=='print') + if ($_action=='show' || $_action=='print' || $_action=='preview') include('program/steps/mail/show.inc'); if ($_action=='get')

2 1

Bug report: invalid header modification
by Morten Mertner 23 Oct '06

23 Oct '06

Hi All, I'm seeing errors like this in my error_log: .. PHP Warning: Cannot modify header information - headers already sent in Unknown on line 0 .. PHP Stack trace: .. PHP 1. {main}() /var/www/localhost/htdocs/roundcube-svn/index.php:0 .. PHP 2. include() /var/www/localhost/htdocs/roundcube-svn/index.php:299 I hope this is useful - and do let me know if I should rather post this somewhere else. Yours, Morten

5 5

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev