Dev November 2006

dev@lists.roundcube.net

48 participants
44 discussions

Start a nNew thread

dev+unsubscribe@lists.roundcube.net
by Jurgen Koster 18 Nov '06

18 Nov '06

unsubscribe

1 0

need help to getting started
by Sebastian Heyden 17 Nov '06

17 Nov '06

hello, i try to write a plugin for roundcube so that the users of or mail-service can alter the settings of theire account out of roundcube. so im in search for a plugin-interface or the framework that was used to write roundcube. can you point me the direction? greetz, sebastian

1 0

Purge Junk folder
by Robin Elfrink 17 Nov '06

17 Nov '06

Enable the 'purge' command on the Junk folder. Applying this patch results in a interface change to the user (though it's a very very small change) so I would like feedback on this first. Robin Index: program/js/app.js =================================================================== --- program/js/app.js (revision 371) +++ program/js/app.js (working copy) @@ -3118,7 +3118,7 @@ case 'list': if (this.env.messagecount) - this.enable_command('purge', (this.env.mailbox==this.env.trash_mailbox)); + this.enable_command('purge', (this.env.mailbox==this.env.trash_mailbox || this.env.mailbox==this.env.junk_mailbox)); case 'expunge': this.enable_command('select-all', 'select-none', 'expunge', this.env.messagecount ? true : false);

2 2

Bug #1484109
by Robin Elfrink 16 Nov '06

16 Nov '06

Hi, Bug #1484109 has been added tonight, mentioning a cross site security vulnerability. The poster refers to http://www.securityfocus.com/bid/21042/info. Apart from the fact that I cannot reproduce the given proof-of- concept, I fail to see how this is supposed to be a vulnerability. Robin

2 1

Conditional objects in templates
by Robin Elfrink 16 Nov '06

16 Nov '06

Hi, I have a first rough implementation of conditional objects in templates. An object in a template file can have an extra attribute called 'conditional', which holds a condition like 'varname==value'. '==' can be '!=', or '<=' or any other expression. 'varname' is any $CONFIG variable. In the example the messagelist is only shown if the mailbox-name is 'INBOX'. Am I going in the right direction? Robin Index: program/include/main.inc =================================================================== --- program/include/main.inc (revision 369) +++ program/include/main.inc (working copy) @@ -1225,7 +1225,18 @@ // execute object handler function if ($object_handlers[$object] && function_exists($object_handlers[$object])) - return call_user_func($object_handlers[$object], $attrib); + { + if (isset($attrib['conditional']) && + preg_match('/^([a-z0-9_]+)([=<>!]+)([a-z0-9_]+)$/', $attrib['conditional'], $condition)) + { + if (eval("return $" . $condition[1] . $condition[2] . "'" . $condition[3] . "'")) + return call_user_func($object_handlers[$object], $attrib); + else + return ''; + } + else + return call_user_func($object_handlers[$object], $attrib); + } else if ($object=='productname') { Index: skins/default/templates/mail.html =================================================================== --- skins/default/templates/mail.html (revision 369) +++ skins/default/templates/mail.html (working copy) @@ -45,6 +45,7 @@ id="messagelist" cellspacing="0" summary="Message list" + conditional="mailbox==INBOX" messageIcon="/images/icons/dot.png" unreadIcon="/images/icons/unread.png" deletedIcon="/images/icons/deleted.png"

1 1

shift-delete: Delete immediately
by Robin Elfrink 16 Nov '06

16 Nov '06

Hi, I made a small patch that implements 'shift-delete': Delete messages immediately without moving them to the Trash folder. This helps people who are over quota and therefore cannot copy any messages to the Trash folder. The key_press method of rcube_list_widget simply sets the shiftkey property whenever a key is pressed. It works only with the shift key and the del key, not with the delete button. I haven't looked at that yet, don't even know if it's possible because my browser seems to handle shift-click it's own way. Please comment. Robin

4 5

LDAP authentication
by Pierre Mauduit 15 Nov '06

15 Nov '06

Hello, since my patch about the LDAP JpegPhoto support, someone contacted me off-list, because he needed LDAP authentication. It seems that it was hardly implemented into the file "rcube_ldap.inc", but the member function bind() is never called. So I merged the member functions connect() and bind(). Here is my diff between svn ver. 367 and my working copy : http://pedrov.kwain.net/~pedrov/rcube/rcube_367_wkcpy.diff I'm interested in developing some LDAP aspects in roundcube, but did not get any feedback, so if you think it is useful (or useless, or whatever), let me know ;-) See you, -- Pierre Mauduit

2 2

Attachments of pdfs
by Chris Richardson 15 Nov '06

15 Nov '06

Hey guys i wrote a little while back about this and I was wondering if anyone had any ideas on this we are working on it but haven't found a decent solution. Has anyone else ran into this and found a solution? problem is when there is an attachment of a pdf when you click on the link next to the paper clip it opens a new window but it si the content of your inbox and only way you can open it is by right clicking and saving target as. our env is php5, roundcube svn 367and IE 6 thanks guys The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited. If you received this in error, please contact the sender and delete this material from any computer. In accordance with industry regulations, all messages are retained and are subject to monitoring. This message has been scanned for viruses and dangerous content and is believed to be clean. Securities offered through Cantella & Co., Inc., Member NASD/SIPC. Home Office: 2 Oliver Street, 11th Floor, Boston, MA 02109 Telephone: (617)521-8630

3 2

shift-del
by Robin Elfrink 15 Nov '06

15 Nov '06

Darn, I left a 'shiftKey' which should've been a 'shiftkey' (lower case k). Sorry again. Robin Index: program/localization/en_US/messages.inc =================================================================== --- program/localization/en_US/messages.inc (revision 368) +++ program/localization/en_US/messages.inc (working copy) @@ -68,6 +68,8 @@ $messages['deletecontactconfirm'] = 'Do you really want to delete the selected contact(s)?'; +$messages['deletemessagesconfirm'] = 'Do you really want to delete the selected message(s)?'; + $messages['deletefolderconfirm'] = 'Do you really want to delete this folder?'; $messages['purgefolderconfirm'] = 'Do you really want to delete all messages in this folder?'; Index: program/js/list.js =================================================================== --- program/js/list.js (revision 368) +++ program/js/list.js (working copy) @@ -32,6 +32,8 @@ this.rows = []; this.selection = []; + this.shiftkey = false; + this.multiselect = false; this.draggable = false; this.keyboard = false; @@ -504,6 +506,8 @@ if (this.focused != true) return true; + this.shiftkey = e.shiftKey; + var keyCode = document.layers ? e.which : document.all ? event.keyCode : document.getElementById ? e.keyCode : 0; var mod_key = rcube_event.get_modifier(e); switch (keyCode) Index: program/js/app.js =================================================================== --- program/js/app.js (revision 368) +++ program/js/app.js (working copy) @@ -1314,7 +1314,14 @@ // if there is a trash mailbox defined and we're not currently in it: if (this.env.trash_mailbox && String(this.env.mailbox).toLowerCase()!=String(this.env.trash_mailbox).toLowerCase()) - this.move_messages(this.env.trash_mailbox); + // if shift was pressed delete it immediately + if (this.message_list.shiftkey) + { + if (confirm(this.get_label('deletemessagesconfirm'))) + this.permanently_remove_messages(); + } + else + this.move_messages(this.env.trash_mailbox); // if there is a trash mailbox defined but we *are* in it: else if (this.env.trash_mailbox && String(this.env.mailbox).toLowerCase() == String(this.env.trash_mailbox).toLowerCase()) this.permanently_remove_messages();

1 0

Question: Patches for SVN
by Robin Elfrink 15 Nov '06

15 Nov '06

I have a simple question: If I have (small) patches for current SVN, of which I'm fairly certain that they should be applied, do I post them here or do I create a ticket? Robin

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev November 2006