Dev July 2006

dev@lists.roundcube.net

50 participants
41 discussions

Folder name in browser header
by Erik 30 Jul '06

30 Jul '06

When selecting a folder the name does not show in the browser header. Only after hitting enter the name shows. This was a bug in the past which had been solved. Apparently it's back. I'm currently running 284, but I've noticed in the 283 as well. I thought there was ticket for this but I can't find it. Does anybody know if this ticket should be in Trac? If not then I will create a new ticket, but I'd rather re-open the old one. -- Regards, Erik

1 0

Cannot modify header info error
by phil 29 Jul '06

29 Jul '06

Ok, I've read/reread the thread about this error, but I still don't understand how to clear it up. Something about taking out the ?php> - but from where? [Thu Jul 27 12:26:21 2006] [error] [client 199.249.176.251] PHP Warning: Cannot modify header info rmation - headers already sent in Unknown on line 0 Thanks P -- http://fak3r.com - you don't have to kick it -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.

2 1

[patch] Junk mail highlight in message list (SpamAssassin specific)
by Manu 28 Jul '06

28 Jul '06

Hi, Here a very small patch for roundcube-cvs-20060413 (the one I run) and the revision-282. If a mail is marked as spam by SpamAssassin (X-Spam-Flag in headers) the message is hightlighted in light green in message list. This can be easily "disabled" by commentting the related section in the CSS. Hope you'll find this useful. Les informations contenues dans ce message électronique peuvent être de nature confidentielle et soumises à une obligation de secret. Elles sont destinées à l'usage exclusif du réel destinataire. Si vous n'êtes pas le réel destinataire ou si vous recevez ce message par erreur, merci de nous le notifier immédiatement en le retournant à l'adresse de son émetteur. The information contained in this e-mail may be privileged and confidential. It is intended for the exclusive use of the designated recipients named above. If you are not the intended recipient or if you receive this e-mail in error, please notify us immediatly and return the original message at the address of the sender. diff -ruN roundcubemail-cvs-20060413/program/lib/imap.inc /var/www/roundcubemail-cvs-20060413/program/lib/imap.inc --- roundcubemail-cvs-20060413/program/lib/imap.inc 2006-03-27 21:06:30.000000000 +0200 +++ /var/www/roundcubemail-cvs-20060413/program/lib/imap.inc 2006-07-27 12:40:13.000000000 +0200 @@ -1212,7 +1212,7 @@ /* FETCH date,from,subject headers */ $key="fh".($c++); - $request=$key." FETCH $message_set (BODY.PEEK[HEADER.FIELDS (DATE FROM TO SUBJECT REPLY-TO IN-REPLY-TO CC BCC CONTENT-TRANSFER-ENCODING CONTENT-TYPE MESSAGE-ID REFERENCE)])\r\n"; + $request=$key." FETCH $message_set (BODY.PEEK[HEADER.FIELDS (DATE FROM TO SUBJECT REPLY-TO IN-REPLY-TO CC BCC CONTENT-TRANSFER-ENCODING CONTENT-TYPE MESSAGE-ID REFERENCE X-SPAM-FLAG)])\r\n"; if (!fputs($fp, $request)) return false; do{ @@ -1261,6 +1261,7 @@ $result[$id]->from = $headers["from"]; $result[$id]->to = str_replace("\n", " ", $headers["to"]); $result[$id]->subject = str_replace("\n", "", $headers["subject"]); + $result[$id]->junk = array_key_exists("x-spam-flag", $headers) ? true : false; $result[$id]->replyto = str_replace("\n", " ", $headers["reply-to"]); $result[$id]->cc = str_replace("\n", " ", $headers["cc"]); $result[$id]->bcc = str_replace("\n", " ", $headers["bcc"]); @@ -2079,4 +2080,4 @@ return (iil_C_Expunge($conn, $folder) >= 0); } -?> \ No newline at end of file +?> diff -ruN roundcubemail-cvs-20060413/program/steps/mail/func.inc /var/www/roundcubemail-cvs-20060413/program/steps/mail/func.inc --- roundcubemail-cvs-20060413/program/steps/mail/func.inc 2006-04-06 19:35:04.000000000 +0200 +++ /var/www/roundcubemail-cvs-20060413/program/steps/mail/func.inc 2006-07-27 12:42:40.000000000 +0200 @@ -406,11 +406,12 @@ // set attachment icon if ($attrib['attachmenticon'] && preg_match("/multipart\/m/i", $header->ctype)) $attach_icon = $attrib['attachmenticon']; - - $out .= sprintf('<tr id="rcmrow%d" class="message%s%s %s">'."\n", + + $out .= sprintf('<tr id="rcmrow%d" class="message%s%s%s %s">'."\n", $header->uid, $header->seen ? '' : ' unread', $header->deleted ? ' deleted' : '', + $header->junk ? ' junk' : '', $zebra_class); $out .= sprintf("<td class=\"icon\">%s</td>\n", $message_icon ? sprintf($image_tag, $skin_path, $message_icon, '') : ''); @@ -1470,4 +1471,4 @@ } -?> \ No newline at end of file +?> diff -ruN roundcubemail-cvs-20060413/skins/default/mail.css /var/www/roundcubemail-cvs-20060413/skins/default/mail.css --- roundcubemail-cvs-20060413/skins/default/mail.css 2006-04-04 23:41:22.000000000 +0200 +++ /var/www/roundcubemail-cvs-20060413/skins/default/mail.css 2006-07-27 12:47:01.000000000 +0200 @@ -439,6 +439,12 @@ background-color: #FFFFFF; } +#messagelist tr.junk +{ + /*font-style: oblique;*/ + background-color: #e0ffcc; +} + #messagelist tr.selected td { font-weight: bold; diff -ruN roundcubemail-rev282.orig/program/lib/imap.inc roundcubemail-rev282.junk/program/lib/imap.inc --- roundcubemail-rev282.orig/program/lib/imap.inc 2006-07-27 13:35:41.000000000 +0200 +++ roundcubemail-rev282.junk/program/lib/imap.inc 2006-07-27 13:41:56.000000000 +0200 @@ -1231,7 +1231,7 @@ /* FETCH date,from,subject headers */ $key="fh".($c++); - $request=$key." FETCH $message_set (BODY.PEEK[HEADER.FIELDS (DATE FROM TO SUBJECT REPLY-TO IN-REPLY-TO CC BCC CONTENT-TRANSFER-ENCODING CONTENT-TYPE MESSAGE-ID REFERENCE)])\r\n"; + $request=$key." FETCH $message_set (BODY.PEEK[HEADER.FIELDS (DATE FROM TO SUBJECT REPLY-TO IN-REPLY-TO CC BCC CONTENT-TRANSFER-ENCODING CONTENT-TYPE MESSAGE-ID REFERENCE X-SPAM-FLAG)])\r\n"; if (!fputs($fp, $request)) return false; do{ @@ -1280,6 +1280,7 @@ $result[$id]->from = $headers["from"]; $result[$id]->to = str_replace("\n", " ", $headers["to"]); $result[$id]->subject = str_replace("\n", "", $headers["subject"]); + $result[$id]->junk = array_key_exists("x-spam-flag", $headers) ? true : false; $result[$id]->replyto = str_replace("\n", " ", $headers["reply-to"]); $result[$id]->cc = str_replace("\n", " ", $headers["cc"]); $result[$id]->bcc = str_replace("\n", " ", $headers["bcc"]); diff -ruN roundcubemail-rev282.orig/program/steps/mail/func.inc roundcubemail-rev282.junk/program/steps/mail/func.inc --- roundcubemail-rev282.orig/program/steps/mail/func.inc 2006-07-27 13:35:45.000000000 +0200 +++ roundcubemail-rev282.junk/program/steps/mail/func.inc 2006-07-27 13:41:56.000000000 +0200 @@ -422,11 +422,12 @@ // set attachment icon if ($attrib['attachmenticon'] && preg_match("/multipart\/m/i", $header->ctype)) $attach_icon = $attrib['attachmenticon']; - - $out .= sprintf('<tr id="rcmrow%d" class="message%s%s %s">'."\n", + + $out .= sprintf('<tr id="rcmrow%d" class="message%s%s%s %s">'."\n", $header->uid, $header->seen ? '' : ' unread', $header->deleted ? ' deleted' : '', + $header->junk ? ' junk' : '', $zebra_class); $out .= sprintf("<td class=\"icon\">%s</td>\n", $message_icon ? sprintf($image_tag, $skin_path, $message_icon, '') : ''); diff -ruN roundcubemail-rev282.orig/skins/default/mail.css roundcubemail-rev282.junk/skins/default/mail.css --- roundcubemail-rev282.orig/skins/default/mail.css 2006-07-27 13:35:47.000000000 +0200 +++ roundcubemail-rev282.junk/skins/default/mail.css 2006-07-27 13:41:56.000000000 +0200 @@ -450,6 +450,12 @@ background-color: #FFFFFF; } +#messagelist tr.junk +{ + /*font-style: oblique;*/ + background-color: #e0ffcc; +} + #messagelist tr.selected td { font-weight: bold;

5 6

Wrong sorting - please help me debug this
by Michael Bueker 28 Jul '06

28 Jul '06

Hey there, before I file a ticket, I'd like to find out a little more about what might be causing this - so please help me :) This is SVN revision 247: When sorting by date (displaying Messages 1 to 64 of 1211) with the arrow in the "Date" column pointing up (sorry forthis, but I really can't figure out how it's _supposed_ to be sorted...), the sorting is pretty much random I'll give you a little overview: 1 Sun 14:50 (Source: Date: Sun, 16 Jul 2006 14:50:51 +0200) 2 09.02.2006 17:14 (Source: Date: Thu, 09 Feb 2006 16:14:58 +0100) 3 10.02.2006 18:47 (Source: Date: Fri, 10 Feb 2006 17:47:48 +0100) 4 17.03.2006 18:11 (Source: Date: Fri, 17 Mar 2006 17:11:25 +0100) .. 15 12.07.2006 14:51 (Source: Date: Wed, 12 Jul 2006 14:51:53 +0200) 16 Tue 14:04 (Source: Date: Tue, 18 Jul 2006 14:04:36 +0200) 17 11.01.2006 12:20 (Source: Date: Wed, 11 Jan 2006 11:20:53 +0100) .. 62 12.07.2006 14:37 (Source: Date: Wed, 12 Jul 2006 14:37:47 +0200) 63 Sat 19:54 (Source: Date: Sat, 15 Jul 2006 19:54:03 +0200) 64 Sun 14:53 (Source: Date: Sun, 16 Jul 2006 14:53:13 +0200) This happens with both Pretty Dates on and off, and in several folders in a similar way. I hope this helps! mtu -- I skipped losing my virginity for this game. - Theodorick on the Civilization 4 Forums

6 22

Browser rendering error in Firefox on Mac
by Michael Bueker 26 Jul '06

26 Jul '06

Hi folks! A friend of mine who also uses roundcube reported this to me and gave me the attached screenshot. I have no Mac, so I can't try to reproduce it. I hope there's somebody who can look into this. mtu -- Is that an ICBM in your capital, or are you just happy to see me? - Civilization IV fan pickup line (by Llewen)

4 4

SVN errors
by Thomas Bruederli 26 Jul '06

26 Jul '06

Hi everybody, For all who experienced problems with the SVN repository, just note that those problems are fixed and you can checkout as usual. Thanks for your patience! Thomas

2 1

Re: Fwd: Roundcube merger - Ideas from atmail
by WOODS John 26 Jul '06

26 Jul '06

So we need to create a new project called SquareSphere!!! -----Original Message----- From: Blane Bramble [mailto:blane@dialmediagroup.com] Sent: 26 July 2006 11:51 To: dev(a)lists.roundcube.net Subject: Re: Fwd: Roundcube merger - Ideas from atmail WOODS John wrote: > I am inclined to agree with Michael on this. > > The timing of this offer is very interesting. Roundcube is very close to > an excellent beta 2 and full release cannot be more than six months > away. > > @mail is doing this on purely commercial grounds (nothing wrong with > that) but it would be sad to see such a good Open Source project > disappear as it surely would. > > However, I would like to understand what would happen to the source code > if Thomas should decide to sell. Who actually owns the code given that > at least a dozen people have contributed? > > Is it the case that the code will remain open even after he sells it and > therefore couldn't anyone else start a new project from what exists > already? > The existing GPL'd code remains under GPL - this cannot be removed, and so a new Open Source project could be forked under a new name (assuming the RoundCube name was part of the purchase).

2 1

Re: Fwd: Roundcube merger - Ideas from atmail
by WOODS John 26 Jul '06

26 Jul '06

I am inclined to agree with Michael on this. The timing of this offer is very interesting. Roundcube is very close to an excellent beta 2 and full release cannot be more than six months away. @mail is doing this on purely commercial grounds (nothing wrong with that) but it would be sad to see such a good Open Source project disappear as it surely would. However, I would like to understand what would happen to the source code if Thomas should decide to sell. Who actually owns the code given that at least a dozen people have contributed? Is it the case that the code will remain open even after he sells it and therefore couldn't anyone else start a new project from what exists already? Whatever Thomas does that is his decision and we should all congratulate him on creating an outstanding webmail client and wish him well. -----Original Message----- From: Michael Bueker [mailto:m.bueker@berlin.de] Sent: 26 July 2006 11:23 To: Thomas Bruederli Cc: dev(a)lists.roundcube.net; Uwe(a)mtu.homelinux.net; Schaefer(a)mtu.homelinux.net Subject: Re: Fwd: Roundcube merger - Ideas from atmail On Wed, 26 Jul 2006 09:49:34 +0200, "Thomas Bruederli" <roundcube(a)gmail.com> wrote: > Hi everybody, > > Just wanted to forward a mail I've got yesterday and would like to > hear your opinions about this topic. Either this could make RoundCube > grow faster or atmail just wants to get rid of some (more and more > serious) competition. I am totally opposed to this idea. First of all, it would damage roundcube's reputation insofar as there will always be the "better" commercial version of <whatever rounbcude+atmail would be called>. I am sure this would make less people want to even try roundcube. And frankly, I would prefer a smaller, less functional but totally free application over the open source branch of something commercial any day. Secondly, they are proposing to buy roundcube out, and if I understood correctly, they want to buy the license. That would not only mean that they'll use all of roundcube's features in their commercial product (which I'd simply oppose because the work wasn't meant to be aiding their profit), but also that they could un-open source the open source tree any day. Thirdly, they want to buy roundcube out. While that may be nice in terms of their business world, I think it's totally inappropriate, because it would be impossible to evenly distribute the money among everyone who's contributed to roundcube during its development. Call me an FOSS radical, but this offer violates my principles. Not that I have a lot to say, being new here, but still. I'd very much like roundcube to stay completely free as in speech. Cheers, mtu

3 2

Re: Fwd: Roundcube merger - Ideas from atmail
by Michael Bueker 26 Jul '06

26 Jul '06

On Wed, 26 Jul 2006 09:49:34 +0200, "Thomas Bruederli" <roundcube(a)gmail.com> wrote: > Hi everybody, > > Just wanted to forward a mail I've got yesterday and would like to > hear your opinions about this topic. Either this could make RoundCube > grow faster or atmail just wants to get rid of some (more and more > serious) competition. I am totally opposed to this idea. First of all, it would damage roundcube's reputation insofar as there will always be the "better" commercial version of <whatever rounbcude+atmail would be called>. I am sure this would make less people want to even try roundcube. And frankly, I would prefer a smaller, less functional but totally free application over the open source branch of something commercial any day. Secondly, they are proposing to buy roundcube out, and if I understood correctly, they want to buy the license. That would not only mean that they'll use all of roundcube's features in their commercial product (which I'd simply oppose because the work wasn't meant to be aiding their profit), but also that they could un-open source the open source tree any day. Thirdly, they want to buy roundcube out. While that may be nice in terms of their business world, I think it's totally inappropriate, because it would be impossible to evenly distribute the money among everyone who's contributed to roundcube during its development. Call me an FOSS radical, but this offer violates my principles. Not that I have a lot to say, being new here, but still. I'd very much like roundcube to stay completely free as in speech. Cheers, mtu

1 0

BincIMAP Search Patch
by Jim Pingle 25 Jul '06

25 Jul '06

Is there anyone else around that is currently using BincIMAP? I have a BincIMAP server I'm forced to deal with in one setup, and the search feature fails in the default configuration, because BincIMAP doesn't understand UTF-8 and chokes when RoundCube sends the search query with UTF-8 specified as the charset. I have a patch that fixes this for me, but I'm sure it could use some more testing/comments/whatever. The ticket for this is #1483855 The patch is on the ticket: http://trac.roundcube.net/trac.cgi/attachment/ticket/1483855/bincimap_searc… Basically, if the search fails the first time it retries the search without a charset specified. Assuming I read the code right, this should only happen with a server error, not just an empty message set. (Another pair of eyes might help verify that...) Thanks, Jim

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev July 2006