Dev January 2007

dev@lists.roundcube.net

63 participants
55 discussions

Branch devel-addressbook
by Thomas Bruederli 15 Jan '07

15 Jan '07

Hi everybody Those of you who keep track of the changesets may have notices that I created a branch to re-write the addressbook interface. I also made some code cleanup and moved some functions around. I'm sure that you gonna hate me for that but I think it's worth it :-) The changeset is quite big so here's an overview what changed: - Created a new class rcube_contacts that abstracts the acess to the local address book. Another class with the same interface is on the way to handle the LDAP access. - Moved template parsing functions to a new class rcmail_template which extends the rcube_html_page class. The global object $OUTPUT is now an instance of rcmail_template. - Replaced all $OUTPUT->add_script("$JS_OBJECT_NAME.set_env('foo', '$bar');"); with the more elegant $OUTPUT->set_env('foo', $bar); Now also conditional template objects can access the env vars. - Got rid of the global vars $JS_OBJECT_NAME and $CHARSET. Those have been replaced by constans because they actually are constant values. - Moved simple steps (html2text and quotaimg) out of the common request process and created simple scripts in /bin/. These do not nead any user authentication or session values. - Started to send POST requests from the client for actions that alter data. Changing application states with GET is against RFC and allows for CSRF vulnerabilities. e.g. if someone were to email an RC user with: <img src="?_task=addressbook&_action=delete&_cid=1&_from=&_remote=1"> Then a contact would be deleted. Please check out the new branch from https://svn.roundcube.net/branches/devel-addressbook and test it. Don't replace an existing (productive) installation with it. Comments about the changes and the new classes are welcome. Regards, Thomas

2 2

Template Questions
by Ralf Scholle 15 Jan '07

15 Jan '07

Hello, i found 2 "problems" on the template: first in main.inc.php i have this variables $rcmail_config['skin_path'] = ''; and $rcmail_config['product_name'] = ''; why didn't we use this at the templates?? for example in /templates/login.html the information is "Hardcoded" <img src="skins/default/images/roundcube_logo.png" id="rcmbtn104" width="165" height="55" border="0" alt="RoundCube Webmail" hspace="10" /> or in /includes/header.html <roundcube:button command="mail" image="/images/roundcube_logo.png" alt="RoundCube Webmail" width="165" height="55" /> i think id would be better when we could use the variables?!! What do you think?? cu Ralf -- Sorry for my English :-/ ___________________________________________________________ Der frühe Vogel fängt den Wurm. Hier gelangen Sie zum neuen Yahoo! Mail: http://mail.yahoo.de

5 5

HTML Email bugs in latest beta (stable)
by Justin Frydman 15 Jan '07

15 Jan '07

Hey all, We just upgraded and we send html invoices out. The invoice template for these have not been adjusted but now looks like roundcube is not rendering the html properly anymore. Getting things right in the message like: __removed=red> and *__removed=https: Any ideas? *

2 4

Edit Identities During First Login (#1291605)
by Jim Pingle 14 Jan '07

14 Jan '07

I posted this in the forums, and didn't get much of a response, so I thought I'd try my luck here. Some time ago, the ability for new users to be presented with the "Edit Identity" screen after their first login was requested. (Ticket #1291605, http://trac.roundcube.net/trac.cgi/ticket/1291605 ) Attached is a patch that should add this feature in. This was patched against SVN rev 459, but it may work on older revisions. I'm sure there is room for improvement. NB: This feature is controlled by an additional setting in config/main.inc.php : $rcmail_config['new_user_edit_identity'] = TRUE; I suppose you could display a "welcome" message on the edit identities screen if they are a new user also, but that would require additional localization / translation, among other changes. Jim P.S. RE: Developer Guidelines, should boolean variables be in all caps (TRUE/FALSE) or lower case (true/false)? It seems to goes back and forth a lot in the code, so I wasn't sure. Index: config/main.inc.php.dist =================================================================== --- config/main.inc.php.dist (revision 459) +++ config/main.inc.php.dist (working copy) @@ -31,6 +31,10 @@ // set to false if only registered users can use this service $rcmail_config['auto_create_user'] = TRUE; +// present the user with an "edit identity" screen upon first login +// This is only useful if auto_create_user is also set to true. +$rcmail_config['new_user_edit_identity'] = TRUE; + // the mail host chosen to perform the log-in // leave blank to show a textbox at login, give a list of hosts // to display a pulldown menu or set one host as string. Index: program/include/main.inc =================================================================== --- program/include/main.inc (revision 459) +++ program/include/main.inc (working copy) @@ -548,6 +548,8 @@ else if ($CONFIG['auto_create_user']) { $user_id = rcmail_create_user($user, $host); + if ($CONFIG['new_user_edit_identity']) + $_SESSION['new_user'] = TRUE; } if ($user_id) Index: index.php =================================================================== --- index.php (revision 459) +++ index.php (working copy) @@ -177,6 +177,24 @@ get_input_value('_pass', RCUBE_INPUT_POST, true, 'ISO-8859-1'), $host)) { // send redirect + if (isset($_SESSION['new_user']) && $_SESSION['new_user'] === TRUE) + { + // Get identity id + $sql_result = $DB->query("SELECT identity_id + FROM ".get_table_name('identities')." + WHERE user_id=? + AND del<>1 + LIMIT 1", + $_SESSION['user_id']); + + // If we can find an identity, redirect to the edit screen. + if ($DB->num_rows($sql_result) && ($sql_arr = $DB->fetch_assoc($sql_result))) + { + $identity_id = $sql_arr['identity_id']; + if (!empty($identity_id) && ($identity_id > 0)) + $COMM_PATH = "./?_task=settings&_action=edit-identity&_iid=" . $identity_id; + } + } header("Location: $COMM_PATH"); exit; }

3 2

Correction Hellenic translation
by jim＠cobaltblue.gr 14 Jan '07

14 Jan '07

In my hast, I neglected to include the link to the translation tar: http://www.cobaltblue.gr/el.tar

1 0

Hellenic Translation
by jim＠cobaltblue.gr 14 Jan '07

14 Jan '07

Hello all, I'm posting the Hellenic translation for Roundcube beta2. I had translated and submitted the translation for Roundcube beta1, but unfortunately I did not see it as an official translation on the website, sourceforge etc. Thank you all for your terrific work, this is my small contribution back. Kind regards Jim Deves

1 0

Re: Template Questions
by Brett Patterson 11 Jan '07

11 Jan '07

Ralf Scholle wrote: > Brett Patterson schrieb: > >> Ralf Scholle wrote: >> >>> Hello, >>> >>> i found 2 "problems" on the template: >>> >>> first in main.inc.php i have this variables >>> $rcmail_config['skin_path'] = ''; >>> and >>> $rcmail_config['product_name'] = ''; >>> >>> why didn't we use this at the templates?? >>> >>> for example in /templates/login.html the information is "Hardcoded" >>> <img src="skins/default/images/roundcube_logo.png" id="rcmbtn104" >>> width="165" height="55" border="0" alt="RoundCube Webmail" >>> hspace="10" /> >>> >>> or in /includes/header.html >>> <roundcube:button command="mail" image="/images/roundcube_logo.png" >>> alt="RoundCube Webmail" width="165" height="55" /> >>> >>> i think id would be better when we could use the variables?!! >>> What do you think?? >>> >>> cu Ralf >>> >>> -- >>> Sorry for my English :-/ >>> >>> >>> >>> >>> >>> ___________________________________________________________ Der frühe >>> Vogel fängt den Wurm. Hier gelangen Sie zum neuen Yahoo! Mail: >>> http://mail.yahoo.de >>> >>> >>> >>> >>> >> The skin path just tells RC which skin to use. Within each >> subdirectory of the themes folder are self-contained themes. They're >> self contained meaning that they use their own images / layouts. >> >> I personally like how it's done now. I don't see a reason for >> changing the theming system. >> >> ~Brett >> >> >> >> > Hey Brett, > > sorry i write to you and not to the list but let me explain what i mean ... > > my Question was why the variables from the config file are not in the > theme?? > I thought it could be better for example this way: > <img src="<?php $rcmail_config['skin_path'] > ?>/images/roundcube_logo.png" id="rcmbtn104" > width="165" height="55" border="0" alt="<?php > $rcmail_config['product_name'] ?>" hspace="10" /> > > instead of this way?? > <img src="skins/default/images/roundcube_logo.png" id="rcmbtn104" > width="165" height="55" border="0" alt="RoundCube Webmail" hspace="10" /> > > so everybody can change the variables in the config file and in the > themes automaticaly changes the path ... > > you understood?? > > cu Ralf > > > ___________________________________________________________ > Telefonate ohne weitere Kosten vom PC zum PC: http://messenger.yahoo.de > I understand what you mean. But it's trivial the change you want to do. Plus, on top of that, the themes are strict HTML. So there should be no PHP code inside of it. If you look at every theme, it uses Roundcube's Theme Engine (brilliant I might add) to properly parse messages, folders, actions and such. No PHP code is to be contained in the themes. What you're suggesting is the complete opposite of abstraction. You want to put PHP code directly into the theme which. The whole point of the template parser is to get the PHP out of the theme so that non-PHP web designers can create a slick GUI for Roundcube. So that being said, I understand what you're saying, but it goes against the whole point of abstraction and the MVC. I still am totally against making the change(s) you suggest about this. ~Brett

1 0

New folder parent selection (#1457344)
by Robin Elfrink 11 Jan '07

11 Jan '07

An attempt to fix feature request #1457344, select parent folder when creating new folder. To do: - Make JS display new folder at the appropriate position. - Check with http://trac.roundcube.net/trac.cgi/wiki/Dev_Guidelines Comments so far, anybody? Robin Index: program/include/main.inc =================================================================== --- program/include/main.inc (revision 455) +++ program/include/main.inc (working copy) @@ -1366,6 +1366,7 @@ 'identityform' => 'rcube_identity_form', 'foldersubscription' => 'rcube_subscription_form', 'createfolder' => 'rcube_create_folder_form', + 'parentfolder' => 'rcube_parent_folder_form', 'renamefolder' => 'rcube_rename_folder_form', 'composebody' => 'rcmail_compose_body' ); Index: program/localization/en_US/labels.inc =================================================================== --- program/localization/en_US/labels.inc (revision 455) +++ program/localization/en_US/labels.inc (working copy) @@ -223,6 +223,7 @@ $labels['folder'] = 'Folder'; $labels['folders'] = 'Folders'; +$labels['parentfolder'] = 'Parent folder'; $labels['foldername'] = 'Folder name'; $labels['subscribed'] = 'Subscribed'; $labels['create'] = 'Create'; Index: program/js/app.js =================================================================== --- program/js/app.js (revision 455) +++ program/js/app.js (working copy) @@ -2426,10 +2426,13 @@ var form; if ((form = this.gui_objects.editform) && form.elements['_folder_name']) + { name = form.elements['_folder_name'].value; + fparent = form.elements['_folder_parent'].value; + } if (name) - this.http_request('create-folder', '_name='+urlencode(name), true); + this.http_request('create-folder', '_name='+urlencode(name)+'&_parent='+urlencode(fparent), true); else if (form.elements['_folder_name']) form.elements['_folder_name'].focus(); }; Index: program/steps/settings/manage_folders.inc =================================================================== --- program/steps/settings/manage_folders.inc (revision 455) +++ program/steps/settings/manage_folders.inc (working copy) @@ -47,18 +47,24 @@ else if ($_action=='create-folder') { if (!empty($_GET['_name'])) - $create = $IMAP->create_mailbox(trim(get_input_value('_name', RCUBE_INPUT_GET, FALSE, 'UTF-7')), TRUE); + { + $name = trim(get_input_value('_name', RCUBE_INPUT_GET, FALSE, 'UTF-7')); + if (!empty($_GET['_parent'])) + $name = trim(get_input_value('_parent', RCUBE_INPUT_GET, FALSE, 'UTF-7')) . $IMAP->delimiter . $name; + $create = $IMAP->create_mailbox($name, TRUE); + } if ($create && $REMOTE_REQUEST) { - $commands = sprintf("this.add_folder_row('%s','%s')", + $display_create = str_repeat('    ', substr_count($create, $IMAP->delimiter)).preg_replace('/.*'.preg_quote($IMAP->delimiter).'/', '', rcube_charset_convert($create, 'UTF-7')); + $commands .= sprintf("this.add_folder_row('%s','%s')", JQ($create), - JQ(rcube_charset_convert($create, 'UTF-7'))); + JQ($display_create)); rcube_remote_response($commands); } else if (!$create && $REMOTE_REQUEST) { - $commands = show_message('errorsaving', 'error'); + $commands .= show_message('errorsaving', 'error'); rcube_remote_response($commands); } else if (!$create) @@ -167,7 +173,9 @@ $zebra_class = $i%2 ? 'even' : 'odd'; $folder_js = JQ($folder); $folder_js_enc = JQ(rcube_charset_convert($folder, 'UTF-7')); - $folder_html = $CONFIG['protect_default_folders'] && in_array($folder, $CONFIG['default_imap_folders']) ? rcube_label(strtolower($folder)) : rcube_charset_convert($folder, 'UTF-7'); + $display_folder = str_repeat('    ', substr_count($folder, $IMAP->delimiter)).preg_replace('/.*'.preg_quote($IMAP->delimiter).'/', '', rcube_charset_convert($folder, 'UTF-7')); + + $folder_html = $CONFIG['protect_default_folders'] && in_array($folder, $CONFIG['default_imap_folders']) ? rcube_label(strtolower($folder)) : $display_folder; if (!$protected) $a_js_folders['rcmrow'.($i+1)] = array($folder_js, $folder_js_enc); @@ -239,6 +247,23 @@ return $out; } +function rcube_parent_folder_form($attrib) + { + global $IMAP; + + $select = new select(array('name' => '_folder_parent')); + $select->add('', ''); + + $folders = $IMAP->list_mailboxes(); + foreach ($folders as $folder) + { + $display_folder = str_repeat('    ', substr_count($folder, $IMAP->delimiter)).preg_replace('/.*'.preg_quote($IMAP->delimiter).'/', '', $folder); + $select->add($display_folder, $folder); + } + + return $select->show(''); + } + function rcube_rename_folder_form($attrib) { global $CONFIG, $IMAP, $JS_OBJECT_NAME; Index: skins/default/templates/managefolders.html =================================================================== --- skins/default/templates/managefolders.html (revision 455) +++ skins/default/templates/managefolders.html (working copy) @@ -25,9 +25,25 @@ <div class="boxtitle"><roundcube:label name="createfolder" /></div> <div class="settingspart"> +<table border="0" cellspacing="0" cellpadding="1"> +<tr> +<td> +<roundcube:label name="parentfolder" />:  +</td> +<td> +<roundcube:object name="parentfolder" form="subscriptionform" /> +</td> +</tr> +<tr> +<td> <roundcube:label name="foldername" />:  +</td> +<td> <roundcube:object name="createfolder" form="subscriptionform" /> <roundcube:button command="create-folder" type="input" class="button" label="create" /> +</td> +</tr> +</table> </div> </div>

3 5

de_DE corrections
by Michael Bueker 11 Jan '07

11 Jan '07

Hi, Attached, there are corrected versions of de_DE/messages.inc and labels.inc. Most changes are for consistency and language accuracy. ~Mik

2 2

Dovecot
by Justin Frydman 10 Jan '07

10 Jan '07

I am considering an upgrade to dovecot which uses maildir instead of mbox, will roundcube still function?

5 6

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev January 2007