Dev October 2007

dev@lists.roundcube.net

44 participants
45 discussions

iPhone usability
by Joel Clermont 27 Nov '07

27 Nov '07

Since there is no "double click" available through the iPhone interface, is there an alternate way to open a message? Joel Clermont joel(a)orionweb.net 262-377-9930 _______________________________________________ List info: http://lists.roundcube.net/dev/

6 13

Conditional HTML and preview pane
by Robin Elfrink 20 Nov '07

20 Nov '07

Hi, Another go at a preview pane. I implemented conditional HTML which works like this: <roundcube:if condition="config:preview==true" /> html bla bla <roundcube:else /> other html bla bla <roundcube:endif /> The preview code was mostly Thomas', plus a bit of myself to let the user decide for herself. Code is not yet optimized, so it looks like poo, and I suspect IE6 will have problems, because I delete some CSS which made it look strange in IE7. Robin Index: config/main.inc.php.dist =================================================================== --- config/main.inc.php.dist (revision 380) +++ config/main.inc.php.dist (working copy) @@ -228,5 +228,11 @@ // save compose message every 300 seconds (5min) $rcmail_config['draft_autosave'] = 300; +// Enable preview pane +$rcmail_config['enable_preview'] = FALSE; + +// Default setting if preview pane is enabled +$rcmail_config['preview'] = FALSE; + // end of config file ?> Index: program/include/main.inc =================================================================== --- program/include/main.inc (revision 380) +++ program/include/main.inc (working copy) @@ -1106,9 +1106,8 @@ return FALSE; } - // parse for specialtags - $output = parse_rcube_xml($templ); + $output = parse_rcube_xml(parse_rcube_conditions($templ)); $OUTPUT->write(trim(parse_with_globals($output)), $skin_path); @@ -1269,6 +1268,48 @@ } +// parse conditional code +function parse_rcube_conditions($input) + { + global $CONFIG; + if (($matches = preg_split('/<roundcube:(if|elseif|else|endif)\s+([^>]+)>/is', $input, 2, PREG_SPLIT_DELIM_CAPTURE)) && + (count($matches)==4)) + { + if (preg_match('/^(else|endif)$/i', $matches[1])) + return $matches[0] . '' . parse_rcube_conditions($matches[3]); + else + { + $attrib = parse_attrib_string($matches[2]); + if (isset($attrib['condition']) && + preg_match('/^(session|config):([a-zA-Z0-9_]+)([=<>!]+)(.*)$/i', $attrib['condition'], $opts)) + { + $condmet = false; + if ($opts[1]=='session') + $condmet = eval("return (\$_SESSION['" . $opts[2] . "']" . $opts[3] . "'" . $opts[4] . "');"); + elseif ($opts[1]=='config') + $condmet = eval("return (\$CONFIG['" . $opts[2] . "']" . $opts[3] . "'" . $opts[4] . "');"); + $submatches = preg_split('/<roundcube:(elseif|else|endif)\s+([^>]+)>/is', $matches[3], 2, PREG_SPLIT_DELIM_CAPTURE); + if ($condmet) + $result = $submatches[0] . preg_replace('/.*<roundcube:endif\s+[^>]+>/is', '', $submatches[3]); + else + $result = '<roundcube:' . $submatches[1] . $submatches[2] . $submatches[3]; + return $matches[0] . '' . parse_rcube_conditions($result); + } + else + { + raise_error(array('code' => 500, + 'type' => 'php', + 'line' => __LINE__, + 'file' => __FILE__, + 'message' => "Unable to parse conditional tag " . $matches[2]), TRUE, FALSE); + } + } + } + else + return $input; + } + + // create and register a button function rcube_button($attrib) { Index: program/localization/en_US/labels.inc =================================================================== --- program/localization/en_US/labels.inc (revision 380) +++ program/localization/en_US/labels.inc (working copy) @@ -211,6 +211,7 @@ $labels['dstactive'] = 'Daylight savings'; $labels['htmleditor'] = 'Compose HTML messages'; $labels['htmlsignature'] = 'HTML signature'; +$labels['preview'] = 'Show preview pane'; $labels['autosavedraft'] = 'Automatically save draft'; $labels['everynminutes'] = 'every $n minutes'; Index: program/js/app.js =================================================================== --- program/js/app.js (revision 380) +++ program/js/app.js (working copy) @@ -151,8 +151,15 @@ this.enable_command('firstmessage', true); } } + + // make preview/message frame visible + if (this.env.action == 'preview' && this.env.framed && parent.rcmail) + { + this.enable_command('compose', 'add-contact', false); + parent.rcmail.show_messageframe(true); + } - if (this.env.action=='show' && this.env.blockedobjects) + if ((this.env.action=='show' || this.env.action=='preview') && this.env.blockedobjects) { if (this.gui_objects.remoteobjectsmsg) this.gui_objects.remoteobjectsmsg.style.display = 'block'; @@ -637,7 +644,7 @@ case 'load-images': if (this.env.uid) - this.show_message(this.env.uid, true); + this.show_message(this.env.uid, true, this.env.action=='preview'); break; case 'load-attachment': @@ -667,22 +674,22 @@ case 'nextmessage': if (this.env.next_uid) - this.show_message(this.env.next_uid); + this.show_message(this.env.next_uid, false, this.env.action=='preview'); break; case 'lastmessage': if (this.env.last_uid) - this.show_message(this.env.last_uid); + this.show_message(this.env.last_uid, false, this.env.action=='preview'); break; case 'previousmessage': if (this.env.prev_uid) - this.show_message(this.env.prev_uid); + this.show_message(this.env.prev_uid, false, this.env.action=='preview'); break; case 'firstmessage': if (this.env.first_uid) - this.show_message(this.env.first_uid); + this.show_message(this.env.first_uid, false, this.env.action=='preview'); break; case 'checkmail': @@ -1052,6 +1059,9 @@ this.msglist_select = function(list) { + if (this.preview_timer) + clearTimeout(this.preview_timer); + var selected = list.selection.length==1; if (this.env.mailbox == this.env.drafts_mailbox) { @@ -1063,16 +1073,25 @@ this.enable_command('show', 'reply', 'reply-all', 'forward', 'print', selected); this.enable_command('delete', 'moveto', list.selection.length>0 ? true : false); } + + // start timer for message preview (wait for double click) + if (selected && this.env.contentframe) + this.preview_timer = setTimeout(this.ref+'.msglist_get_preview()', this.dblclick_time + 10); + else if (this.env.contentframe) + this.show_messageframe(false); }; this.msglist_dbl_click = function(list) { + if (this.preview_timer) + clearTimeout(this.preview_timer); + var uid = list.get_single_selection(); if (uid && this.env.mailbox == this.env.drafts_mailbox) this.goto_url('compose', '_draft_uid='+uid+'&_mbox='+urlencode(this.env.mailbox), true); else if (uid) - this.show_message(uid); + this.show_message(uid, false, false); }; @@ -1085,18 +1104,29 @@ }; + this.msglist_get_preview = function() + { + var uid = this.get_single_uid(); + if (uid && this.env.contentframe) + this.show_message(uid, false, true); + else if (this.env.contentframe) + this.show_messageframe(false); + }; + + /*********************************************************/ /********* (message) list functionality *********/ /*********************************************************/ // when user doble-clicks on a row - this.show_message = function(id, safe) + this.show_message = function(id, safe, preview) { var add_url = ''; + var action = preview ? 'preview': 'show'; var target = window; - if (this.env.contentframe && window.frames && window.frames[this.env.contentframe]) + if (preview && this.env.contentframe && window.frames && window.frames[this.env.contentframe]) { target = window.frames[this.env.contentframe]; add_url = '&_framed=1'; @@ -1107,13 +1137,27 @@ if (id) { - this.set_busy(true, 'loading'); - target.location.href = this.env.comm_path+'&_action=show&_uid='+id+'&_mbox='+urlencode(this.env.mailbox)+add_url; + var url = '&_action='+action+'&_uid='+id+'&_mbox='+urlencode(this.env.mailbox)+add_url; + if (action == 'preview' && String(target.location.href).indexOf(url) >= 0) + this.show_messageframe(true); + else + { + this.set_busy(true, 'loading'); + target.location.href = this.env.comm_path+url; + } } }; + this.show_messageframe = function(show) + { + var frm; + if (this.env.contentframe && (frm = rcube_find_object(this.env.contentframe))) + frm.style.display = show ? 'block' : 'none'; + }; + + // list a specific page this.list_page = function(page) { Index: program/steps/settings/func.inc =================================================================== --- program/steps/settings/func.inc (revision 380) +++ program/steps/settings/func.inc (working copy) @@ -155,6 +155,16 @@ rep_specialchars_output(rcube_label('htmleditor')), $input_htmleditor->show($CONFIG['htmleditor']?1:0)); + if ($CONFIG['enable_preview']) + { + $field_id = 'rcmfd_preview'; + $input_preview = new checkbox(array('name' => '_preview', 'id' => $field_id, 'value' => 1)); + $out .= sprintf("<tr><td class=\"title\"><label for=\"%s\">%s</label></td><td>%s</td></tr>\n", + $field_id, + rep_specialchars_output(rcube_label('preview')), + $input_preview->show($CONFIG['preview']?1:0)); + } + if (!empty($CONFIG['drafts_mbox'])) { $field_id = 'rcmfd_autosave'; @@ -242,4 +252,4 @@ } -?> \ No newline at end of file +?> Index: program/steps/settings/save_prefs.inc =================================================================== --- program/steps/settings/save_prefs.inc (revision 380) +++ program/steps/settings/save_prefs.inc (working copy) @@ -29,6 +29,8 @@ $a_user_prefs['pagesize'] = is_numeric($_POST['_pagesize']) ? (int)$_POST['_pagesize'] : $CONFIG['pagesize']; $a_user_prefs['prefer_html'] = isset($_POST['_prefer_html']) ? TRUE : FALSE; $a_user_prefs['htmleditor'] = isset($_POST['_htmleditor']) ? TRUE : FALSE; +if ($CONFIG['enable_preview']) + $a_user_prefs['preview'] = isset($_POST['_preview']) ? TRUE : FALSE; $a_user_prefs['draft_autosave'] = isset($_POST['_draft_autosave']) ? intval($_POST['_draft_autosave']) : 0; // MM: Date format toggle (Pretty / Standard) Index: program/steps/mail/show.inc =================================================================== --- program/steps/mail/show.inc (revision 380) +++ program/steps/mail/show.inc (working copy) @@ -34,8 +34,14 @@ // go back to list if message not found (wrong UID) if (!$MESSAGE['headers'] || !$MESSAGE['structure']) { - $_action = 'list'; - return; + show_message('messageopenerror', 'error'); + if ($_action=='preview' && template_exists('messagepreview')) + parse_template('messagepreview'); + else + { + $_action = 'list'; + return; + } } $MESSAGE['subject'] = $IMAP->decode_header($MESSAGE['headers']->subject); @@ -131,28 +137,6 @@ -// return an HTML iframe for loading mail content -function rcmail_messagecontent_frame($attrib) - { - global $COMM_PATH, $OUTPUT, $GET_URL, $JS_OBJECT_NAME; - - // allow the following attributes to be added to the <iframe> tag - $attrib_str = create_attrib_string($attrib); - $framename = 'rcmailcontentwindow'; - - $out = sprintf('<iframe src="%s" name="%s"%s>%s</iframe>'."\n", - $GET_URL, - $framename, - $attrib_str, - rcube_label('loading')); - - - $OUTPUT->add_script("$JS_OBJECT_NAME.set_env('contentframe', '$framename');"); - - return $out; - } - - function rcmail_remote_objects_msg($attrib) { global $CONFIG, $OUTPUT, $JS_OBJECT_NAME; @@ -177,8 +161,10 @@ } -if ($_action=='print') +if ($_action=='print' && template_exists('printmessage')) parse_template('printmessage'); +else if ($_action=='preview' && template_exists('messagepreview')) + parse_template('messagepreview'); else parse_template('message'); -?> \ No newline at end of file +?> Index: program/steps/mail/func.inc =================================================================== --- program/steps/mail/func.inc (revision 380) +++ program/steps/mail/func.inc (working copy) @@ -481,6 +481,7 @@ $javascript .= sprintf("%s.set_env('pagecount', %d);\n", $JS_OBJECT_NAME, ceil($message_count/$IMAP->page_size)); $javascript .= sprintf("%s.set_env('sort_col', '%s');\n", $JS_OBJECT_NAME, $sort_col); $javascript .= sprintf("%s.set_env('sort_order', '%s');\n", $JS_OBJECT_NAME, $sort_order); + $javascript .= sprintf("%s.set_env('preview', '%s');\n", $JS_OBJECT_NAME, $CONFIG['enable_preview'] && $CONFIG['preview']); if ($attrib['messageicon']) $javascript .= sprintf("%s.set_env('messageicon', '%s%s');\n", $JS_OBJECT_NAME, $skin_path, $attrib['messageicon']); @@ -558,6 +559,28 @@ } +// return an HTML iframe for loading mail content +function rcmail_messagecontent_frame($attrib) + { + global $OUTPUT, $JS_OBJECT_NAME; + + if (empty($attrib['id'])) + $attrib['id'] = 'rcmailcontentwindow'; + + // allow the following attributes to be added to the <iframe> tag + $attrib_str = create_attrib_string($attrib, array('id', 'class', 'style', 'src', 'width', 'height', 'frameborder')); + $framename = $attrib['id']; + + $out = sprintf('<iframe name="%s"%s></iframe>'."\n", + $framename, + $attrib_str); + + $OUTPUT->add_script("$JS_OBJECT_NAME.set_env('contentframe', '$framename');"); + + return $out; + } + + // return code for search function function rcmail_search_form($attrib) { Index: skins/default/templates/mail.html =================================================================== --- skins/default/templates/mail.html (revision 380) +++ skins/default/templates/mail.html (working copy) @@ -42,6 +42,22 @@ </div> +<roundcube:if condition="config:preview==true" /> +<div id="mailcontframe" class="preview"> +<roundcube:object name="messages" + id="messagelist" + cellspacing="0" + summary="Message list" + messageIcon="/images/icons/dot.png" + unreadIcon="/images/icons/unread.png" + deletedIcon="/images/icons/deleted.png" + repliedIcon="/images/icons/replied.png" + attachmentIcon="/images/icons/attachment.png" /> +</div> +<div id="mailpreviewframe"> +<roundcube:object name="messagecontentframe" id="messagecontframe" width="100%" height="100%" frameborder="0" src="/watermark.html" /> +</div> +<roundcube:else /> <div id="mailcontframe"> <roundcube:object name="messages" id="messagelist" @@ -53,6 +69,7 @@ repliedIcon="/images/icons/replied.png" attachmentIcon="/images/icons/attachment.png" /> </div> +<roundcube:endif /> <div id="listcontrols"> <roundcube:label name="select" />:  Index: skins/default/templates/messagepreview.html =================================================================== --- skins/default/templates/messagepreview.html (revision 0) +++ skins/default/templates/messagepreview.html (revision 0) @@ -0,0 +1,19 @@ +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> +<html xmlns="http://www.w3.org/1999/xhtml"> +<head> +<title><roundcube:object name="pagetitle" /></title> +<link rel="stylesheet" type="text/css" href="/common.css" /> +<link rel="stylesheet" type="text/css" href="/mail.css" /> +</head> +<body class="iframe"> + +<div class="messageheaderbox"> +<roundcube:object name="messageHeaders" class="headers-table" cellspacing="0" cellpadding="2" addicon="/images/icons/plus.gif" summary="Message headers" /> +<roundcube:object name="messageAttachments" id="attachment-list" /> +</div> + +<roundcube:object name="blockedObjects" id="remote-objects-message" /> +<roundcube:object name="messageBody" id="messagebody" /> + +</body> +</html> Index: skins/default/mail.css =================================================================== --- skins/default/mail.css (revision 380) +++ skins/default/mail.css (working copy) @@ -117,10 +117,34 @@ overflow: auto; /* css hack for IE */ width: expression((parseInt(document.documentElement.clientWidth)-240)+'px'); - height: expression((parseInt(document.documentElement.clientHeight)-125)+'px'); } +#mailcontframe.preview { + bottom: auto; + height: 210px; +} +#mailpreviewframe +{ + position: absolute; + top: 300px; + left: 200px; + right: 40px; + bottom: 40px; + border: 1px solid #999999; + background-color: #F9F9F9; + /* css hack for IE */ + width: expression((parseInt(document.documentElement.clientWidth)-240)+'px'); + height: expression((parseInt(document.documentElement.clientHeight)-340)+'px'); +} + +#messagecontframe +{ + width: 100%; + height: 100%; + border: 0; +} + #messagepartframe { border: 1px solid #999999; Index: index.php =================================================================== --- index.php (revision 380) +++ index.php (working copy) @@ -262,7 +262,7 @@ { include_once('program/steps/mail/func.inc'); - if ($_action=='show' || $_action=='print') + if ($_action=='show' || $_action=='preview' || $_action=='print') include('program/steps/mail/show.inc'); if ($_action=='get')

2 3

Mettre l'ordre des colonnes des mails dans les preferences utilisateurs
by krowix krowix 01 Nov '07

01 Nov '07

Bonjour, je ne sais pas si cela est en preparation ou si cela a déjà été fait , c'est pour cela que je pose cette question. Est ce que la possibiblité de mettre l'ordre des colonnes subject,from,date,size ( $CONFIG['list_cols']) dans les preferences de l'utilisateur a déjà été envisagée ? Merci de vos reponses. _______________________________________________ List info: http://lists.roundcube.net/dev/

4 4

Re: [RCD] Patch for new features
by markevich＠inbox.lv 31 Oct '07

31 Oct '07

Hello. I have some comments on moving spam to Spam folder buttons feature. I agree that such a feature would be a good addition to the source, so I would suggest expanding your new feature like this: 1) there is should be on/off switch in config file for this feature; 2) there are should be mail folder names to move spam/non-spam to in the config file (not hard coded but customizable); 3) there is should be mail forwarding feature for spam emails. There are might be 2 config variables which contain email address for spam/non-spam messages to be forwarded to for retraining. This forwarder must NOT modify message body and headers. If these config variables are empty so no forwarding would be done only moving email to the folder after pressing corresponding button. I can explain why I think that 3) note is so critical. It's ok to use retraining scripts for all found e-mails in all mailboxes when you have 10-100 users, but if your user count reaches 100k-1m your server simply will die parsing such amount of data (millions of e-mails). In this case mail forwarding is used for retraining, but current Roundcube implementation doesn't allow taking full advantage of this approach because it's deleting original header from the forwarded e-mail which contain anti-spam signatures. We can store these signatures in the mail body but I'm deadly against disturbing user's correspondence with any additional "junk" not related to the mail content. This is my opinion how it should look, please fill free to comment and suggest improvements. Regards, Andris ---------- Forwarded message ---------- From: Marcelo Salhab Brogliato Date: Oct 27, 2007 1:32 PM Subject: Re: [RCD] Patch for new features To: till Hello till, I don't have svn installed in the shell that I'm working on.. but I already sent an email asking for instalation! Soon I'll send my first patch :)) About the last feature that I sad: Let's get a situation: you are on the compose page writing some email.. so you wan't to see the address book to add more recipients. When you click Address Book, you "lost" your email (you can save in the draft)... Does you guys have a patch to solve this? Thanks for your help Salhab On 10/27/07, till wrote: Hi Salhab, no problem, but please CC the list, so others learn from this. :) Basically the best way is the following: 1) Get latest code from SVN (trunk) 2) Migrate all your changes in there, test 3) Create patches using "svn diff > feature.patch" Till On 10/27/07, Marcelo Salhab Brogliato wrote: Hi Till, that's my first contribution to open source projects... I'm completelly a newbie! :)) How can I create a patch? I have no idea... I think it isn't just attaching the files that I changed.. Maybe a CHANGELIST? Or a little tutorial with the codes and where they should be inserted? What do you mean by "configurable"? The name of the folders are fixed by now.. but a little change in the source make it user-defined :) Thanks for your answer. Salhab On 10/27/07, till wrote: Hi Salhab, On 10/27/07, Marcelo Salhab Brogliato < msbrogli(a)gmail.com> wrote: Hi to everyone, I'm new to the list and working on RoundCube.. but I changed him a little to satisfy my needs. I implemented 3 features that you can check at: http://www.vialink.com.br/webmail4/ email: msbrogli2(a)vialink.com.br password: 123456 Essentially, it is: * a checkbox at the left... to make the life of the ones who aren't familiarized with AJAX (in my case, my customers) easier... so, they can easily select more than a message.. I thought there were discussions already and I don't think this will make its way into the source. The reason is - we aim to provide a desktop-like look and feel.I don't see checkboxes in Outlook, Eudora, Thunderbird or kMail. * a droplist to move selected messages between the folders * 2 buttons called SPAM and NO-SPAM.. they move the message to the folders Spam and No-Spam... but why? because I developed a script to periodically check that folders and train spamassassin to work better... Not a bad idea. Are the folders configurable? (I obviously haven't check your patch yet, because there was none attached. ;-)). now I'm working on a preview window in the list page... like Outlook.. just click the message and see the content.. a double click maximize the message... I think a preview pane is already included. and my last modification (for now) will be a way to throw the compose page add emails from contact list.. Not sure I understand. In general, if you want to provide a patch, make sure to open tickets on our trac (0) and make sure to provide one patch per issue/feature - not a giant patch. sorry about my english... if i'm not clear, please ask! Thanks for your work! Looking forward to your thoughts! Till _______________________________________________ List info: http://lists.roundcube.net/dev/

3 2

Re: [RCD] Dev Digest, Vol 4, Issue 26
by Andris Markevich 31 Oct '07

31 Oct '07

Hello. I agree, we can do like this, but physically it will be the same action but within another mail's body. In this case if we'll send all mail's within 1 mail's body we'll minimize load on the mail server but it's harder to code. It's on the author which approach to choose. Regards, Andris On Wed, 2007-10-31 at 12:00 -0700, dev-request(a)lists.roundcube.net wrote: > Date: Wed, 31 Oct 2007 16:06:07 +0100 > From: "Michael Tobler" <TheTrueBorg(a)gmx.de> > Subject: Re: [RCD] Patch for new features > To: dev(a)lists.roundcube.net > Message-ID: <20071031150607.294740(a)gmx.net> > Content-Type: text/plain; charset="us-ascii" > > Hi > > I have an other suggestion for point 3) > Why not simply mark all Spam email, click a button and forward them as > attachment (no header loss) to an address (like spam(a)example.com) > where sa-learn or some other scripts is run only over all attachments? > > In this way we do not need a special Forward, but just a button spam. > After forwarding all marked mails can be moved to the local Junk > folder. > > Best, > Michael _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Fwd: Patch for new features
by Marcelo Salhab Brogliato 30 Oct '07

30 Oct '07

---------- Forwarded message ---------- From: Marcelo Salhab Brogliato <msbrogli(a)gmail.com> Date: Oct 27, 2007 1:32 PM Subject: Re: [RCD] Patch for new features To: till <klimpong(a)gmail.com> Hello till, I don't have svn installed in the shell that I'm working on.. but I already sent an email asking for instalation! Soon I'll send my first patch :)) About the last feature that I sad: Let's get a situation: you are on the compose page writing some email.. so you wan't to see the address book to add more recipients. When you click Address Book, you "lost" your email (you can save in the draft)... Does you guys have a patch to solve this? Thanks for your help Salhab On 10/27/07, till <klimpong(a)gmail.com > wrote: > > Hi Salhab, > > no problem, but please CC the list, so others learn from this. :) > > Basically the best way is the following: > > 1) Get latest code from SVN (trunk) > 2) Migrate all your changes in there, test > 3) Create patches using "svn diff > feature.patch" > > Till > > On 10/27/07, Marcelo Salhab Brogliato <msbrogli(a)gmail.com> wrote: > > Hi Till, > > > > that's my first contribution to open source projects... I'm completelly > a > > newbie! :)) > > How can I create a patch? I have no idea... > > I think it isn't just attaching the files that I changed.. > > Maybe a CHANGELIST? Or a little tutorial with the codes and where they > > should be inserted? > > > > What do you mean by "configurable"? The name of the folders are fixed by > > now.. but a little > > change in the source make it user-defined :) > > > > Thanks for your answer. > > Salhab > > > > > > > > On 10/27/07, till <klimpong(a)gmail.com> wrote: > > > Hi Salhab, > > > > > > On 10/27/07, Marcelo Salhab Brogliato < msbrogli(a)gmail.com> wrote: > > > > Hi to everyone, > > > > I'm new to the list and working on RoundCube.. but I changed him a > > little to > > > > satisfy my needs. > > > > I implemented 3 features that you can check at: > > > > http://www.vialink.com.br/webmail4/ > > > > email: msbrogli2(a)vialink.com.br > > > > password: 123456 > > > > > > > > Essentially, it is: > > > > * a checkbox at the left... to make the life of the ones who aren't > > > > familiarized with AJAX (in my case, my customers) easier... > > > > so, they can easily select more than a message.. > > > > > > I thought there were discussions already and I don't think this will > > > make its way into the source. The reason is - we aim to provide a > > > desktop-like look and feel.I don't see checkboxes in Outlook, Eudora, > > > Thunderbird or kMail. > > > > > > > * a droplist to move selected messages between the folders > > > > * 2 buttons called SPAM and NO-SPAM.. they move the message to the > > folders > > > > Spam and No-Spam... but why? > > > > because I developed a script to periodically check that folders > and > > train > > > > spamassassin to work better... > > > > > > Not a bad idea. Are the folders configurable? (I obviously haven't > > > check your patch yet, because there was none attached. ;-)). > > > > > > > now I'm working on a preview window in the list page... like > Outlook.. > > just > > > > click the message and see the content.. > > > > a double click maximize the message... > > > > > > I think a preview pane is already included. > > > > > > > and my last modification (for now) will be a way to throw the > compose > > page > > > > add emails from contact list.. > > > > > > Not sure I understand. > > > > > > In general, if you want to provide a patch, make sure to open tickets > > > on our trac (0) and make sure to provide one patch per issue/feature - > > > > not a giant patch. > > > > > > > > > > sorry about my english... if i'm not clear, please ask! > > > > > > > > > > Thanks for your work! Looking forward to your thoughts! > > > > > > Till > _______________________________________________ List info: http://lists.roundcube.net/dev/

5 9

Re: [RCD] Right-to-Left Layout
by Ossama Khayat 30 Oct '07

30 Oct '07

As I pointed earlier the best solution would be to use a separate .css file the RTL language(s), which includes Arabic, Hebrew, Persian, Urdu and maybe others. - Ossama ----- Original Message ---- From: Robin Elfrink <elfrink(a)introweb.nl> To: RoundCube Development Mailing List <dev(a)lists.roundcube.net> Sent: Tuesday, October 30, 2007 2:43:04 PM Subject: Re: [RCD] Right-to-Left Layout Hi all, Attached is my first idea of how to implement right-to-left layouts. My native language is left-to-right, so I cannot help develop this further. Work is needed on image stuff as well. I haven't investigated, but probably most image-problems with rtl languages come from background images that should be moved to the other side. Maybe an include of a 'rtl.css' that overrides background settings will do? Robin --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Ur/SjPNsK7C/rtl.20071030-1235.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Right-to-Left Layout
by Mohammad Ebrahim Mohammadi Panah 30 Oct '07

30 Oct '07

I think it is a design decision and shouldn't be done by me, but the RoundCube designers. Anyway I searched about implementing support of RTL languages in web applications, especially PHP. Here are a few useful links: RTL support in WordPress 2.1: http://boren.nu/archives/2007/01/07/rtl-support-in-wordpress-21/ RTL in HTML, XHTML, CSS2, CSS3: http://www.i18nguy.com/markup/right-to-left.html Language information and text direction (part of HTML 4.01 specification): http://www.w3.org/TR/html401/struct/dirlang.html I think this is the simplest idea: Set a global variable in a locale-dependent file which shows this locale is RTL. Then use it wherever a 'dir="RTL"' attribute is needed. Anyway it is up to designers to decide upon this. On 10/8/07, Thomas Bruederli <roundcube(a)gmail.com> wrote: > > Mohammad Ebrahim Mohammadi Panah wrote: > > Hello, > > I got the latest code from Subversion and tested it to see how it looks > > in Persian. RoundCube seems to have no support for right-to-left > > languages such as Persian and Arabic. It didn't change the layout to > > right-to-left when I chose Persian or Arabic. Please correct me if I'm > > wrong. > > Is there any plan to implement it? > > > Somebody once announced to implement this but I've never heard again from > that person. This has to be done by somebody who is familiar with > right-to-left websites and the Persian or Arabic language. All of your > developers are either American or European and have no idea about RTL > websites. > > You are very welcome to contribute the changes that are necessary for > this. > > Regards, > ~Thomas > -- Mohammad Ebrahim Mohammadi Panah _______________________________________________ List info: http://lists.roundcube.net/dev/

3 2

Re: [RCD] Right-to-Left Layout
by Ossama Khayat 27 Oct '07

27 Oct '07

If you want to quickly test using RTL and changing the page direction, you can right-click the RC window (in FireFox) and choose "Switch Page Direction" to see how it looks. The perfect solution IMHO would be: 1. Use a common.css file that defined the main stuff common to all languages or maybe including the whole thing. 2. Use a special .css file for RTL languages which would overwrite what is needed, like (align, float, padding-left, margin-left... etc) and change them as appropriate. With little change we can also allow the user to choose display the folders left, right or left, when the page's direction is switched as maybe just like an additional feature. Just my 2c - Ossama ----- Original Message ---- From: till <klimpong(a)gmail.com> To: Mohammad Ebrahim Mohammadi Panah <mebrahim(a)gmail.com> Cc: RoundCube Development Mailing List <dev(a)lists.roundcube.net> Sent: Saturday, October 27, 2007 5:09:44 PM Subject: Re: [RCD] Right-to-Left Layout On 10/27/07, Mohammad Ebrahim Mohammadi Panah <mebrahim(a)gmail.com> wrote: > I think it is a design decision and shouldn't be done by me, but the > RoundCube designers. What Thomas was suggesting is - neither of us uses a RTL language. So demand and interest are next to 0 right now. So unless you come forward with a patch or find someone who is interested in contributing this, it WILL NOT get done. :) > Anyway I searched about implementing support of RTL languages in web > applications, especially PHP. Here are a few useful links: > > RTL support in WordPress 2.1: > http://boren.nu/archives/2007/01/07/rtl-support-in-wordpress-21/ > RTL in HTML, XHTML, CSS2, CSS3: > http://www.i18nguy.com/markup/right-to-left.html > Language information and text direction (part of HTML 4.01 specification): > http://www.w3.org/TR/html401/struct/dirlang.html > > I think this is the simplest idea: > Set a global variable in a locale-dependent file which shows this locale is > RTL. Then use it wherever a 'dir="RTL"' attribute is needed. > Anyway it is up to designers to decide upon this. Can you summarize this? Do we just need to adjust the CSS for this to work,or what's the catch? (I read the wordpress-related post but it didn't say.) If you need to contribute language files, you could go ahead as well. Requires next to zero programming skills. http://translator.roundcube.net/ Till _______________________________________________ List info: http://lists.roundcube.net/dev/ __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Fwd: Right-to-Left Layout
by till 27 Oct '07

27 Oct '07

Let me just forward this to the list so maybe someone else can pick up. This could be done pretty fast then. I don't think we have many images with text anyway. I am thinking that instead of folders for LTR, this could be either a seperate default skin. Less complex this way, etc.. Feedback? Ideas? On 10/27/07, NetOne - Doichin Dokov <root(a)net1.cc> wrote: > till ??????: > > Can you summarize this? Do we just need to adjust the CSS for this to > > work,or what's the catch? (I read the wordpress-related post but it > > didn't say.) > > > Besides CSS, some images also will need to be mirrored horizontally, so > basically there will be LTR and RTL folders for images, if this should > get done. I was recently looking into a clients side using Joomla, and > was wondering what those two LTR and RTL folders are. > > _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev October 2007