Dev October 2007

dev@lists.roundcube.net

44 participants
45 discussions

Re: [RCD] Patch for new features
by till 27 Oct '07

27 Oct '07

Hi Salhab, no problem, but please CC the list, so others learn from this. :) Basically the best way is the following: 1) Get latest code from SVN (trunk) 2) Migrate all your changes in there, test 3) Create patches using "svn diff > feature.patch" Till On 10/27/07, Marcelo Salhab Brogliato <msbrogli(a)gmail.com> wrote: > Hi Till, > > that's my first contribution to open source projects... I'm completelly a > newbie! :)) > How can I create a patch? I have no idea... > I think it isn't just attaching the files that I changed.. > Maybe a CHANGELIST? Or a little tutorial with the codes and where they > should be inserted? > > What do you mean by "configurable"? The name of the folders are fixed by > now.. but a little > change in the source make it user-defined :) > > Thanks for your answer. > Salhab > > > > On 10/27/07, till <klimpong(a)gmail.com> wrote: > > Hi Salhab, > > > > On 10/27/07, Marcelo Salhab Brogliato <msbrogli(a)gmail.com> wrote: > > > Hi to everyone, > > > I'm new to the list and working on RoundCube.. but I changed him a > little to > > > satisfy my needs. > > > I implemented 3 features that you can check at: > > > http://www.vialink.com.br/webmail4/ > > > email: msbrogli2(a)vialink.com.br > > > password: 123456 > > > > > > Essentially, it is: > > > * a checkbox at the left... to make the life of the ones who aren't > > > familiarized with AJAX (in my case, my customers) easier... > > > so, they can easily select more than a message.. > > > > I thought there were discussions already and I don't think this will > > make its way into the source. The reason is - we aim to provide a > > desktop-like look and feel.I don't see checkboxes in Outlook, Eudora, > > Thunderbird or kMail. > > > > > * a droplist to move selected messages between the folders > > > * 2 buttons called SPAM and NO-SPAM.. they move the message to the > folders > > > Spam and No-Spam... but why? > > > because I developed a script to periodically check that folders and > train > > > spamassassin to work better... > > > > Not a bad idea. Are the folders configurable? (I obviously haven't > > check your patch yet, because there was none attached. ;-)). > > > > > now I'm working on a preview window in the list page... like Outlook.. > just > > > click the message and see the content.. > > > a double click maximize the message... > > > > I think a preview pane is already included. > > > > > and my last modification (for now) will be a way to throw the compose > page > > > add emails from contact list.. > > > > Not sure I understand. > > > > In general, if you want to provide a patch, make sure to open tickets > > on our trac (0) and make sure to provide one patch per issue/feature - > > not a giant patch. > > > > > > > sorry about my english... if i'm not clear, please ask! > > > > > > > Thanks for your work! Looking forward to your thoughts! > > > > Till _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Patch for new features
by Marcelo Salhab Brogliato 27 Oct '07

27 Oct '07

Hi to everyone, I'm new to the list and working on RoundCube.. but I changed him a little to satisfy my needs. I implemented 3 features that you can check at: http://www.vialink.com.br/webmail4/ email: msbrogli2(a)vialink.com.br password: 123456 Essentially, it is: * a checkbox at the left... to make the life of the ones who aren't familiarized with AJAX (in my case, my customers) easier... so, they can easily select more than a message.. * a droplist to move selected messages between the folders * 2 buttons called SPAM and NO-SPAM.. they move the message to the folders Spam and No-Spam... but why? because I developed a script to periodically check that folders and train spamassassin to work better... now I'm working on a preview window in the list page... like Outlook.. just click the message and see the content.. a double click maximize the message... and my last modification (for now) will be a way to throw the compose page add emails from contact list.. sorry about my english... if i'm not clear, please ask! Salhab _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Russian Localization
by Artur Smolkin 25 Oct '07

25 Oct '07

Hello everybody! I have updated russian localization for RoundCube Webmail. Changes: added translation for $labels['movemessagetotrash'] It can be downloaded here: http://dev.roundcube.ru/download/localization/russian/26102007.zip -- Regards, Artur Smolkin, RoundCube.Ru _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Firefox login bug [Ticket #1484639] [SOLVED]
by Andris Markevich 25 Oct '07

25 Oct '07

Hello. Yesterday I've made clean install of the latest RC2 and found interesting issue - I was unable to login via Firefox. Entering correct login/pass roundcube were redirecting me back to the login page. IE/Opera were working perfectly. After some research I've discovered that it was the bug with the cookie handling mechanism in the Roundcube. Some browsers understand multiple cookie setting in one session but it's breaking the idea of cookies. IE/Opera does handle but Firefox is one of them which do not handle such situations. If you'll check Firefox cache after login try you'll see 2 cookies with the same name and this is the main problem - Firefox can't decide which one to use :) and doesn't use anyone. In the sess_regenerate_id() you are setting new session id via cookie but previous definition already cached in the output buffer which was set by session_start() function. It's not recommended to do this because cookies do not overwrite previous instances but appends headers with new value. First of all you should delete previous cookie and than set new one. Here is patch. --- roundcubemail-0.1-rc2/program/include/session.inc +++ roundcube_my/program/include/session.inc @@ -173,6 +173,7 @@ session_id($random); $cookie = session_get_cookie_params(); + setcookie(session_name(), "", time() -3600); setcookie(session_name(), $random, $cookie['lifetime'], $cookie['path']); return true; P.S. In then near future I'm planning to revise russian, latvian localization. I saw that Artur Smolkin made some updates but just in case we'll check if something is missing or incorrect. P.S.S. Also it is possible to translate documentation to russian and latvian if you need. Regards, Andris _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Arabic Translation
by Ossama Khayat 24 Oct '07

24 Oct '07

Hi, Attached is the updated Arabic translation for 0.1RC2 regards, Ossama Khayat __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/ad/3Y7pOLhF/arabic.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Adding additional mailboxes
by Markus Eder 24 Oct '07

24 Oct '07

Hi Dev-Team, think I got a great idea how to improve RC. I have a cyrus imap server with some mailboxes. RC works fine with it. The only thing I'm missing is the possibility to add an additional mailbox or mailbox folder of another user. Using ACLs it is very simple to give different users different rights to one or more mailboxes (mailbox folders). So, my idea is to add a feature which allows a logged in user in RC to add another mailbox folder via settings | folders. For example just typing in user.another-mailbox.folder in the input field which sets the new folders name. I'm not very experienced with PHP's IMAP extension, but eventually it is possible to simply use the current logon credentials for authentication required by additional mailboxes. With this feature people could use "Shared folders" with RC just by asking their admin about the correct mailbox storage name (e.g. user.another-mailbox.*). Would be a pleasure if you think about it. Kind Regards, Markus _______________________________________________ List info: http://lists.roundcube.net/dev/

3 3

Weird problem with ldap search (case)
by Harold Aling 24 Oct '07

24 Oct '07

Dear RC devs, I have a weird problem with searching my LDAP addressbook... A search results in displaying 'display name' in either the result list, or in the detail iframe??? In my main.inc.php I've defined the display name: 'name_field' => 'displayName', Changing it to 'displayname' will result in a correct display in the details iframe, but the names don't show up in the result list anymore... :( I've patched program/include/rcube_ldap.inc to be case-insensitive, but that's a really bad way to tackle this... Index: program/include/rcube_ldap.inc =================================================================== --- program/include/rcube_ldap.inc (revision 903) +++ program/include/rcube_ldap.inc (working copy) @@ -428,6 +428,8 @@ { if ($rec[$lf]['count']) $out[$rf] = $rec[$lf][0]; + if ($rec[strtolower($lf)]['count']) + $out[$rf] = $rec[strtolower($lf)][0]; } return $out; Does anybody else have the same weird bug or is it only me??? -H- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Roundcube breaks GPG
by Ben 23 Oct '07

23 Oct '07

Noticing a strange phenomenon with the latest SVN of RC, when you send a GPG-encoded message from RC it gets corrupted. It looks like each line of the coding is "double spaced"-- extra linefeeds get inserted. I've never had this happen with any other email/webmail clients. I'd like to submit a patch to allow GPG to work as it's quite useful, but I've been going over the code and I can't find why this is happening--I'm assuming it's something in sendmail.inc, I just can't put my finger on it. Can anybody offer any assistance? Thanks, Ben _______________________________________________ List info: http://lists.roundcube.net/dev/

2 2

Russian Localization
by Artur Smolkin 21 Oct '07

21 Oct '07

Hello, everybody. I just made russian localization with all labels translated. It can be downloaded from http://www.roundcube.ru/download/install/russian.zip -- Regards, Artur Smolkin, RoundCube.Ru _______________________________________________ List info: http://lists.roundcube.net/dev/

1 1

Short patch to select the default domain, depending on the url
by Jens Brey 21 Oct '07

21 Oct '07

Hi all, i wrote a short patch, to select the default host, depending on the url. If you have one roundcube installation for some domains, you have the problem, if you enters the login page, you can see another domain in the select box as the domain you wrote in the uri. My patch checks the domain in the uri, and if there is the same domain in the select box, selects them as default. Regards, Jens --- program/include/rcmail_template.inc 2007-09-19 08:48:18.000000000 +0200 +++ program/include/rcmail_template.inc 2007-10-21 16:26:53.000000000 +0200 @@ -822,8 +822,17 @@ foreach ($CONFIG['default_host'] as $key => $value) { + if ( $key == $_SERVER["HTTP_HOST"]) + $select_host->add($value, (is_numeric($key) ? $value : $key)); + } + + foreach ($CONFIG['default_host'] as $key => $value) + { if (!is_array($value)) - $select_host->add($value, (is_numeric($key) ? $value : $key)); + { + if ($key != $_SERVER["HTTP_HOST"] ) + $select_host->add($value, (is_numeric($key) ? $value : $key)); + } else { unset($select_host); _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev October 2007