Dev November 2007

dev@lists.roundcube.net

29 participants
26 discussions

Session handler with custom session-methods are not thread-safe.
by Micha 15 Nov '07

15 Nov '07

Hi to all. I discovered a problem with the login, where after some logins and logouts, every new Login-Attempt kicked me back to the login screen. Without any mention of a problem in the logs. I searched the forum and found that some users experienced similar problems. After some debugging I found the weak point. The problem is, that the sess_read and sess_write methods that are used during logout and also used from the periodical mail checking process, are not "synchronized" (thread-safe). So it is possible that the two events occur at the same time: The events occur in the following order: 1. Logout calls sess_read 2. Periodical Mail Check calls sess_read 3. Logout calls sess_write (with $vars (temp|b:1)) 4. Periodical Mail Check calls sess_write ($vars without temp) Step 4 ("mail check") overwrites the Session-Parameters from Step 3 ("logout"). The concrete problem in this case is the temp-Parameter. Next login, session_start reads in the session parameter, where "temp" must be true, to start a new session. Otherwise when ("temp" == false), roundcube expects a valid session and tries to resume that session. (In index.php $_SESSION['temp'] will be checked but fails.) The only way a new login is possible, is to reset the cookies (restart IE and delete cookies in Firefox). >From my point of view, the session handlers (session_start(), session_destroy() and session_regenerate_id()) must be atomic. So the session handler must have exclusive access to the custom session methods in session.inc. Micha. _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Filters Patch
by emi＠algorismia.com 15 Nov '07

15 Nov '07

Hi all!! Here is the filter patch. There are some differences between the svn copy I took last week and the one I did the patch diff with, but I think these are minor changes. If finally you want the gziped src (not patched), tell me. Take a look!! emi --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Yk/KCtBesrs/RC_Filters_patch.txt.gz Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Diff'ing filters
by emi＠algorismia.com 15 Nov '07

15 Nov '07

Hi!! Thomas said me to use 'svn diff' to make the filters patch, but with this option new files are not taken. How can I add them into the patch? Or just add the patch & new files into a .tar.gz? Thanks for all! emi _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Re: [RCD] Filters
by markevich＠inbox.lv 14 Nov '07

14 Nov '07

Hello, Emi. I completely agree with Michael, that there are a lot of implementation questions that are not so easily solvable. You should always take in mind that Roundcube is only a client and use filters on all content only in it is not right way to do. All mails are stored on the IMAP server and all filtering should be done there also. Just imagine, not all users check there mails every day or keeping mail client open all the time, it’s normal to have 100 unread messages, so filter should be run at least at the startup causing peak loads on the server (web+imap) and how do you plan to check existing mails for filtering ( was filters applied to this message or no? ) I think that you are heading to the wrong direction. I’m planning to implement my own filters but I will do it in a bit different way. I would create independent table for storing filter data and new preference page would be created for filter management. That’s all that goes for web related stuff. Than external script will be created (for ex. perl) which will fetch data from the table and convert it to the according MDA (mail delivery agent) format for the according mailbox. Such scheme is necessary because not always (in real environment the percentage is about 70-80%) IMAP server with all mailboxes resides on the same file system as Roundcube. In my case they reside on a different machines and I’m unable to access directly mailboxes from the Roundcube. So we have external script that will run for ex. from cron job to generate MDA scripts for mail transferring from the filter table data. All parsing will spread across the working time without any peak loads. I suppose we could cooperate on this task and maybe something usable come out of it. Everything that written above is my IMHO and shouldn’t be taken personally, just FYI. Regards, Andris > From: emi(a)algorismia.com > Subject: [RCD] Filters > To: dev(a)lists.roundcube.net > Message-ID: > Content-Type: text/plain;charset=iso-8859-1 > > Hi there!! > I've made a filters function (in early version) for roundcube. I've > done over the svn version of last week. The modifications uses a new > SQL table, filters, wich can be filled as done with identities. Then it > filters messages using this filters, on rcmail_js_message_list and > rcmail_message_list. > > I've seen some discussion on why not to do it, if doing internally or > with sieve or with .forward or so. Look, I've done this, then we can > update to permit select the filtering system from configuration. From > now, we have internal filters. > I think that this is a very earlier version and that can be much more > developed. But it runs ok! > Well, my problem is that I don't know so much on using svn. If some one > can tell me how can I 'upload' the work without disturbing anybody... > Comments and discussions about this are welcome. > Thanks a lot!!! > emi -- Tavs bezmaksas pasts Inbox.lv Regards, Andris _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Indonesian (Bahasa Indonesia) Language Translation Update
by klunxer 14 Nov '07

14 Nov '07

Hi all, I already updating the language translation for Bahasa Indonesia. Please check the attachment and feel free to give some corrections. Best Regards, Arya --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/4H/NEi5E0xk/id_ID.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Filters
by emi＠algorismia.com 13 Nov '07

13 Nov '07

Hi there!! I've made a filters function (in early version) for roundcube. I've done over the svn version of last week. The modifications uses a new SQL table, filters, wich can be filled as done with identities. Then it filters messages using this filters, on rcmail_js_message_list and rcmail_message_list. I've seen some discussion on why not to do it, if doing internally or with sieve or with .forward or so. Look, I've done this, then we can update to permit select the filtering system from configuration. From now, we have internal filters. I think that this is a very earlier version and that can be much more developed. But it runs ok! Well, my problem is that I don't know so much on using svn. If some one can tell me how can I 'upload' the work without disturbing anybody... Comments and discussions about this are welcome. Thanks a lot!!! emi _______________________________________________ List info: http://lists.roundcube.net/dev/

4 6

IMAP
by I J 12 Nov '07

12 Nov '07

Hi guys, it seems like the forums are pretty much dead so I'll get my help from here, I configured everything ran the script, seemed to work. The problem is, it continues to tell me "connect to IMAP server failed", my question is, do I have to type in the path to the IMAP in the main.inc.php file? Kind Regards. __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com _______________________________________________ List info: http://lists.roundcube.net/dev/

2 2

Roundcube Licensing question.
by I J 12 Nov '07

12 Nov '07

Hi, I was told by Brett to send you guys an email about the licensing question I had. Is their any possible way to purchase a copy of the roundcube script from you that isn't released under the GPL license? I'm willing to pay any reasonable price; the reason for the copy of the roundcube script not released under the GPL is to allow my company (Dynno.com coming soon) to be able to place our copyright on the script. Please be assured that your script won't be used for resale however, it will be used to provide email addresses to our members. Send me a reply if or if not this is possible, Best Regards. __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com _______________________________________________ List info: http://lists.roundcube.net/dev/

4 4

Re: [RCD] Roundcube Licensing question.
by till 11 Nov '07

11 Nov '07

On Nov 9, 2007 12:09 PM, I J <imageyourself(a)yahoo.com> wrote: > > no no, not my copyright on someone else's work, I must of miss-read the GPL > license but from what I understood was I can't place a site wide copyright > such as "(c) whatever.com; I give full credit to roundcube don't get me > wrong here. *please always copy the list* Basically, I don't get what keeps you from using RoundCube. GPL-code doesn't even require a public "powered by" etc., so what's the deal? Till _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Odd javascript problem - not working after attachment download
by Sam Bailey 07 Nov '07

07 Nov '07

Hi Guys (inc. Gals of course), I hope to be of more use of the next few months - but we'll see. I noticed that after downloading a non-pdf attachment via the link, none of the navigation buttons in RoundCube work. Seems as if the javascript gets disabled as it works if you refresh the page first. Occurs under Win(FF2, IE7, Safari3.0.1, Opera9.21), Linux(FF2, Prism0.8) Oh - using rc2 See: http://trac.roundcube.net/ticket/1484653 Much appreciated getting some help on this. Sam Bailey _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev November 2007