Dev March 2007

dev@lists.roundcube.net

32 participants
35 discussions

Quoted text not wrapping properly when converted from HTML to plain text
by Doug Mandell 28 Mar '07

28 Mar '07

Hi all, Some time ago I wrote to the list and reported a bug with regards to how quoted text was wrapping when the original email was HTML and the reply was in plain text (http://trac.roundcube.net/trac.cgi/ticket/1484141). With further investigation I discovered that this only seemed to happen when the line being wrapped was exactly equal to the maximum line length (75 characters, in compose.inc ($body = wordwrap($body, 75);)). To reproduce the I am *not* a programmer, so I know I'm not going to be able to do this the right way, but I do have Ilohamail kicking around and was able to look at how they do line wrapping, use their functions and get Roundcube wrapping HTML quoted text properly in plain text. I'm not sure how to contribute this because I know I've *totally* done this wrong, but I'm hoping someone can see what I've done, do it the right way and get it in SVN. Here's what I did: Prior to function rcmail_create_reply_body($body, $bodyIsHtml) in compose.inc (line 484) I added the following: function LangWrapLine($line, $width){ $line_len = strlen($line); $i = 0; //if line is less than width, we're good if ($line_len <= $width) return $line; for ($prev_i=0,$i=$width;$i<$line_len;$prev_i=$i,$i+=$width){ //extract last segment that is $width wide $chunk = substr($line, $prev_i, ($i-$prev_i))."\n"; //find last space in this chunk $last_space = strrpos($chunk, " "); $last_space = $prev_i + $last_space; if ($last_space==$prev_i){ //no space found in this chunk $next_space = strpos($line, " ", $i); if ($next_space!==false){ $i = $next_space; $line[$next_space] = "\n"; } }else{ //replace last space before width with newline $line[$last_space]="\n"; $i = $last_space; } } return $line; } function LangSmartWrap($body, $len){ $lines = explode("\n", $body); if (!is_array($lines)) return ""; while ( list($i,$line)=each($lines) ){ if (!ereg("^>", $line)) $lines[$i] = LangWrapLine(chop($line), $len); } return implode("\n", $lines); } which is almost an exact copy of the relevant functions out of Ilohamail. I then changed: $body = wordwrap($body, 75); on line 491 to: LangSmartWrap($body, 75); As I said, I know this isn't how it should be, but using the above functions everything works as it is supposed to.

1 0

Can roundcube support pop3?
by ding jianting 28 Mar '07

28 Mar '07

Hi, Can roundcube support pop3? Thanks for your great work. Tim -- ________________________________________ 中国开源客户关系管理系统: http://www.c3crm.com -----------------------------------------------------------------------

2 1

28 Mar '07

Hi, Attached patch shifts focus to the password field if 'enter' was pressed inside the username field. I would commit this without asking if I weren't concerned about wether I placed the new 'login form methods' block in the right place, and using the proper reference vars etc. Thomas, is this OK? Robin Index: program/js/app.js =================================================================== --- program/js/app.js (revision 521) +++ program/js/app.js (working copy) @@ -274,6 +274,8 @@ case 'login': var input_user = rcube_find_object('_user'); var input_pass = rcube_find_object('_pass'); + if (input_user) + input_user.onkeypress = function(e){ return rcmail.login_user_keypress(e); }; if (input_user && input_user.value=='') input_user.focus(); else if (input_pass) @@ -1627,6 +1629,34 @@ return null; }; + + + /*********************************************************/ + /********* login form methods *********/ + /*********************************************************/ + + this.init_login_form_events = function(obj) + { + var handler = function(e){ return ref.login_user_keypress(e,this); }; + + if (obj.addEventListener) + obj.addEventListener(bw.safari ? 'keydown' : 'keypress', handler, false); + else + obj.onkeydown = handler; + }; + + // handler for keyboard events on the _user field + this.login_user_keypress = function(e) + { + var key = document.all ? event.keyCode : document.getElementById ? e.keyCode : 0; + + // enter + if ((key==13) && (document.form._pass)) + { + document.form._pass.focus(); + return false; + } + }; /*********************************************************/

2 4

Does Roundcube support OpenLDAP
by Anita Chan 27 Mar '07

27 Mar '07

Dear Roundcube Dev, As subject, does it support OpenLDAP for address book look up. Thanks, ac

2 1

Reply and Reply To will not quote
by Steffen Torp 21 Mar '07

21 Mar '07

RC build 503, Opera 9.10, Linux 2.6.17: When using Reply or Reply all, original message is not quoted anymore, after checking out revision 503 of RC. Forward will still quote. Can anyone confirm whether this is a bug, or if it's just me? Regards, Steffen

3 2

Sanity check on main.inc
by Colin Alston 21 Mar '07

21 Mar '07

I used a generic config file for our hosts to read in the default domain portion automatically. However this lead to a fun time of getting \n characters in the domain added to the database. These things should probably be sanity checked for arb escape chars before being inserted, such as... patch main.inc 539,541c539,541 < $user, < $host, < $user_email, --- > str_replace("\n", '', $user), > str_replace("\n", '', $host), > str_replace("\n", '', $user_email), -- Colin Alston ~ http://www.karnaugh.za.net/ "There have been forums where, out of some misguided sense of hyper-courtesy, participants are banned from posting any fault-finding with another's posts, and told 'Don't say anything if you're unwilling to help the user.' The resulting departure of clueful participants to elsewhere causes them to descend into meaningless babble and become useless as technical forums." - Eric Steven Raymond

2 1

HTML email problem?
by Jason 21 Mar '07

21 Mar '07

I'm trying to test out sending an html email to myself using mutt, but it isn't showing up correctly in RC, at least it isn't what I would expect. Below is the source of the message. When I open it in roundcube the link "asdf" is colored blue, but I can't click on it. It appears to just be colored text. Is something wrong here? Thanks, Jason

2 1

Update to INSTALL
by jam＠qv90.de 21 Mar '07

21 Mar '07

Hi list, I would suggest to change some wordings in INSTALL. I stumbled over it and maybe it makes it easier to install for other users :-) --------------------------------------- * MySQL 4.1.x/5.x ----------------- For MySQL version 4.1 and up, it's recommended to create the database for RoundCube with utf-8 charset. Here's an example of the init procedure: # mysql > CREATE DATABASE 'roundcubemail' DEFAULT CHARACTER SET utf8 COLLATE utf8_genera > GRANT ALL PRIVILEGES ON roundcubemail.* TO roundcube@localhost IDENTIFIED BY 'password'; > quit NEW: 'password' is the master password for the roundcube user. It is strongly NEW: recommended you replace this with a more secure password. Please keep in NEW: mind: You need to specify this password later in 'config/db.inc.php'. # mysql roundcubemail < SQL/mysql5.initial.sql -------------------------------------------- Live long and prosper Florian http://www.qv90.de/

2 1

Persian Translation
by Anoosh 21 Mar '07

21 Mar '07

Hi That's the full Persian translation for RoundCube, I translated it using RoundCube (Live) Translator. Regards Ardnoosh --------------------------------- Now that's room service! Choose from over 150,000 hotels in 45,000 destinations on Yahoo! Travel to find your fit. <?php /* +-----------------------------------------------------------------------+ | language/_NEW_/labels.inc | | | | Language file of the RoundCube Webmail client | | Copyright (C) 2006, RoundQube Dev. - Switzerland | | Licensed under the GNU GPL | | | +-----------------------------------------------------------------------+ | Author: | +-----------------------------------------------------------------------+ */ $labels = array(); $labels['welcome'] = ' خوش آمدید $product به '; $labels['username'] = 'نام کلربر'; $labels['password'] = 'رمز عبور'; $labels['server'] = 'سرور'; $labels['login'] = 'ورود'; $labels['logout'] = 'خروج'; $labels['mail'] = 'ایمیل'; $labels['settings'] = 'تنظیمات شخصی'; $labels['addressbook'] = 'دفتر آدرس ها'; $labels['inbox'] = 'صندوق'; $labels['drafts'] = 'طرح ها'; $labels['sent'] = 'فرستاده شده'; $labels['trash'] = 'سطل آشغال'; $labels['junk'] = 'بدرد نخور'; $labels['subject'] = 'عنوان'; $labels['from'] = 'فرستنده'; $labels['to'] = 'گیرنده'; $labels['cc'] = 'کپی'; $labels['bcc'] = 'Bcc'; $labels['replyto'] = 'پاسخ به'; $labels['date'] = 'تاریخ'; $labels['size'] = 'حجم'; $labels['priority'] = 'اهمیت'; $labels['organization'] = 'طبقه بندی'; $labels['reply-to'] = 'پاسخ به'; $labels['mailboxlist'] = 'پوشه ها'; $labels['messagesfromto'] = '$count از $to به $from پیغام ها'; $labels['messagenrof'] = '$count پیغام از $nr'; $labels['moveto'] = '...انتقال به'; $labels['download'] = 'دانلود'; $labels['filename'] = 'نام فایل'; $labels['filesize'] = 'اندازه فایل'; $labels['preferhtml'] = 'HTML نمایش'; $labels['htmlmessage'] = 'HTML پیغام'; $labels['prettydate'] = 'روز های زیبا'; $labels['addtoaddressbook'] = 'افزودن به دفتر آدرس ها'; $labels['sun'] = 'یکشنبه'; $labels['mon'] = 'دوشنبه'; $labels['tue'] = 'سه شنبه'; $labels['wed'] = 'چهارشنبه'; $labels['thu'] = 'پنجشنبه'; $labels['fri'] = 'جمعه'; $labels['sat'] = 'شنبه'; $labels['sunday'] = 'یکشنبه'; $labels['monday'] = 'دوشنبه'; $labels['tuesday'] = 'سه شنبه'; $labels['wednesday'] = 'چهارشنبه'; $labels['thursday'] = 'پنجشنبه'; $labels['friday'] = 'جمعه'; $labels['saturday'] = 'شنبه'; $labels['today'] = 'امروز'; $labels['checkmail'] = 'بررسی برای پیغام های جدید'; $labels['writenewmessage'] = 'ساخت پیغام جدید'; $labels['replytomessage'] = 'پاسخ به پیغام'; $labels['replytoallmessage'] = 'پاسخ به فرستنده وتمام گیرنده ها'; $labels['forwardmessage'] = 'ارجاع پیغام'; $labels['deletemessage'] = 'انتقال پیغام به سطل آشغال'; $labels['printmessage'] = 'چاپ این پیغام'; $labels['previousmessage'] = 'نمایش پیغام قبلی'; $labels['previousmessages'] = 'نمایش سری قبلی پیغام ها'; $labels['firstmessage'] = 'نمایش اولین پیغام'; $labels['firstmessages'] = 'نمایش اولین سری پیغام ها'; $labels['nextmessage'] = 'نمایش پیغام بعدی'; $labels['nextmessages'] = 'نمایش سری بعدی پیغام ها'; $labels['lastmessage'] = 'نمایش آخرین پیغام'; $labels['lastmessages'] = 'نمایش آخری نسری پیغام ها'; $labels['backtolist'] = 'بازگشت به فهرست پیغام ها'; $labels['viewsource'] = 'نمایش منبع'; $labels['select'] = 'انتخاب'; $labels['all'] = 'همه'; $labels['none'] = 'هیچ'; $labels['unread'] = 'باز نشده'; $labels['compact'] = 'فشرده'; $labels['empty'] = 'خالی'; $labels['purge'] = 'خرد کردن'; $labels['quota'] = 'فضای استفاده شده'; $labels['unknown'] = 'نا شناخته'; $labels['unlimited'] = 'نا محدود'; $labels['quicksearch'] = 'جستجوی سریع'; $labels['resetsearch'] = 'شروع دوباره جستجو'; $labels['compose'] = 'نوشتن پیغام'; $labels['sendmessage'] = 'ارسال پیغام همین الان'; $labels['savemessage'] = 'ذخیره این طرح'; $labels['addattachment'] = 'ضمیمه فایل'; $labels['charset'] = 'سری کارکترها'; $labels['editortype'] = 'نوع ویرایشگر'; $labels['returnreceipt'] = 'پیغام بازگشت'; $labels['checkspelling'] = 'چک کردن حرف ها'; $labels['resumeediting'] = 'ادامه ویرایش'; $labels['revertto'] = 'برگرداندن به'; $labels['attachments'] = 'ضمایم'; $labels['upload'] = 'آپلود'; $labels['close'] = 'بستن'; $labels['low'] = 'پایین'; $labels['lowest'] = 'پایین ترین'; $labels['normal'] = 'معمولی'; $labels['high'] = 'بالا'; $labels['highest'] = 'بالاترین'; $labels['nosubject'] = '(بدون موضوع)'; $labels['showimages'] = 'نمایش عکس ها'; $labels['htmltoggle'] = 'HTML'; $labels['plaintoggle'] = 'متن خالی'; $labels['name'] = 'نمایش نام'; $labels['firstname'] = 'نام'; $labels['surname'] = 'نام خانوادگی'; $labels['email'] = 'ایمیل'; $labels['addcontact'] = 'افزودن به دفتر آدرس ها'; $labels['editcontact'] = 'تغییر در دفتر آدرس ها'; $labels['edit'] = 'ویرایش'; $labels['cancel'] = 'فسخ'; $labels['save'] = 'ذخیره'; $labels['delete'] = 'حذف'; $labels['newcontact'] = 'ساخت کارت تماس جدید'; $labels['deletecontact'] = 'حذف تماس های انتخاب شده'; $labels['composeto'] = 'ارسال نامه به'; $labels['contactsfromto'] = '$count از $to به $from تماس ها '; $labels['print'] = 'چاپ'; $labels['export'] = 'خارج کردن'; $labels['previouspage'] = 'نمایش سری قبلی'; $labels['firstpage'] = 'نمایش سری اول'; $labels['nextpage'] = 'نمایش سری بعدی'; $labels['lastpage'] = 'نمایش سری آخر'; $labels['ldapsearch'] = 'جستجوی دایرکتوری'; $labels['ldappublicsearchname'] = 'نام تماس'; $labels['ldappublicsearchtype'] = 'کاملا جور؟'; $labels['ldappublicserverselect'] = 'انتخاب سرورها'; $labels['ldappublicsearchfield'] = 'جستجو در'; $labels['ldappublicsearchform'] = 'جستجو برای تماس'; $labels['ldappublicsearch'] = 'جستجو'; $labels['settingsfor'] = 'تنظیمات برای'; $labels['preferences'] = 'گزینه ها'; $labels['userpreferences'] = 'گزینه های کاربر'; $labels['editpreferences'] = 'ویرایش گزینه های کاربر'; $labels['identities'] = 'شناسه ها'; $labels['manageidentities'] = 'مدیریت شناسه ها برای این حساب'; $labels['newidentity'] = 'شناسه جدید'; $labels['newitem'] = 'ساخت شی'; $labels['edititem'] = 'ویرایش شی'; $labels['setdefault'] = ' تنظیم به عنوان انتخاب همیشگی'; $labels['language'] = 'زبان'; $labels['timezone'] = 'محدوده زمانی'; $labels['pagesize'] = 'ستون ها برای هر صفحه'; $labels['signature'] = 'امضا'; $labels['dstactive'] = 'ساعت تابستانی'; $labels['htmleditor'] = 'HTML ساخت پیغام'; $labels['htmlsignature'] = 'HTML امضا'; $labels['previewpane'] = 'نشان دادن تکه نمایش'; $labels['autosavedraft'] = 'ذخیره خود به خودی طرح'; $labels['everynminutes'] = ' دقیقه $n هر'; $labels['never'] = 'هرگز'; $labels['folder'] = 'پوشه'; $labels['folders'] = 'پوشه ها'; $labels['foldername'] = 'نام پوشه'; $labels['subscribed'] = 'ثبت شده'; $labels['create'] = 'ساخت'; $labels['createfolder'] = 'ساخت پوشه جدید'; $labels['rename'] = 'تغییر نام'; $labels['renamefolder'] = 'تغییر نام پوشه'; $labels['deletefolder'] = 'حذف پوشه'; $labels['managefolders'] = 'مدیریت پوشه ها'; $labels['sortby'] = 'طبقه بندی بر اساس'; $labels['sortasc'] = 'طبقه بندی صعودی'; $labels['sortdesc'] = 'طبقه بندی نزولی'; ?> <?php /* +-----------------------------------------------------------------------+ | language/_NEW_/messages.inc | | | | Language file of the RoundCube Webmail client | | Copyright (C) 2006, RoundQube Dev. - Switzerland | | Licensed under the GNU GPL | | | +-----------------------------------------------------------------------+ | Author: | +-----------------------------------------------------------------------+ */ $messages = array(); $messages['loginfailed'] = 'ورود ناموفق بود'; $messages['cookiesdisabled'] = 'مرورگر شما کوکی قبول نمی کند'; $messages['sessionerror'] = 'زمان ورود شما اشتباه و یا منقضی'; $messages['imaperror'] = 'نا موفق بود IMAPاتصال به سرور'; $messages['nomessagesfound'] = 'هیچ پیغامی در صندوق پستی پیدا نشد'; $messages['loggedout'] = 'شما با موفقیت برنامه را بستید ، به امید دیدار'; $messages['mailboxempty'] = 'صندوق پستی خالی است'; $messages['loading'] = '... در حال بارگداری'; $messages['loadingdata'] = '... در حال بارگداری اطلاعات'; $messages['checkingmail'] = '... بررسی برای پیغام های جدید'; $messages['sendingmessage'] = '... در حال ارسال پیغام'; $messages['messagesent'] = 'پیغام با موفقیت فرستاده شد'; $messages['savingmessage'] = '... درحال ذخیره پیغام ها'; $messages['messagesaved'] = 'پیغام در قسمت طرح ها ذخیره شد'; $messages['successfullysaved'] = 'با موفقیت ذخیره شد'; $messages['addedsuccessfully'] = 'تماس با موفقیت به دفتر آدرس ها اضافه شد'; $messages['contactexists'] = 'یک تماس با این آدرس ایمیل از قبل وجود دارد'; $messages['blockedimages'] = 'برای حفاظت ازاطلاعات شما ، عکس های روی اینترنت فیلتر شد'; $messages['encryptedmessage'] = '!این یک پیغام کد شده است و قابل نمایش نمی باشد ، ببخشید'; $messages['nocontactsfound'] = 'هیج تماسی پیدا نشد'; $messages['sendingfailed'] = 'نا موفق در فرستادن پیغام'; $messages['errorsaving'] = 'یک اشکال در زمان ذخیره پیش آمد'; $messages['errormoving'] = 'پیغام منتقل نشد'; $messages['errordeleting'] = 'پیغام پاک نشد'; $messages['deletecontactconfirm'] = 'آیا واقعا می خواهید تماس (های) انتخاب شده را پاک کنید ؟'; $messages['deletemessagesconfirm'] = 'آیا واقعا می خواهید پیغام (های) انتخاب شده را پاک کنید ؟'; $messages['deletefolderconfirm'] = 'آیا واقعا می خواهید این پوشه را پاک کنید ؟'; $messages['purgefolderconfirm'] = 'آیا واقعا می خواهید همه پیغام ها در این پوشه را پاک کنید ؟'; $messages['formincomplete'] = 'فرم کاملا پر نشده بود'; $messages['noemailwarning'] = 'لطفا بک آدرس ایمیل درست وارد کنید'; $messages['nonamewarning'] = 'لطفا یک نام وارد کنید'; $messages['nopagesizewarning'] = 'لطفا اندازه صفحه وارد کنید'; $messages['norecipientwarning'] = 'لطفا حداقل یک گیرنده وارد کنید'; $messages['nosubjectwarning'] = 'قسمت "عنوان" خالی است ، آیا می خواهید یک عنوان وارد کنید ؟'; $messages['nobodywarning'] = 'ارسال این پیغام بدون متن ؟'; $messages['notsentwarning'] = 'پیغام ارسال نشد ، آیا می خواهید پیغام را از بین ببرید ؟'; $messages['noldapserver'] = 'برای جستجو انتخاب کنید Ldapلطفا یک سرور '; $messages['nocontactsreturned'] = 'هیچ تماسی پیدا نشد'; $messages['nosearchname'] = 'لطفا نام یک تماس و یا یک آدرس ایمیل وارد کنید'; $messages['searchsuccessful'] = ' پیغام پیدا شد $nr'; $messages['searchnomatch'] = 'جستجو هیچ نتیجه ای نداشت'; $messages['searching'] = '...در حال جستجو'; $messages['checking'] = '...در حال بررسی'; $messages['nospellerrors'] = 'هیچ اشکال املایی پیدا نشد'; $messages['folderdeleted'] = 'پوشه با موفقیت پاک شد'; $messages['deletedsuccessfully'] = 'حذف انجام شد'; $messages['converting'] = '... در حال پاک کردن تنظیمات متنی از پیغام'; $messages['messageopenerror'] = 'پیغام از روی سرور بارگذاری نشد'; $messages['fileuploaderror'] = 'آپلود فایل ناموفقیت آمیز بود'; $messages['filesizeerror'] = 'بیشتر است $size فایل آپلود شده از حد اکثر حجم مجاز '; ?>

2 1

Bug with non-ASCII mailboxes' names
by Emil Wojak 20 Mar '07

20 Mar '07

Hi! Whenever a mailbox has some non-ASCII characters encoded in UTF-7, it then contains an ampersand, which should be encoded each time it's used in URL. There are some variables both in PHP and JS code, that are used literally, which causes some failures when dealing with such mailboxes, especially when trying to get an attachment. Another issue, which I found while debugging the abovementioned issue, is that given a wrong mail part number with the _part parameter, RC returns an invalid, zero-length, message with MIME type set to '/' (yes, with both major and minor types empty). Well, the source code seems to suggest, that RC was supposed to return "HTTP/1.1 404 Not Found", but due to a semicolon right after an 'if' condition, it always tries to return the message part, thus never reaching the 404 code. Strange as it may seem, PHP did not raise any syntax error. I hope I made myself clear enough :] So, here is the diff to RC rev 511, which unfortunately, besides fixes to these bugs, contains some other bugfix along with some feature improvements, which I described in http://lists.roundcube.net/mail-archive/roundcube.dev/2007/02/53/ but which didn't get into the repository :] It's just because I keep all my changes in a local copy of the repo. And there are some translation fixes too, it would be nice if you could change that as well, as the present translation is a bit misleading. Sorry for the long explanations, and once again, thanks for the greatest free webmail ever! ----PATCH----PATCH----PATCH----PATCH----PATCH----PATCH----PATCH----PATCH---- Index: program/localization/pl/labels.inc =================================================================== --- program/localization/pl/labels.inc (wersja 511) +++ program/localization/pl/labels.inc (kopia robocza) @@ -91,8 +91,8 @@ $labels['all'] = 'Zaznacz wszystkie'; $labels['none'] = 'Odznacz'; $labels['unread'] = 'Zaznacz nieprzeczytane'; -$labels['compact'] = 'Kompaktuj'; -$labels['empty'] = 'Pusty'; +$labels['compact'] = 'Upakuj'; +$labels['empty'] = 'Opróżnij'; $labels['purge'] = 'Oczyść'; $labels['quota'] = 'Użyta Przestrzeń'; $labels['unknown'] = 'nieznane'; Index: program/js/list.js =================================================================== --- program/js/list.js (wersja 511) +++ program/js/list.js (kopia robocza) @@ -35,6 +35,7 @@ this.shiftkey = false; this.multiselect = false; + this.multi_selecting = false; this.draggable = false; this.keyboard = false; @@ -216,7 +217,7 @@ if (this.draggable && this.selection.length) { this.drag_start = true; - this.drag_mouse_start = rcube_event.get_mouse_pos(e); + this.drag_mouse_start = rcube_event.get_mouse_pos(e); rcube_event.add_listener({element:document, event:'mousemove', object:this, method:'drag_mouse_move'}); rcube_event.add_listener({element:document, event:'mouseup', object:this, method:'drag_mouse_up'}); } @@ -304,6 +305,7 @@ { this.shift_start = id; this.highlight_row(id, false); + this.multi_selecting = false; } else { @@ -327,6 +329,7 @@ this.highlight_row(id, false); break; } + this.multi_selecting = true; } // trigger event if selection changed Index: program/js/app.js =================================================================== --- program/js/app.js (wersja 511) +++ program/js/app.js (kopia robocza) @@ -125,11 +125,11 @@ this.message_list.addEventListener('dblclick', function(o){ p.msglist_dbl_click(o); }); this.message_list.addEventListener('keypress', function(o){ p.msglist_keypress(o); }); this.message_list.addEventListener('select', function(o){ p.msglist_select(o); }); - this.message_list.addEventListener('dragstart', function(o){ pdrag_active = true; }); + this.message_list.addEventListener('dragstart', function(o){ pdrag_active = true; if (p.preview_timer) clearTimeout(p.preview_timer); }); this.message_list.addEventListener('dragend', function(o){ p.drag_active = false; }); this.message_list.init(); - this.enable_command('toggle_status', true); + this.enable_command('toggle_status', 'sort', true); if (this.gui_objects.mailcontframe) { @@ -147,15 +147,9 @@ { this.enable_command('show', 'reply', 'reply-all', 'forward', 'moveto', 'delete', 'viewsource', 'print', 'load-attachment', true); if (this.env.next_uid) - { - this.enable_command('nextmessage', true); - this.enable_command('lastmessage', true); - } + this.enable_command('nextmessage', 'lastmessage', true); if (this.env.prev_uid) - { - this.enable_command('previousmessage', true); - this.enable_command('firstmessage', true); - } + this.enable_command('previousmessage', 'firstmessage', true); } // make preview/message frame visible @@ -186,7 +180,7 @@ } if (this.env.messagecount) - this.enable_command('select-all', 'select-none', 'sort', 'expunge', true); + this.enable_command('select-all', 'select-none', 'expunge', true); if (this.env.messagecount && (this.env.mailbox==this.env.trash_mailbox || this.env.mailbox==this.env.junk_mailbox)) this.enable_command('purge', true); @@ -666,7 +660,7 @@ break; case 'load-attachment': - var qstring = '_mbox='+this.env.mailbox+'&_uid='+this.env.uid+'&_part='+props.part; + var qstring = '_mbox='+urlencode(this.env.mailbox)+'&_uid='+this.env.uid+'&_part='+props.part; // open attachment in frame if it's of a supported mimetype if (this.env.uid && props.mimetype && find_in_array(props.mimetype, this.mimetypes)>=0) @@ -1095,7 +1089,7 @@ } // start timer for message preview (wait for double click) - if (selected && this.env.contentframe) + if (selected && this.env.contentframe && !list.multi_selecting) this.preview_timer = setTimeout(function(){ ref.msglist_get_preview(); }, this.dblclick_time + 10); else if (this.env.contentframe) this.show_messageframe(false); @@ -1927,7 +1921,7 @@ { this.message_list.clear(); this.set_busy(true, 'searching'); - this.http_request('search', '_search='+value+'&_mbox='+mbox, true); + this.http_request('search', '_search='+value+'&_mbox='+urlencode(mbox), true); } return true; }; Index: program/steps/mail/get.inc =================================================================== --- program/steps/mail/get.inc (wersja 511) +++ program/steps/mail/get.inc (kopia robocza) @@ -55,7 +55,7 @@ else if ($pid = get_input_value('_part', RCUBE_INPUT_GET)) { - if ($part = $MESSAGE['parts'][$pid]); + if ($part = $MESSAGE['parts'][$pid]) { $ctype_primary = strtolower($part->ctype_primary); $ctype_secondary = strtolower($part->ctype_secondary); Index: program/steps/mail/func.inc =================================================================== --- program/steps/mail/func.inc (wersja 511) +++ program/steps/mail/func.inc (kopia robocza) @@ -59,7 +59,7 @@ // define url for getting message parts if (strlen($_GET['_uid'])) - $GET_URL = sprintf('%s&_action=get&_mbox=%s&_uid=%d', $COMM_PATH, $IMAP->get_mailbox_name(), get_input_value('_uid', RCUBE_INPUT_GET)); + $GET_URL = sprintf('%s&_action=get&_mbox=%s&_uid=%d', $COMM_PATH, urlencode($IMAP->get_mailbox_name()), get_input_value('_uid', RCUBE_INPUT_GET)); // set current mailbox in client environment ----PATCH----PATCH----PATCH----PATCH----PATCH----PATCH----PATCH----PATCH---- -- Emil Wojak <emil(a)wojak.eu>, Politechnika Gdańska, Wydział ETI, Chór Politechniki Gdańskiej, Compuware, Sp. z o.o.

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev March 2007