Dev October 2008

dev@lists.roundcube.net

35 participants
52 discussions

patch - ldap_generic v2 and usr_data
by Daniel Mealha Cabrita 19 Nov '08

19 Nov '08

hi there, The following patches (see links below) provide each: 1. - rc_ldap_gen.patch (rcube_ldap_generic class) A generic interface for LDAP access (currently read-only operations). Essentially it's rcube_ldap class split in two, and it's a superclass of rcube_ldap. rcube_ldap class behavior remains the same. 2. - rc_init_id.patch (rcube_usr_data class) It's a modular subsystem to collect the initial user data (such as name, e-mail address, organization). It currently supports mechanisms 'ldap' and 'fixed'. Read main.inc.php.dist for instructions on how to use this. *REQUIRES* rc_ldap_gen.patch to be applied previously. Both patches should work with the current development version. The first patch replaces the previous one sent by me yesterday. Feedback is appreciated. -- Daniel Mealha Cabrita Divisao de Suporte Tecnico AINFO / Reitoria / UTFPR http://www.utfpr.edu.br --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/6c/QYMfn8rX/rc_init_id.patch http://detached.gigo.com/rc/6c/QYMfn8rX/rc_ldap_gen.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

patch - generic LDAP support
by Daniel Mealha Cabrita 30 Oct '08

30 Oct '08

hi there, I've included a patch which splits the rcube_ldap class in two, providing: 1. - The rcube_ldap class as before, and with the very same behavior (provides addressbook based on LDAP entries). 2. - The new rcube_ldap_generic class (being a superclass of rcube_ldap) which provides a generic LDAP interface. -- This class currently supports only read-only operations. I've already have new code (pending some polishment) using the new rcube_ldap_generic class, which I intend to make availabe as soon as possible. Comments, suggestions? -- Daniel Mealha Cabrita Divisao de Suporte Tecnico AINFO / Reitoria / UTFPR http://www.utfpr.edu.br --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/wu/HrmfdQjs/roundcubemail_generi.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 2

roundcube message filter
by Raoul Bhatia [IPAX] 30 Oct '08

30 Oct '08

hi, roundcube's message filter in the right upper corner of the message list has an at least for me unexpected behavior: filtering for "string" also shows messages which contain an .eml file which had the subject "string". e.g. --- cut --- > Return-Path: <> > X-Original-To: Administrator(a)server.home > Delivered-To: raoul(a)bhatia.at > Received: by mail.ipax.at (Postfix) > id 7256F4773B6; Tue, 28 Oct 2008 16:47:34 +0100 (CET) > Date: Tue, 28 Oct 2008 16:47:34 +0100 (CET) > From: MAILER-DAEMON(a)mail.ipax.at (Mail Delivery System) > Subject: Undelivered Mail Returned to Sender ... body of "Undelivered Mail Returned to Sender" ... > --94FBE477383.1225208854/mail.ipax.at > Content-Description: Undelivered Message > Content-Type: message/rfc822 ... header ... > From: root(a)server.home (Cron Daemon) > To: root(a)server.home > Subject: Cron <root@server> /root/bin/check_internet.sh ... body of "Cron <root@server> /root/bin/check_internet.sh" ... --- cut --- i do not know if this is intended or simply the result of using an expression like "^subject: $string", but at first it might puzzle :) is it good, bad, unexpected, worth a ticket in trac? cheers, raoul -- ____________________________________________________________________ DI (FH) Raoul Bhatia M.Sc. email. r.bhatia(a)ipax.at Technischer Leiter IPAX - Aloy Bhatia Hava OEG web. http://www.ipax.at Barawitzkagasse 10/2/2/11 email. office(a)ipax.at 1190 Wien tel. +43 1 3670030 FN 277995t HG Wien fax. +43 1 3670030 15 ____________________________________________________________________ _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Contacts gettiong exposed on html
by Jonathan Batista de Araujo Neto 29 Oct '08

29 Oct '08

Hello, I noticed that the contacts get exposed on the compose page, that is, everyone reading the source could take the whole list in a text file, so he could send spam. It's not a problem for personal contacts, but if you're in a huge company using LDAP, this could not be a good idea. One of our programmers get around this, but using ajax and getting the contacts straight to a certain javascript var, instead of defining that on the page code. Since Roundcube has new realeases we had to do the workaround every time. Maybe you can integrate this "feature" on the mainstream, if of your interest. I can send the hacked code for the version 0.1. Thanks a lot Jonathan Araújo Administrador de Infra-estrutura de TI Gerência de TI - INDG S.A. -------------------------------------------------------------------------------- Este documento pode incluir informação confidencial e de propriedade restrita do Instituto de Desenvolvimento Gerencial-INDG e apenas pode ser lido por aquele(s) a quem sido endereçado. Se você recebeu esta mensagem de e-mail indevidamente, por favor avise-nos imediatamente. Quaisquer opiniões ou informações contidas neste e-mail pertencem ao seu remetente e não necessariamente coincidem com as do Instituto de Desenvolvimento Gerencial-INDG. Este documento não pode ser reproduzido, copiado, distribuído, publicado ou modificado por terceiros, sem a prévia autorização por escrito do Instituto de Desenvolvimento Gerencial-INDG. This document may include proprietary and confidential information of Instituto de Desenvolvimento Gerencial-INDG, and may only be read by those persons to whom it is addressed. If you have received this e-mail message in error, please notify us immediately. Any views or opinions expressed in this e-mail are those of the sender and do not necessarily coincide with those of the Instituto de Desenvolvimento Gerencial - INDG. This document may not be reproduced, copied, distributed, published, modified or furnished to third parties, without the prior written consent of Instituto de Desenvolvimento Gerencial-INDG. -------------------------------------------------------------------------------- _______________________________________________ List info: http://lists.roundcube.net/dev/

6 16

Updated Hebrew translation
by Moish 28 Oct '08

28 Oct '08

moish --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/5A/UYsjQBaw/labels.inc http://detached.gigo.com/rc/5A/UYsjQBaw/messages.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

up-to-date French translations
by geoffroy desvernay 28 Oct '08

28 Oct '08

Hello anybody, Here are up-to-date (yesterdays) translations in French. If anyone interested... Another question: will managesieve patch from Aleksander 'A.L.E.C' Machniak (alec/at/alec/dot/pl) be incorporated before v0.2 ? Thank you for this great webmail ! -- Geoffroy DESVERNAY ----- 99, av. des Chartreux 13004 MARSEILLE ----- Tel: 04 91 62 73 90 Mail: dgeo(a)dgeos.net --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/5C/asYyFDfy/messages.inc http://detached.gigo.com/rc/5C/asYyFDfy/labels.inc http://detached.gigo.com/rc/5C/asYyFDfy/signature.asc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Re: [RCD] Add 'send as new' function
by Christian Beer 26 Oct '08

26 Oct '08

Sometimes it's good to give changes some time. :) It's working! After logging in today the send as new function is working. I've attached the patch. What's missing is a translation and new button images (I copied the forward buttons). I can do the translation stuff but not the buttons. Btw: Roundcube is a very good webmail package. Regards Christian On 25-Oct-2008 23:48:32, Christian Beer wrote: Hi folks, one of my customers requested a feature that is available in thunderbird. It's called "send as new mail" there. I figured out that it should be easy to add to roundcube. I used the forward command as a template and tried to add a new command on my own. But it's not working as intended. The command button is shown but it's disabled in all cases. I expected that it is available when the forward command is available, but it's not. I've changed the files program/steps/mail/compose.inc, program/js/apps.js, skins/default/templates/mail.html and skins/default/templates/message.html. I can provide the diffs to version 0.2-beta if needed. Does anyone has an idea where to change the code in order to get this extra function working? Regards Christian --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/4y/TkgCMY5a/compose-as-new.diff Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Add 'send as new' function
by Christian Beer 25 Oct '08

25 Oct '08

Hi folks, one of my customers requested a feature that is available in thunderbird. It's called "send as new mail" there. I figured out that it should be easy to add to roundcube. I used the forward command as a template and tried to add a new command on my own. But it's not working as intended. The command button is shown but it's disabled in all cases. I expected that it is available when the forward command is available, but it's not. I've changed the files program/steps/mail/compose.inc, program/js/apps.js, skins/default/templates/mail.html and skins/default/templates/message.html. I can provide the diffs to version 0.2-beta if needed. Does anyone has an idea where to change the code in order to get this extra function working? Regards Christian _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Date parsing glitch
by Eric Stadtherr 24 Oct '08

24 Oct '08

Hey all, I ran into a problem in the way RoundCube handles mail messages with "Date:" headers that aren't 100% compliant with RFC 2822's date format. The header in question is: Date: Tue, 21 Oct 2008 00:13:54 0600 Notice that the time zone offset specifier is missing the "+/-" prefix. Thunderbird seems to drop the zone offset in this case and assume it's a local date. RoundCube, on the other hand, passes it into PHP's handy "strtotime" function which interprets 0600 as the year. This leads at the very least to display problems (in the message list and the message display), and worst case to invalid dates in the database if caching is enabled. I'd like to make RoundCube a little more tolerant, so I was wondering what everyone else thought about possible solutions. The options I'm considering are: 1. Parse the date using a fixed format string (e.g. "D, d M Y H:i:s O") and one of PHP's other date functions. This would prevent misinterpretation but might be even less tolerant. 2. Analyze the string before passing to strtotime() to identify and work around known issues (of which there would be exactly one at this point). This is a single special case kind of solution, but strtotime might be reliable enough that this is the only case we'll hit. 3. Find a 3rd party RFC2822-compliant PHP date parser library. What do you all think? -- *Eric Stadtherr* estadtherr(a)gmail.com <mailto:estadtherr@gmail.com> _______________________________________________ List info: http://lists.roundcube.net/dev/

3 3

on translator logic and .po files
by Dennis P. Nikolaenko 19 Oct '08

19 Oct '08

Hello, It has been suggested to use .po files for translation. This may be a viable path, but it may introduce unneeded complexity. My real concern is about semantic changes in translatable strings. For example, if en_US 'foo' has "Do bar" as a string and then later changed to "Do baz", all other translations are left unchanged, because the online translator does not detect the change in meaning. To combat this, an original en_US string may be added as a comment after the translated string. Examle. in en_US: $labels['changecolor']='Change color'; in en_GB: $labels['changecolor']='Change colour';//Change color After 'Change color' is changed to 'Change text color', translator should offer to revise the translation in all locale files because the comment in the locale file does not match the current en_US string. -- Dennis _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev October 2008