Dev June 2008

dev@lists.roundcube.net

35 participants
33 discussions

Re: [RCD] Cache + Performance question
by emi daruma tai 11 Jun '08

11 Jun '08

I think doing caching of messages is not at all a good idea. I usually use more than one mail reader: sometimes roundcube at work, others squirrel and sometimes pine, all depending on from which machine I'm connecting to see the mail. If we cache the messages into DB, only Roundcube will know it and sometimes it may be different from IMAP server. It's the same problem as using Outlook: it keeps messages locally, not on IMAP/POP server. So, if finally you decide to enable messages cache feature, it should be an option, that will be enabled only for those who only use RoundCube and whose know there are not thousands of messages for thousands of users. Personally, I vote -1 for that. Ah! saving messages to files into RC server instead of DB... you'll lose all DB improvements, as transactional one: if there is any problem with electricity it may corrupt files and lose info. For this, I vote -1000. See you, emi 2008/6/11 Алексей Михеев <amiheev(a)st-host.ru>: I think, that could make sense, if those caches would be flushed > regularly depending no how many users are there. And I don't think, > mysql would be too good for that, I'd prefer some kind of serialized > data in files. > > On Wed, 11 Jun 2008 11:30:36 +0200 > Andreas <andreas(a)unstable.nl> wrote: > > > On Wed, Jun 11, 2008 at 09:32:51AM +0200, Thomas Bruederli wrote: > > > This will probably bloat the database like hell. Consider thousands > > > of users having thousands of messages with attachments. If the size > > > of the database grows, it takes even longer to load data because of > > > a higher seeking time. Also opening a single message is less > > > expensive than listing hundred of headers. This is why we just > > > cache headers. > > > > Would it help if you only request the 20-some headers that are to be > > displayed? If the IMAP server does the sorting, RoundCube doesn't > > need to know about all of the messages in a folder. > > > > -- > Aleksei "rusty_angel" Miheev > ST-Hosting > mailto:amiheev@st-host.ru > xmpp:aleksei@jabber.miheev.info <xmpp%3Aaleksei(a)jabber.miheev.info> > +7 (8313) 244 000 > _______________________________________________ > List info: http://lists.roundcube.net/dev/ > _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Cache + Performance question
by Michael 11 Jun '08

11 Jun '08

Hello. I was looking at the header and structure objects that are stored in the database. It doesn't seem like the message body is stored in the object. IMAP connections are really expensive for web-based mail clients since they have to be re-established every time a php page is executed. If the message body was stored in the database you could avoid making the IMAP connection and probably shave a second or two off the time it takes to (re)read a message. You could even take is a step further and store the whole body in a blob so attachments could be read without making an imap connection. This would only really start to help when you revisit the message, the first time would take the most time. Any input? Is this a horrible idea? You guys seem pretty smart so I am sure you've considered this. Michael _______________________________________________ List info: http://lists.roundcube.net/dev/

4 3

RoundCube version 0.2-alpha is out
by Thomas Bruederli 11 Jun '08

11 Jun '08

Hi everybody, After refactoring some backend code we finally put a working copy of RoundCube Webmail together again. This preview release of version 0.2 comes up with an all-new HTML sanitization function (written by Frédéric Motte) which removes malicious JavaScript code from HTML messages and fixes all known XSS vulnerabilities. Beside that we also fixed more than 100 bugs and improved both speed and stability. Special thanks go to Alec, who spent many hours with fixing bugs and improving features. With this release RoundCube finally drops support for PHP4 so update your PHP to 5.2 or greater before installing the new version. The new version can be downloaded from our website: http://roundcube.net/downloads or from http://sf.net/projects/roundcubemail/ Have fun! ~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/

4 6

Plugins backend - step 1
by A.L.E.C 11 Jun '08

11 Jun '08

I think it would be good start for plugins API to get rid of hardcoded actions from index.php. So, we have such code: // include task specific files if ($RCMAIL->task=='mail') { include_once('program/steps/mail/func.inc'); if ($RCMAIL->action=='show' || $RCMAIL->action=='preview' || $RCMAIL->action=='print') include('program/steps/mail/show.inc'); ... My proposition is to create file for each action (filename = actionname) in tasks directories, and then we have: foreach(array('plugins', 'steps') as $dir) if (file_exists('program/'.$dir.'/'.$RCMAIL->task.'/'.$RCMAIL->action.'.inc')) { @include_once('program/'.$dir.'/'.$RCMAIL->task.'/_init.inc'); // init actions (renamed func.inc) @include_once('program/'.$dir.'/'.$RCMAIL->task.'/'.$RCMAIL->action.'.inc'); @include_once('program/'.$dir.'/'.$RCMAIL->task.'/_destroy.inc'); // post actions break; } plugins directory it's just for possibility to overwrite built-in action with plugin action. -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Project Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

6 9

Updated French translation
by Maximilien Cuony 10 Jun '08

10 Jun '08

Hi, I know, I'm not an official translator for french, but it's ugly to have English mixed with French on the 0.2-alpha so I updated myself the files ;) Regards, -- Maximilien Cuony [The_Glu] http://theglu.org --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/np/9mU6FwuX/labels.inc http://detached.gigo.com/rc/np/9mU6FwuX/messages.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

HTTP Auth patch
by Ryan Roth 09 Jun '08

09 Jun '08

I have seen a couple of patches that allow you to reuse http auth for roundcube but both are out dated. I have updated the newer of the two to work with the current SVN ( http://trac.roundcube.net/ticket/1485076 ). Can we get this included with the main development branch so that it is an official feature? Thanks _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Updated Catalan translation
by Roger Pueyo Centelles 07 Jun '08

07 Jun '08

--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/96/nBgdSkWW/messages.inc http://detached.gigo.com/rc/96/nBgdSkWW/labels.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Log logins
by Robin Elfrink 06 Jun '08

06 Jun '08

Hi all, For various reasons I need to know who logged into RoundCube when and from where. I can't imagine any other admin not wanting to know, and I don't understand how I got to run RoundCube for so long without knowing :) I'd like to propose something like this: --- index.php (revision 1480) +++ index.php (working copy) @@ -86,6 +86,10 @@ // send auth cookie if necessary $RCMAIL->authenticate_session(); + // log successful login + if ($RCMAIL->config->get('debug_level') & 1) + console(sprintf('Successful login for %s from %s', trim(get_input_value('_user', RCUBE_INPUT_POST), ' '), $_SERVER['REMOTE_ADDR'])); + // send redirect header("Location: {$RCMAIL->comm_path}"); exit; This results in a line like this in logs/console: [06-Jun-2008 10:08:45 +0200]: Successful login for robin (id 8) from 16.35.94.15 Robin _______________________________________________ List info: http://lists.roundcube.net/dev/

3 3

attachments with national characters
by A.L.E.C 06 Jun '08

06 Jun '08

There're problems with attachment names in parts without charset specification. Example message can be found here http://trac.roundcube.net/ticket/1484969 I think we have two solutions: 1. Check charset of first (all) part(s) of message and convert filename according to it, but what when there's no charset data? 2. Detect charset using ie. mb_detect_encoding(). Here's a patch for 2. diff -ruN rc-beta3/program/include/rcube_imap.php rc-beta2/program/include/rcube_imap.php --- rc-beta3/program/include/rcube_imap.php 2008-06-06 10:20:39.672800689 +0200 +++ rc-beta2/program/include/rcube_imap.php 2008-06-06 09:39:49.031952834 +0200 @@ -1159,10 +1159,13 @@ if (is_array($part[8]) && empty($struct->parts)) $struct->parts[] = $this->_structure_part($part[8], ++$count, $struct->mime_id); } - + // normalize filename property if ($filename_mime = $struct->d_parameters['filename'] ? $struct->d_parameters['filename'] : $struct->ctype_parameters['name']) - $struct->filename = rcube_imap::decode_mime_string($filename_mime, $this->default_charset); + { + $struct->filename = rcube_imap::decode_mime_string($filename_mime, + $struct->charset ? $struct->charset : rc_detect_encoding($filename_mime, $this->default_charset)); + } else if ($filename_encoded = $struct->d_parameters['filename*'] ? $struct->d_parameters['filename*'] : $struct->ctype_parameters['name*']) { // decode filename according to RFC 2231, Section 4 @@ -1170,7 +1173,8 @@ $struct->filename = rcube_charset_convert(urldecode($filename_urlencoded), $filename_charset); } else if (!empty($struct->headers['content-description'])) - $struct->filename = rcube_imap::decode_mime_string($struct->headers['content-description'], $this->default_charset); + $struct->filename = rcube_imap::decode_mime_string($struct->headers['content-description'], + $struct->charset ? $struct->charset : rc_detect_encoding($struct->headers['content-description'],$this->default_charset)); return $struct; } diff -ruN rc-beta3/program/include/rcube_shared.inc rc-beta2/program/include/rcube_shared.inc --- rc-beta3/program/include/rcube_shared.inc 2008-06-06 10:20:39.416799300 +0200 +++ rc-beta2/program/include/rcube_shared.inc 2008-06-06 10:07:39.177963387 +0200 @@ -581,4 +581,33 @@ return $mime_type; } -?> \ Brak znaku nowej linii na koĹ�cu pliku + +/** + * A method to guess encoding of a string. + * + * @param string $string String. + * @param string $failover Default result for failover. + * + * @return string + */ +function rc_detect_encoding($string, $failover='') +{ + if (!function_exists('mb_detect_encoding')) { + return $failover; + } + + // FIXME: the order is important, because sometimes + // iso string is detected as euc-jp and etc. + $enc = array( + 'UTF-8', 'ISO-8859-1', 'ISO-8859-2', 'ISO-8859-3', 'ISO-8859-4', + 'ISO-8859-5', 'ISO-8859-6', 'ISO-8859-7', 'ISO-8859-8', 'ISO-8859-9', + 'ISO-8859-10', 'ISO-8859-13', 'ISO-8859-14', 'ISO-8859-15', 'ISO-8859-16', + 'WINDOWS-1252', 'WINDOWS-1251', 'EUC-JP', 'EUC-TW', 'KOI8-R' + ); + + $result = mb_detect_encoding($string, join(',', $enc)); + + return $result ? $result : $failover; +} + +?> -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Project Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

3 3

Enable config files download from installer
by Robin Elfrink 06 Jun '08

06 Jun '08

Hi all, Please test attached patch, which enables downloading of freshly created config files from the installer. Robin --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/35/rDnkUEMQ/config-download.2008.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 2

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev June 2008