Dev September 2008

dev@lists.roundcube.net

32 participants
44 discussions

Contact groups
by Chris St Denis 15 Sep '08

15 Sep '08

I have been working to add contact groups (database backed) to my roundcube but I am struggling with the task due to the complexities of ajax and lack of documentation. I have managed with some difficulty to implement the majority of it using the LDAP contact groups code as a starting point, and I am hoping some people here can point me in the right direction to get the last of the elements working correctly. I can create a new contact group in the database using code based on program/steps/addressbook/save.inc, however I can not figure out how to update the javascript in real time. In the current form, I have to leave the addressbook and return to update it. What do I add to make it update the display? -- Chris St Denis Programmer SmarttNet (www.smartt.com) Ph: 604-473-9700 Ext. 200 ------------------------------------------- "Smart Internet Solutions For Businesses" _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

pointer in folder list in user preferences
by Dennis P. Nikolaenko 15 Sep '08

15 Sep '08

Folder list has a hand pointer, let it be consistent with a message list to have an arrow pointer. Index: skins/default/settings.css =================================================================== --- skins/default/settings.css (revision 1795) +++ skins/default/settings.css (working copy) @@ -171,7 +171,7 @@ white-space: nowrap; border-bottom: 1px solid #EBEBEB; background-color: #F9F9F9; - cursor: pointer; + cursor: default; } #subscription-table tr.virtual td -- Regards, Dennis P. Nikolaenko, dennis(a)nikolaenko.ru _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

vertical splitter patch
by A.L.E.C 12 Sep '08

12 Sep '08

Hi! I've made a patch which adds vertical splitter + some small fixes. It needs some work for IE and probably for Safari, but it works fine with: - Firefox3.0 (focus issue fixed via CSS: -moz-user-select: none), - Opera9.5 (ad. fixed iframe drag issue: added drag_active flag), - Konqueror3.5. Splitter dots are better centered now and #mainscreen division is required, but it's not a problem, I think. Some things may be done in better way, but it's working. Feel free to send corrections ;) -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Project Developer http://roundcube.net --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Xa/J7UfQYt7/vert_splitter.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

8 15

LDAP Addressbook
by andylockran 12 Sep '08

12 Sep '08

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Guys, I've just checked out trunk so I can have the LDAP write facility for my addressbooks, however, I've come across a bug. When you enter your binddn - mine is uid=andy,ou=Users,dc=example,dc=com - however, the bind_dn field is pre-appended with dn="$bind_dn" - which breaks the authentication. I'm looking through the code now to see if I can get rid of the leading dn= and whether that fixes my problem. Let me know if you have any other advice. Regards, Andy -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkjKb7YACgkQauMjEM4rxIRbngCgpbs/r5ikpVmY4439Ixvu/Jle L04AnRWZnVn2dGyM2dktlDGNU8Ma9f20 =mJrq -----END PGP SIGNATURE----- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 1

common office apps formats (m$ and openoffice) are misdetected by libmagic (bug #1485311)
by Arkadiusz Miskiewicz 10 Sep '08

10 Sep '08

#1485151 was solved after private talks with ALEC, so now new bug waiting for some action ... http://trac.roundcube.net/ticket/1485311 The common office apps formats (m$ and openoffice) are misdetected by libmagic library and that means that roundcube sends such attachment with wrong Content-type. I'm proposing to use plain filename extension based type detection for commonly misdetected formats. Example patch attached to bugreport. Opinions? -- Arkadiusz Miśkiewicz PLD/Linux Team arekm / maven.pl http://ftp.pld-linux.org/ _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Update zh_CN localization (label.inc, patch)
by Zhang Huangbin 06 Sep '08

06 Sep '08

Patch to update zh_CN localization. Thanks :) --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/mA/MRtfateN/label.inc.patch.bz2 Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] Extra contact details in address book, bounty?
by Roland Liebl 05 Sep '08

05 Sep '08

Hi, you can have my customized RoundCube for free or a donation to the RoundCube Team. I'm currently catching up with SVN 1748. http://www.roland-liebl.de user: demo pass: demo It has additional addressbook fields. Check also section usersettings -> addressbook Let me know Regards, Roland ___________ I was disappointed to see that the feature request that most interests me (adding extra contact details to the address book http://trac.roundcube.net/ticket/1332930) got moved from 0.2beta to 0.5... which means it's a LONG way off. In order to encourage development (since I'm in no way, shape, or form a developer), would it be possible and/or appropriate to add a bounty for this feature? I don't have a ton of extra cash (my fiancee is in graduate school), but could offer $75 as incentive for someone on the list to put in the work. If you prefer not to do this sort of thing please let me know. Thanks, Doug _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Extra contact details in address book, bounty?
by Doug Mandell 05 Sep '08

05 Sep '08

I was disappointed to see that the feature request that most interests me (adding extra contact details to the address book http://trac.roundcube.net/ticket/1332930) got moved from 0.2beta to 0.5... which means it's a LONG way off. In order to encourage development (since I'm in no way, shape, or form a developer), would it be possible and/or appropriate to add a bounty for this feature? I don't have a ton of extra cash (my fiancee is in graduate school), but could offer $75 as incentive for someone on the list to put in the work. If you prefer not to do this sort of thing please let me know. Thanks, Doug _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Proposed patch against against 1732
by David Lublink 05 Sep '08

05 Sep '08

Hello, I received an email today with 232 emails listed in the To: header. Most of them had accents in the names so there was about 200 encoding emails in the To: header. The method responsable for this is decode_mime_string() and is recursive. My server stops recursion at the 150th level. So the email caused PHP to crash and a blank page to be shown. I wrote the following patch against revision 1732 which will resolve the issue. I changed the recursion for iteration : Index: program/include/rcube_imap.php =================================================================== --- program/include/rcube_imap.php (revision 1732) +++ program/include/rcube_imap.php (working copy) @@ -2416,9 +2416,10 @@ function decode_mime_string($input, $fallback=null) { $out = ''; + $work = $input; - $pos = strpos($input, '=?'); - if ($pos !== false) + // Iterate instead of recursing, this way if there are too many values we don't have stack overflows + while( strpos($work, '=?') ) { // rfc: all line breaks or other characters not found // in the Base64 Alphabet must be ignored by decoding software @@ -2436,7 +2437,7 @@ $rest = substr($input, $end_pos+2); $out .= rcube_imap::_decode_mime_string_part($encstr); - $out .= rcube_imap::decode_mime_string($rest, $fallback); + $work = $rest; return $out; } Please include this into trunk of round cube. Additionally, it would be nice if you patched this to the stable version. To patch this to the stable version, you'll want to change rcube_imap.php to rcube_imap.inc before patching. Using patch that comes with gentoo, it patched fine with fuzz. I tested this patch on trunk and on the stable release 0.1.1. I have noticed that PHP is slow on calling methods statically, so the iteration will be a bit faster than the recursion. :D Please let me know, David --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/WA/DcyDmMrV/against-1732.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 3

Why can't use both sql and ldap address book in svn version?
by Zhang Huangbin 04 Sep '08

04 Sep '08

Hi, developers. I'm using Roundcube-0.1.1 with some plugins in product environment, and testing roundcubemail svn version. I'm confused why we can't use both sql and ldap address book in roundcube svn version. ----<-- main.inc.php ---- // This indicates which type of address book to use. Possible choises: // 'sql' (default) and 'ldap'. // If set to 'ldap' then it will look at using the first writable LDAP // address book as the primary address book and it will not display the // SQL address book in the 'Address Book' view. $rcmail_config['address_book_type'] = 'ldap'; ----<---- If i set it to 'sql', and configured ldap address book, it will list both two in address book panel, but when i click the ldap address book, it raised database error. If i use only ldap, it works. How can i use both address book types? Thanks very much. -- Zhang Huangbin _______________________________________________ List info: http://lists.roundcube.net/dev/

2 2

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev September 2008