Dev April 2009

dev@lists.roundcube.net

34 participants
31 discussions

Threaded message listing implementation
by Chris January 23 Jul '09

23 Jul '09

Hello, I have written an implementation of message threading for RoundCube. You can find it here: http://www.atomice.com/blog/?page_id=34 I have split it into a number of separate patches to make it easier to apply. The patches are against yesterday's SVN trunk. I hope it can be committed, but I appreciate a few things may need tweaking first. Please review it. Regards, Chris January _______________________________________________ List info: http://lists.roundcube.net/dev/

6 14

reduce network requests by consolidating icon images
by Nathan Kinkade 05 Jun '09

05 Jun '09

I've been spending a lot of time in Firebug with RoundCube the past few weeks. One thing I've noticed is that there are quite a lot of network requests to freshly load the front page. With the default theme there are around 45 separate requests for a little less than 250K. I was asking myself how to reduce the number of requests and was reminded of something interesting that I had noticed Gmail doing, and that is to consolidate many icons into a single image and then use CSS to position the image as the background of a fixed width/height block-level element. As I went to implement this, I began to realize that not only does this approach reduce the number of network requests, but it also seems to simplify the code a bit. With this method the code doesn't have to worry at all about images or file names, but becomes somewhat image-agnostic by only specifying the *type* of behavior it would like to see in a given location. How that bahavior is implemented then becomes a simple matter of CSS. Here is the consolidated image with not all but most of the usual icons: https://natha.nkinka.de/devmail/skins/default/images/icons/rc_icons.png And here are the patches to implement this: http://code.nkinka.de/gitweb?p=roundcube.git;a=commitdiff;h=84a7acd0f42e3c3… I found that doing this reduced the number of requests on a clean load of the main mailbox view from 45 to 35, which is fairly significant. It does add about 5K to the page size because it brings along a number of unneeded icons for that page. 10 less requests may not be perceptible for many people running on a fast machine with broadband Internet to a server that isn't very loaded. However, for a busy machine, perhaps an installation of RoundCube serving webmail for a university, for example, 10 less requests per fresh page load could make a noticeable difference. 10 less requests will probably also make a noticeable difference for those on a high latency connection, where 5K extra is less of a problem than 10 more network requests. I have no idea whether this is of any use or interest to anyone else, but I thought I'd share my experiment with the list. Nathan _______________________________________________ List info: http://lists.roundcube.net/dev/

7 15

Re: [RCD] GMail Bug
by A.L.E.C 04 May '09

04 May '09

Sandro Pazzi wrote: > Hi alec, > but why RC don't use uid? > > UID COPY <sequence uid> "folder" > UID STORE <sequence uid> +FLAGS.SILENT (\Deleted) > UID FETCH <sequence uid> (<params>) > > ... was a standard IMAP command that use directly uid instead of id of > messages. In this way all the problems with gmail was resolved. You're right, we should use such commands for better performance. I think, the reason is in imap.inc which supports only message IDs in iil_C_Copy and some others. I don't know why IlohaMail does that is such way. We should definitely use UIDs where possible. -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Project Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

2 8

Plugin API
by Cor Bosman 28 Apr '09

28 Apr '09

Hi all, Ive been porting some of our internal squirrelmail plugins to RC, now that RC has a plugin API. Most were quite easy to port, but one has me a bit stumped. Im probably overlooking something. Im using the markasjunk plugin as a base, but im trying to modify it to not only allow marking junk, but the reverse as well. If you're in the junk folder it should move your mail to the inbox, and preferably also have a slightly different button. Deciding what folder to move things to is easy. Just check your current folder and decide accordingly. But how can I change the button based on what folder im in? Is this possible? Can I listen to an event on folder change and change the button? Any help is appreciated, Regards Cor ps: this plugin hooks into our internal cloudmark based spamfilters to enable learning of mistakes. _______________________________________________ List info: http://lists.roundcube.net/dev/

2 3

Drupal 6 Integration / Embeded functionality
by Rob Coward 27 Apr '09

27 Apr '09

Hi, I'm new to this list, so please excuse me if this topic has been discussed to death already, but in a quick search of the list archives, it doesnt appear to have come up recently. I'm currently starting out with using Drupal as a base for some web site installs and like the way its functionality can be extended with modules to drawn in and embed functionality from other packages such as Gallery2. Apart from http://drupal.org/node/58466 (which seems to have stagnated and in fact no longer works with Drupal6) there doesnt appear to have been much activity in embedding RoundCubeMail functionality within the Drupal framework. Is anyone else currently looking into this, and would I be wasting my time / duplicating effort if I was to attempt something ? My initial thoughts would be to integrate the authentication, so authenticated users in drupal can click a single link and go straight into their mailbox in webmail (spawning a new tab/window in the short term). Looking at http://trac.roundcube.net/wiki/Plugin_Hooks I wonder if this could be achieved by using the authenticate hook rather than by patching the roundcube code like the previous attempt did ? Longer term, I would like to see embedded functionality like Gallery2 does, so that for example, when viewing a user's mailbox their folder list appears as an expandable menu list within the standard Drupal navigation menu, the message list / message view / compose etc appears in the main page body, and elements such as the "E-Mail", "Address Book" and "Personal Settings" can either be presented in a Drupal 'Block' which could be presented in any of the standard header / left/right sidebar locations etc. Does this all sound sensible / achievable ? Anyone else looking into something similar ? I am a fairly confident Perl / PHP coder, less so with Javascript and AJAX technologies, though am willing to contribute to this project if I can. If noone else is currently looking into Drupal integration, could anyone suggest a good place for me to start ? Many thanks, Rob Coward _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

API available in trunk
by Thomas Bruederli 26 Apr '09

26 Apr '09

Hello devs and list lurkers Today we merged the development branch for the upcoming API back into the trunk. Now you can try out the Plugin API with a fresh checkout from the svn trunk. It is also available as nightly snapshot at http://nightly.roundcube.net/trunk/ It's now time for excessive testing to detect bugs that came in with the code changes for the API. Also the client scripts now rely on jQuery and we therefore changed a lot of javascript code. So please let us know if you find some strange behavior or broken buttons. Regards, Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/

2 2

Updated nb_NO translation
by Odd Henriksen 26 Apr '09

26 Apr '09

I noticed that some strings have been missing from the nb_NO (Norwegian) translation for some time, and there were some typos and inconsistencies in some of the existing strings. I have now translated the untranslated strings, and made a few improvements to existing strings. Both files are now 100% complete. Best regards, Odd Henriksen RoundCube user Norway --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/fc/oS6M3FjC/messages.inc http://detached.gigo.com/rc/fc/oS6M3FjC/labels.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

optimisation of roundcube using compression and caching
by Daniel Black 24 Apr '09

24 Apr '09

I've had a look and produced some patches/configuration examples that allow roundcube delivered faster due to compression and more effectively cached by browsers[1]. Using compression the static pages reduced the size of the page after login from a few hundred k to just over one. The effects of caching mean that a logout and log back in only fetch a single index page[1] and all images, css and javascript are cached The lightty configuration described in the INSTALL file even keeps a cached compressed version of the static files for lower server load. I'm sure there are sysadmins and developers here with more experience running websites that me so if see any problems or improvements with these patches make a comment on the bug. [1] http://trac.roundcube.net/ticket/1485800 [2] the javascript page mentioned in stats was removed in r2402 Daniel Black -- Email/List Administrator CAcert _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

ugly login screen under linux
by ma.schmale＠googlemail.com 24 Apr '09

24 Apr '09

Hey devs, every time I login into my RC I see a really tiny but ugly "bug" in the default skin. As you can see this on this picture the input fields of the login form are to big. Image: http://cghost.de/mediahost/img13/rcube_ugly.uv0hev.png The best way to fix this is to add the following lines to the css-area of your skins/default/templates/login.html file: #login-form input { max-width: 230px; } That won't have any influence to other input fields and works for me. Does anyone have better way to solve this? Some system information: Gentoo Linux KDE 4.2.2 Mozilla Firefox 3.0.8 -- mit freundlichen Grüßen / best regards Mark Schmale _______________________________________________ List info: http://lists.roundcube.net/dev/

4 5

Ticket #1485659
by Robin Elfrink 24 Apr '09

24 Apr '09

Hi, Trying to fix ticket #1485659. There's a race condiction, in session handling. I think I got that with attached patch. Session data is stored serialized(), but not exactly. So I had to create extra unserialize/serialize functions for that. Downside is that unset($_SESSION['var']) will not work reliable anymore, so an extra rcube_sess_unset('var') was needed as well. Please point me at any mistakes I made :) Robin --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/xp/kFPRx0aF/_1485659.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

4 10

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev April 2009