Dev May 2009

dev@lists.roundcube.net

36 participants
65 discussions

Resply message
by Sandro Pazzi 26 May '09

26 May '09

Hi all, it's possible to set a property for set signature and cursor before the message in a reply? When we replay many times to an email your new text is in the bottom and not good for reading. Thanks -- Sandro Pazzi IdWeb s.r.l. Viale Romagna 69/A - 06012 Citta' di Castello (PG) Tel. 075 851 97 28 Fax 075 851 97 30 _______________________________________________ List info: http://lists.roundcube.net/dev/

5 8

Re: [RCD] Message Highlighting Plugin - Initial comments
by Eric Appelt 25 May '09

25 May '09

Hello Chris, your message highlight plugin works great and is really good, now i have update to current SVN and the message highlignt plugin dosn't work can you patch this thats works with the current SVN. Many Thanks _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

message menu button
by A.L.E.C 24 May '09

24 May '09

I'm working on a new button in toolbar (mail.html and message.html templates). This will be a popup menu like markmenu, will contains container for plugins and three actions (for start): - open message in new window - show source (in new window) - Download as .eml file The button will be enabled in message view or in mailbox view when one message is selected. I'll remove current viewsource button. So, now I need your opinion about: 1. Should I add 'print' action to message menu, and remove print button from toolbar? It's reasonable, print is a one-message-action (and we need more place for plugin buttons). 2. I've got no image for the button, any ideas? -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

3 5

Stable 0.2 forward attachment problem
by airween＠damson.hu 23 May '09

23 May '09

Hello Developers, I have checked on google, but didn't find any relevant info from past near... So, a few days ago I have upgraded from first 0.2 to current stable version, and users said if somebody forward an email which contains attachment, it doesn't arrive to recipient. I've checked, and it's true. When I forward an email which contains attachment (eg: a zipfile), it visible in "attachments" block on left top of display - but when I send it, and read at other address, the attachment isn't there. Could anybody help me? Thanks: a. _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Re: [RCD] [Svn] r2515 - trunk/roundcubemail/program/include
by Thomas Bruederli 22 May '09

22 May '09

A.L.E.C wrote: > BTW, plugins directory name is still hardcoded in rcube_plugin_api > as $url, which is used in ressource_url (two ss!) and to build rcube_plugin::$urlbase. > Yes, you're right. I forgot about that. I'm not sure whether we should introduce another config parameter which specifies the plugin directory URL. This is not necessarily the same as the real 'plugins_dir' setting. ~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

[PATCH] PHP 4 fixes for lib/html2text.php
by Francois Marier 22 May '09

22 May '09

Hi, Here's a 2-line patch for the html2text class which is part of RoundCube. I'm not sure whether or not you'll be interested in it because it's just about making that class compatible with PHP 4. I had to fix this specific problem because we (the Moodle project -- http://www.moodle.org) use your code to do HTML to text conversion when mailing out forum posts to users and unfortunately we still have to support PHP 4 in the latest stable version of Moodle. Cheers, Francois --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/7X/2Iskptr6/roundcube_html2text_.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Updated Hebrew Translation
by Moish 22 May '09

22 May '09

-- Moish --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/5q/DXEOjpYA/messages.inc http://detached.gigo.com/rc/5q/DXEOjpYA/labels.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] Load plugin config from plugin folder
by Roland Liebl 22 May '09

22 May '09

Resolved like inspired by Robert King. Thanks! Patch is not required anymore. I would just need your opinion about: http://lists.roundcube.net/mail-archive/dev/2009-05/0000053.html Regards, Roland _______________ function _load_config($plugin) { $rcmail = rcmail::get_instance(); $config = $rcmail->config->get('plugins_dir') . "/" . $plugin . "/config/config.inc.php"; if(file_exists($config)) include $config; else if(file_exists($config . ".dist")) include $config . ".dist"; if(is_array($rcmail_config)){ $rcmail->config->merge($rcmail_config); } } > ----- Original Message ----- > From: "Robert King" <robk(a)mun.ca> > To: "RoundCube Dev" <dev(a)lists.roundcube.net> > Sent: Sunday, May 17, 2009 5:42 PM > Subject: Re: [RCD] Load plugin config from plugin folder > > >> On Sun, 17 May 2009 13:03:37 -0230, Robert King <robk(a)mun.ca> wrote: >>> In my plugins I've been calling a function in the plugin init of: >>> >>> class plugin_name extends rcube_plugin >>> { >>> >>> public function init() >>> { >>> _load_config(); >>> } >>> >>> private function _load_config() >>> { >>> include('config.inc.php'); >>> $this->config = (array) $_config; >>> } >>> >>> } >> >> Forgot this important detail: >> >> class plugin_name extends rcube_plugin >> { >> private $config; >> ... >> } >> >> -- >> Robert King >> System Administrator >> Computing & Communications >> Memorial University >> _______________________________________________ >> List info: http://lists.roundcube.net/dev/ >> > > _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Plugin question
by Cor Bosman 22 May '09

22 May '09

Hi all, a plugin question ive been wondering about. What is the recommended way for a plugin to save longterm non-user configurable data? Just an example, lets say I want to keep track on if ive shown a MOTD page to a user, id have to save that information. But some plugins may have much more extensive needs here. Basically any data you want to save immediately without going through a save preferences click. It might be nice to have some api functions that allow a plugin to save this kind of data without having to construct your own SQL. Any ideas about this? Maybe it exists already and I just couldnt find. Also, looking at the code it seems as if plugins through save_preferences hook can add saved prefs, but this has a potential for unintentional overlap. If 2 plugins decide to use the same name, you'll override a previous config with the same name. Maybe RC should add the plugin name or something to the prefs key? Regards, Cor _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

[Plugin API] TODO
by A.L.E.C 21 May '09

21 May '09

I've rewritten my managesieve patch using plugin api and I've found a few issues: 1. Templates from plugin directory. I've commited patch from Roland Liebl and it's possible now, but... images path is hardcoded to "plugins/plugin_name/...", and will not work if someone will change plugins_dir. 2. include_script() includes script after rcmail variable initialization. That's ok, but there's a one situation when it's a problem. For 'html' output I must write: $this->rc->output->add_script(sprintf("rcmail.managesieve_updatelist('%s', '%s', %d);", isset($new) ? 'add' : 'update', $this->form['name'], $fid), 'foot'); instead of more unified form: $this->rc->output->command('managesieve_updatelist', isset($new) ? 'add' : 'update', $this->form['name'], $fid); 3. Localization folder name should be constant for all plugins (hardcoded in api). Creating plugins translator will be simpler then. -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Project Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev May 2009