Dev July 2009

dev@lists.roundcube.net

52 participants
73 discussions

Updated nl_NL translations
by Frits Letteboer - St. Radio Twenterand 09 Jul '09

09 Jul '09

Includes the fix suggested by Robert Broekhof "[RCD] spelling wrong in dutch translation" -- Frits Letteboer Technisch Beheer Stichting Radio Twenterand I: http://radiotwenterand.nl E: f.letteboer(a)radiotwenterand.nl --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/45/nn6kSc18/labels.inc http://detached.gigo.com/rc/45/nn6kSc18/messages.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

attachment handling fix for svn trunk
by Balazs Horvath 08 Jul '09

08 Jul '09

Hi, *attachment type* the newly introduced extension based mime-ing does not work, an old code fragment got back...: https://svn.roundcube.net/trunk/roundcubemail/program/steps/mail/attachment… instead of 'mimetype' => rc_mime_content_type($filepath, $_FILES['_attachments']['type'][$i]) should be this 'mimetype' => rc_mime_content_type($filepath, $_FILES['_attachments']['name'][$i], $_FILES['_attachments']['type'][$i]) *undocumented plugin hook* http://trac.roundcube.net/wiki/Plugin_Hooks $attachment = $RCMAIL->plugins->exec_hook('upload_attachment', $attachment); Bye, Balazs _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

RC plugins and sessions
by Robert King 08 Jul '09

08 Jul '09

Is there a "proper" way for Roundcube plugins to be accessing/writing to session data? I was assuming that $_SESSION would be okay, but it seems that if you are putting data in $_SESSION before the authenticate hook it will be killed by $RCMAIL->kill_session(); on line 76 of index.php. Having debugged it through xdebug, it seems as if the session data is being killed by rc. Here is what I am seeing: - library is called from plugin "startup" hook. This forces an unauth'd session to redirect to url of login service to establish authentication credentials - once auth'd it redirects back to the Roundcube url with $_SESSION['phpCAS'] set - again plugin "startup" hook is called, but $_SESSION['phpCAS'] exists so session is authenticated so startup hook sets $startup['action'] = 'login' - index.php evaluates ($RCMAIL->action=='login' && $RCMAIL->task=='mail') to true and executes $RCMAIL->kill_session(); on line 76 of index.php - $_SESSION['phpCAS'] gets nuked Is there a way of saving and restoring phpCAS so that when authenticate hook is called it will exist in $_SESSION? _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Multiple LDAP search base diff
by Terminal Addict 07 Jul '09

07 Jul '09

This diff for rcube_ldap.php allows users to define an array 'search_base_dn' in an ldap config. This is for users that may have to deal with poor LDAP data (like you would see from someone who can install Windows Server 2008 so they think they're an IT admin expert). I freely and openly admit that I am NOT an expert programmer (or expert anything really). This patch "worked for me" for my specific implementation. It shouldn't break anything for people with a single search base defined in 'base_dn'. Example: .... // regular ldap configuration options 'search_base_dn' => array( 'OU=Administration,DC=company,DC=org', 'OU=Finance,DC=company,DC=org'), .... // continue regular ldap options Note that the diff results below are against the rcube_ldap.php in 0.3b. TA 55,56d54 < if (! isset($this->prop['search_base_dn'])) < $this->prop['search_base_dn'] = $p['base_dn']; 259a258,260 > if ($this->sort_col && $this->prop['scope'] !== "base") > @ldap_sort($this->conn, $this->ldap_result, $this->sort_col); > 264,280c265 < $entries = array(); < $entries['count'] = 0; < if (is_array($this->ldap_result)) { < // merge multiple ldap results into a single array < foreach ($this->ldap_result as $ldr) { < $single_result_entries = ldap_get_entries($this->conn, $ldr); < for ($srindex=0; $srindex < $single_result_entries['count']; $srindex++) { < $entries[] = $single_result_entries[$srindex]; < $entries['count']++; < } < } < } else { < $entries = ldap_get_entries($this->conn, $this->ldap_result); < } < uasort($entries, array($this, 'sort_entries')); < // array_merge will reindex the array after it is sorted by uasort < $entries = array_merge($entries); --- > $entries = ldap_get_entries($this->conn, $this->ldap_result); 288,292d272 < // this is used by uasort to sort the merged ldap results < function sort_entries($a, $b) { < return (strcmp ($a[$this->sort_col][0],$b[$this->sort_col][0])); < } < 363,370c343 < if (is_array($this->ldap_result)) { < // sum counts for all ldap results < foreach ($this->ldap_result as $ldr) { < $count += ldap_count_entries($this->conn, $ldr); < } < } else { < $count = ldap_count_entries($this->conn, $this->ldap_result); < } --- > $count = ldap_count_entries($this->conn, $this->ldap_result); 380,387c353 < if (is_array($this->ldap_result)) { < // sum counts for all ldap results < foreach ($this->ldap_result as $ldr) { < $count += ldap_count_entries($this->conn, $ldr); < } < } else { < $count = ldap_count_entries($this->conn, $this->ldap_result); < } --- > $count = ldap_count_entries($this->conn, $this->ldap_result); 580d545 < if ($this->filter == $this->prop['filter']) return false; 583,591d547 < if (is_array($this->prop['search_base_dn'])) { < $conns = array(); < $bdindex = 0; < foreach ($this->prop['search_base_dn'] as $basednval) { < $conns[$bdindex++]=$this->conn; < } < } else { < $conns = $this->conn; < } 593c549 < $this->ldap_result = $function($conns, $this->prop['search_base_dn'], $this->filter, array_values($this->fieldmap), 0, 0); --- > $this->ldap_result = $function($this->conn, $this->prop['base_dn'], $this->filter, array_values($this->fieldmap), 0, 0); 640a597 > _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

id_ID translation update
by Arya Sabda 07 Jul '09

07 Jul '09

Here is the id_ID translation update for message.inc, please check this out. --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/RK/tV9Ohsm1/messages.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

php code design/performance
by darklight 07 Jul '09

07 Jul '09

Hi, walking through roundcube's code I've found some room for small improvements. if you sum them all together you may get some nice performance improvement (not very huge - but you can probably notice it) what I'm talking of are mainly style questions... because there are functions in php that do the same as another function, with the small difference that function X is faster for example print() is slower than echo() also double-quotes (") are up to 25% slower than concatenating strings with single quotes (') - which is a HUGE performance boost I've found a site which lists some of those functions - check [1] I quickly compared the list with roundcube's codebase those are the main places where there is still room for improvement: * use ' instead of " (where possible - for example 'this is a test' . "\n" would still be faster than "this is a test\n" - but you cannot replace '"\n" by '\n') * multiple parameters for echo - but most people prefer concatenating over this multiple argument feature (I have to admit: I also prefer string concatenation) * pre-increment instead of post-increment (should be quite easy to do this, since you need post-increment only in very few cases) * unset() should be used more often (bigger task) * use require() instead of require_once() - this is probably a bigger task too one small note about [1]: afaik switch/case is faster than if/else that site says the opposite some of those things can be put into roundcube's codebase quite easily maybe you can create some "Junior Jobs" section in your wiki, so bored devs may write patches (which of course should be reviewed by an experienced dev) however, feel free to discuss this oh, and I know: this whole mail is not mean for today's development... but more something for the future Regards, Martin [1] http://progtuts.info/55/php-optimization-tips/ _______________________________________________ List info: http://lists.roundcube.net/dev/

5 6

managing translations
by Martin 07 Jul '09

07 Jul '09

Hi, I always read about localization updates on your mailing list I started asking myself how translators know that they have to translate something which was recently added? do they check the interface and see "oh, there's text which is not translated yet"? or do they compare their locale with en_US ? anyway, wouldn't it be easier if some (maybe I :)) wrote some small PHP script that could easily compare multiple localized include-files with each other? if you want something like this feel free to tell me Regards, Martin _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Re: [RCD] Message archive plugin
by Roland Liebl 07 Jul '09

07 Jul '09

Thanks Thomas! The hook has meanwhile changed to "render_mailboxlist". It works great on the mailbox list within the task "mail". It does not work on the subscription table. Regards, Roland _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

High cpu overload
by Tiago Gomes 06 Jul '09

06 Jul '09

Hello everyone. sorry because my poor english congratulations to all the excellent project roundcube mail. I have one problem, I installed all versions for test, including svn / trunk (latest) and all creates overload on my server. High cpu load I'm using the services: Apache: Server version: Apache/2.2.6 (Unix) Server built: Jul 1 2009 20:41:05 * - -with-mpm=worker* Php: PHP 5.2.6-1+lenny3 with Suhosin-Patch 0.9.6.2 (cli) (built: Apr 26 2009 22:16:23) Copyright (c) 1997-2008 The PHP Group Zend Engine v2.2.0, Copyright (c) 1998-2008 Zend Technologies Mysql 5.0 SERVER load average info after 10 minutes then restart the apache server: *top - 16:48:25 up 6:24, 3 users, load average: 6.92, 2.89, 3.88* Tasks: 84 total, 2 running, 82 sleeping, 0 stopped, 0 zombie *Cpu(s): 98.1%us, 1.7%sy, 0.0%ni, 46.9%id, 0.2%wa, 0.0%hi, 0.0%si, 0.0%st* Mem: 2076288k total, 1079936k used, 996352k free, 297020k buffers Swap: 498004k total, 0k used, 498004k free, 486532k cached PID USER PR NI VIRT RES SHR S *%CPU* %MEM TIME+ COMMAND 14103 www-data 20 0 564m 125m 3536 S *190* 6.2 6:28.57 httpd 14088 www-data 20 0 517m 89m 3464 S * 118* 4.4 10:45.10 httpd the log error log from round roundcube mail: Only: *[03-Jul-2009 16:48:08 -0300] DB Error: MDB2 Error: constraint violation Query: _doQuery: [Error message: Could not execute statement] [Last executed query: EXECUTE mdb2_statement_mysql_501fd0fc317c477d1c729158644dc2c5bd5f1d12d USING @0, @1, @2, @3, @4, @5, @6, @7, @8, @9, @10] [Native code: 1062] [Native message: Duplicate entry '2557-INBOX.msg-13334' for key 2] in /webhost/ webmail.atarde.com.br/program/include/rcube_mdb2.php on line 621 (GET /?_task=mail&_mbox=INBOX&_page=1) [03-Jul-2009 16:48:08] MDB2 Error: constraint violation (-3): _doQuery: [Error message: Could not execute statement] [Last executed query: EXECUTE mdb2_statement_mysql_674a5a0876c6968d9d29cb5837c47123866f39a43 USING @0, @1, @2, @3, @4, @5, @6, @7, @8, @9, @10] [Native code: 1062] [Native message: Duplicate entry '2557-INBOX.msg-13401' for key 2] * Can you Help me, ? Thank's -- ---------------------------------------------------------------- Tiago Gomes Pereira http://www.tiagogomes.eti.br LPI Certified LPI ID - LPI000129445 IT Service Management - ITIL FOUNDATION V2 ID - SR341901 algodas(a)gmail.com _______________________________________________ List info: http://lists.roundcube.net/dev/

2 2

updated pt_BR localization
by Denis Volpato Martins 06 Jul '09

06 Jul '09

Hi, I’ve attached the patch for the completed pt_BR localization. Att. - Denis --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Bf/a6SuCK11/pt_BR.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev July 2009