Dev August 2009

dev@lists.roundcube.net

43 participants
57 discussions

Re: [RCD] [PATCH] Theaded view mode
by Eric Appelt 31 Aug '09

31 Aug '09

Hi Vladislav and all lurkers, I have found the Bug !!!!!!! in rcube_imap.php private function _list_headers if ($this->sort_field != 'default' && $this->get_capability('sort') && ($msg_index = iil_C_Sort($this->conn, $mailbox, $this->sort_field, $this->skip_deleted ? 'UNDELETED' : ''))) { // nothing more to do } else { $a_index = iil_C_FetchHeaderIndex($this->conn, $mailbox, "1:*", ($this->sort_field == 'default') ? '' : $this->sort_field, $this->skip_deleted); if (empty($a_index)) return array(); asort($a_index); // ASC $msg_index = array_keys($a_index); } remove the line asort($a_index); // ASC after this will works fine. I think the Problem are the sorting of the new in messagelist pushed messages !! I have long time testet and debug and now i think thats the solution. best Eric _______________________________________________ List info: http://lists.roundcube.net/dev/

3 2

Re: [RCD] [PATCH] Theaded view mode
by Eric Appelt 30 Aug '09

30 Aug '09

Hi Chris and Vladislav thx for your work show the attached image ... The green and yellow Messages are the same after deleting 4 Messages When i delete 4 Messages and the next 4 loads in the message list the 4 reloaded Messages are exists already in the message list the already exists Messages can't select or click this issue comes from threading patch testet with my patched installation clean RC0.3 snapshot and the snapshot from atomice.com this issue is only by the versions with threading it threading display enabled or disabled or preview is enabled or disabled is all the same after deleting some messages to four times some messages shows twice in messagelist i have testet with some browsers IE Firefox Opera and chrome on Windows XP and Gentoo and i have testet with an courier, cyrus and exim by all installations i have this issue with threading. I hope you find a solution Thx Lacri --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/jY/gdVQUrR4/threaded_bug.jpg Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

4 8

[PATCH] Set the port used for HTTPS connections
by Lex Brugman 30 Aug '09

30 Aug '09

Hi, I was just installing roundcube and noticed the force_https option, after enabling it I observed it was always assuming that the HTTPS port used is the default tcp port 443. My server has only one public ip address which forces me to use several 'custom' HTTPS ports, so this asked for an option to specify the HTTPS port used on the server, I've quickly implemented it and created a patch (see attachment) for the 0.3RC1 release. Maybe you would like to include this patch in future versions, or not :), it's up to you, just thought I should share this. Gr, Lex --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/bB/KQ9wWuRP/https_port.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Remote IMAP Accounts Plugin
by Roland Liebl 30 Aug '09

30 Aug '09

Hi all, I just "finished" an alpha release of a plugin to manage remote IMAP accounts. Please review! Notice: It depends on my "settings" plugin (http://myroundcube.googlecode.com). Regards, Roland --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/dx/5hUf1ma7/accounts.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] [Svn] r2851
by Eric Appelt 30 Aug '09

30 Aug '09

Hi Thomas and Vladislav, i have in my RC the quotadisplay moved in bottom of folderlist i think this is perfekt i have enough space in the footer for thread, folder and message list command links. i send yours an E-Mail with login Data to see my solution, @Vladislav you can see and test with the login data the threading problem with showing messages twice after delete. best Eric --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/1W/9F3ak858/vcard.vcf Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Updated Italian translation
by Uno 29 Aug '09

29 Aug '09

Updated Italian translation. -- Stefano --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/jE/t5QtWEfW/messages.inc http://detached.gigo.com/rc/jE/t5QtWEfW/labels.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] [PATCH] Theaded view mode
by Eric Appelt 27 Aug '09

27 Aug '09

Hi Vladislav, i think this is independently from thread or thread leading messages i have the same bug when threading is disabled and the bug is only in the with threads patched RC not in the standard RC. And when because of this then the bug would not be sporadic. one two times is all ok and then sporadic comes the bug and messages shows twice. I have spend mass time on this and I do not find the reason or solution. best Eric _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

IMAP APPEND fails on Quota Exceeded
by Robin Elfrink 27 Aug '09

27 Aug '09

Hi, (bug dropped in my mailbox) After sending an e-mail RoundCube attempts to append the e-mail to the Sent folder. RoundCube (actually, the Iloha library) does not handle the response to the APPEND command correctly, resulting in a properly sent e-mail, and a client timing out. Example conversation: > a APPEND "Drafts" (\Seen) {555145} < a NO [OVERQUOTA] Quota exceeded (mailbox for user is full) RoundCube reads the response line but doesn't parse it. Attached patch at least fixes the not-parsing-and-client-hanging part, logging the actual response line to the error log. But a proper error message to the user would be better. Does anybody have any idea if IMAP errors are standardized, and if so, how would I get the message from program/lib/imap.inc back to program/steps/mail/sendmail.inc, to show the user a proper message? Robin --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/7d/tCH2Il93/imap-append-error-ha.diff Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 3

updated lithuanian translation
by eg＠fbsd.lt 24 Aug '09

24 Aug '09

Hi, I made an update for Lithuanian translation. Edmondas --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/b7/By8tONnB/labels.inc http://detached.gigo.com/rc/b7/By8tONnB/messages.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

[PATCH] Theaded view mode
by Vladislav Bogdanov 22 Aug '09

22 Aug '09

Hi, I'm just subscribed, so first thanks to all devs for all efforts on making RC really great. I noticed that threaded view support is planned for 0.4-beta1, so I attach a reworked patch for a threaded mailbox view mode. It is not fully perfect, but is a good (re)starting point for that anyway. Changes comparing to roundcubemail-threading-20090706.patch from http://www.atomice.com/blog/?page_id=34: 1. Ported to 0.3-SVN-r2863 2. Implemented auto expand of threads with unread messages only. 3. Added GUI configuration option for autoexpand control (on, off, unread). 4. Autoexpansion works in both static and JS message lists. 5. Automatically change between 'unread children' and message icons in a list (in parent message rows) when child message is marked read/unread. 6. Count messages, not threads in a message view pane. 7. Fixed navigation in a message view pane when threading is enabled. 8. Fixed setting folders with non-ASCII named to threaded mode. 9. Fixed incorrectly displayed rows (children of collapsed row) after multi-level expand/collapse. Simplified expand logic. 10. Fixed expand indicator is not changing when expanding/collapsing with keyboard. 11. Fixed plus key on a numeric keypad is not working (at least on linux Fedora 11 + Firefox 3.5.2). 12. Added support for whole thread expand/collapse with clicking/pressing hotkeys while holding the Control key. 13. Save expand state in env everywhere (after keypresses too). 14. Added russian translation. 15. Fixed indentation and braces style in JS to comply with RC coding style. Known issues: 1. Messages from a threaded folder are sorted not in a thread-aware order but rather in a natural order when browsing with GUI controls at the bottom of a message view pane. This is probably a minor issue because it is more convenient anyway to browse through threaded discussions with a preview pane enabled. Maybe we need to explicitly enable a preview pane for a threaded folders. 2. Last selected message is neither focused nor centered in a list when returning to a list from a message view pane. I think it is minor issue too. This patch (and original one too) is sometimes too intrusive, so it needs to be checked at least twice just not to break things. Thanks for your time, comments are welcome. Best, Vladislav --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/X6/LiAx90cn/roundcubemail-SVN-28.patch http://detached.gigo.com/rc/X6/LiAx90cn/unread_children.png Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 2

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev August 2009