Dev September 2009

dev@lists.roundcube.net

54 participants
93 discussions

minor issue with r2959
by Victor Benincasa 24 Sep '09

24 Sep '09

Alec, The check "$unseen != $old_unseen" in the new function rcmail_send_unread_count() created in r2959 prevents the call of the JS function set_unread_count_display() that inserts the message count in the title when a column in message list is sorted on inbox. Related files: steps/mail/func.inc:L628 js/app.js:L3849 Can you take a look please? -- Victor Benincasa _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Address book expansion patch, using VCard to store extra info
by Phil Weir 24 Sep '09

24 Sep '09

Hi, This is an updated version of a patch I post a while back. I know that expanded address book is on the roadmap for 0.5 but since I had this from before I thought I wouldn't hurt to update it. There are no changes to the database required. The patch adds a new date format to the config file but I am not certain if this is really needed, it's only used to display the contacts birthday. The patch also adds some new bits of text to the localisation for the new address book options. The VCard class and address book show/edit are modified to include: alt email address, home and business phone/cell phone, fax and address, birthday and notes. All this information is stored in the VCard in the database. The auto complete function is modified to include the alt email address from the VCard. I don't know if this would work as a plugin as it is modifying the address book rather than adding a new one but may be it is worth a try. I wanted to get the patch updated first and see what happened. Also as I said I know its not on the RC timeline immediately but it's a much requested feature on the forum and having a patch knocking around can't be a bad thing, if only to see how not to do it! Any comments welcome. Thanks, Phil --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Tv/jhHnJKNE/rc_addressbook.r2972.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

jQuery error handler
by Victor Benincasa 23 Sep '09

23 Sep '09

Hi Dev's, Rarely an error is showed in browser with message "Server Error! (OK)". It's generated by jQuery error handler [1], but the "OK" is the 200 request status code. So, someone know why this error is generated? I don't know how to reproduce this error because it's too rarely here. We can avoid this error using a check like " if (errmsg && *request.status != '200'*) " but I think that the jQuery error handler should not return a 200 status anyway. The jQuery documentation says: "Note: Do not set handlers for complete, * error*, or success functions with this method (jQuery.ajaxSetup); use the global ajax events instead." Should we move the error handler to ajax events? Maybe it's related to the error handler returning a 200 status code. There are some other issues related to error handler returning a 200 code too: http://www.roundcubeforum.net/issues-bugs/5115-server-error-ok.html http://trac.roundcube.net/ticket/1486159 Opinions? [1] jQuery.ajaxSetup({ cache:false, *error:function(request, status, err){ ref.http_error(request, status, err); },* beforeSend:function(xmlhttp){ xmlhttp.setRequestHeader('X-RoundCube-Request', ref.env.request_token); } }); ... var errmsg = request.statusText; ... this.display_message('Unknown Server Error!' + (errmsg ? ' ('+errmsg+')' : ''), 'error'); if (errmsg) this.display_message(this.get_label('servererror') + ' (' + errmsg + ')', 'error'); }; -- Victor Benincasa _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Sorting by message index
by A.L.E.C 23 Sep '09

23 Sep '09

We need to implement sorting by message index. It should be simple on PHP side, but I don't know how to make sorting switch in UI. Currently we have sorting: - by <message list column> ascending - by <message list column> descending and we need: - by message index ascending - by message index descending So, 3-state switch in message list header (http://trac.roundcube.net/ticket/1485936) is not sufficient. Second option, use status column header for this is in my opinion not intuitive and we'll use probably this for different purposes in the future (e.g. column selection). I don't like also a third option, adding 'No.' column. Any ideas? -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Project Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

6 9

[PATCH] Make 'Received' header pass assassin checks
by Vladislav Bogdanov 23 Sep '09

23 Sep '09

Hi all, I noticed that 'Received' header formed by roundcube don't pass spamassassin headers check. I attach patch which fixes this (at least for non-encrypted headers). Vladislav --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/YF/HjH6NB5W/roundcubemail-receiv.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

0.3 managesieve issue
by Derek Yarnell 22 Sep '09

22 Sep '09

So we have been running 0.2.2 just fine for awhile with the old pre- plugin managesieve code. I have just installed 0.3 and activated the managesieve plugin however when I go to to the filters tab in the settings it never comes back and just seems to be stuck loading. There are no logs generated and a tcpdump shows that the client starts the sieve session on the server w/ a starttls but then seems to stall. Is there anyway I can get roundcube to be much more verbose to what it is doing? I just turned off TLS and it seems to work just fine. The odd thing is that the previous non-plugin managesieve code did not have this issue so either their is a regression in it or its dependencies. I am using "Cyrus timsieved v2.2.12-Invoca-RPM-2.2.12-10.el4_8.1" for my sieve server". Thanks, derek Derek Yarnell UNIX Systems Administrator University of Maryland Institute for Advanced Computer Studies _______________________________________________ List info: http://lists.roundcube.net/dev/

2 3

Re: [RCD] [PATCH] Junk flag icon in a message list (Thunderbird style)
by Eric Appelt 22 Sep '09

22 Sep '09

looks really good ... Vladislav i like the column spam/junk is a nice feature what is the backend for this column and what happened with messages after marking as spam or junk ? Alec wrote ... it want add Threading in October to SVN ... thats really great i hope with SPAM/Junk Column !!! _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] [PATCH] Threaded messagelist view patch rev 3
by Eric Appelt 22 Sep '09

22 Sep '09

Hi Vladislav, wooow sounds like good, many thanks for this great work. I test it directly tomorrow. Great thing!!! _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

list_mailboxes plugin hook
by Jernej Porenta 22 Sep '09

22 Sep '09

Heya, I am writing a plugin that would filter out some folders from UW-IMAP folder list and I came across a bug (or a feature) for list_mailboxes plugin hook. If you use list_mailboxes plugin hook, it only gets called when list_mailboxes function is called, but not when list_unsubscribed() function is called (which is quite similar function). So, would it be better to add plugin hook to list_unsubscribed(() function as well, or leave the functionality as is. In my case: listing mailboxes in settings view works fine, but it is not working fine in the settings.folder tab. I have made a patch, which is working in my case, but I dont know, whether this is a totally working solution or not :) regards, Jernej --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/3W/9jIZFQof/rc-imap.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 2

[PATCH] Junk flag icon in a message list (Thunderbird style)
by Vladislav Bogdanov 22 Sep '09

22 Sep '09

Hi all, Here is another patch to message list. It adds column with Junk/NonJunk IMAP flag to a message list. Everything is done in a thunderbird-like manner. Known issues: 1) Hook needs to be added to "mark_as_junk"/"mark_as_non_junk" actions (report message to SpamAssassin, move it to a 'Junk' folder functionality, etc. should be moved to plugins). 2) Thunderbird actually uses two flags, "Junk" and "NonJunk". For now, message without any of these flags is shown as NonJunk (without any icon), but such message is not shown when one chooses an "Only Not Junk" filter. I'm unsure how to implement full support for two flags with only one icon (make it a three-state?). The only way to mark message as a NonJunk is to mark it as Junk before (in sieve or manually). 3) "Junk" and "NonJunk" are nonstandard user flags, but I hardcoded them into code for simplicity (as user flags handling is not done yet in a roundcube core). 4) I'm not aware of other MUA's, how do they mark messages. If it differs, then compatibility type should be introduced, and it should be made an user-definable option. 5) Icons are stolen from thunderbird and a bit crappy on a red background when message is selected. 6) This revision of patch applies only on a top of threaded view patch I sent in a previous e-mail. Actually, they touch code in a same places, and it is quite hard to keep changes in sync between thread-aware and unaware versions, so I work only with a former one. Current code works stable, but polishing is needed (I'm about IMAP flags). Comments are welcome, Best, Vladislav --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/yQ/Pn6TafGf/roundcubemail-0.3-ju.patch http://detached.gigo.com/rc/yQ/Pn6TafGf/junk.png http://detached.gigo.com/rc/yQ/Pn6TafGf/nonjunk.png Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev September 2009