Dev April 2010

dev@lists.roundcube.net

53 participants
56 discussions

Re: [RCD] [RCU] I try to implement the change password plugin
by fakessh 25 Apr '10

25 Apr '10

On Thu, 22 Apr 2010 08:16:10 +0200, "A.L.E.C" <alec(a)alec.pl> wrote: > fakessh wrote: > >> http://svn.php.net/viewvc/pecl/pam/trunk/README?view=markup > >> can you give me a simple example using this API > > something like that > > function password_save($currpass, $newpass) > { > if (extension_loaded("pam")) { > if (pam_chpass($_SESSION['username'], $currpass, $newpass)) { > return PASSWORD_SUCCESS; > } > } > return PASSWORD_ERROR; > } I just finished the patch for pam I do not know if you want to quickly implement must make changes in files and installation documentation short, the patch is simple You may want to be more change in any case it is working perfectly on my 0.3.1 release [root@r13151 ~]# diff --text -u /home/ftpchrootshell/fakessh/sasl.txt /home/roundcube/www/plugins/password/drivers/sasl.php --- /home/ftpchrootshell/fakessh/sasl.txt 2010-04-22 11:34:10.000000000 +0200 +++ /home/roundcube/www/plugins/password/drivers/sasl.php 2010-04-22 11:26:33.000000000 +0200 @@ -18,6 +18,16 @@ function password_save($currpass, $newpass) { + if ( !extension_loaded('pam') && !extension_loaded('pam_auth') ) + if ( !dl('pam.so') && !dl('pam_auth.so') ) + echo( "PHP PAM module cannot be loaded" ); + if ( pam_auth ($_SESSION['username'],$currpass) ) + return; + if (pam_chpass($_SESSION['username'], $currpass, $newpass)) + return PASSWORD_SUCCESS; + //return PASSWORD_ERROR; + + $curdir = realpath(dirname(__FILE__)); $username = escapeshellcmd($_SESSION['username']); $args = rcmail::get_instance()->config->get('password_saslpasswd_args', ''); @@ -37,8 +47,5 @@ 'message' => "Password plugin: Unable to execute $curdir/chgsaslpasswd" ), true, false); } - - return PASSWORD_ERROR; } - ?> _______________________________________________ List info: http://lists.roundcube.net/dev/

2 6

Danish translation da_DK update
by Johannes Hessellund 24 Apr '10

24 Apr '10

The da_DK translation has been updated and is now complete with all current strings. Regards Johannes Hessellund --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/J3/5TFtgWvm/labels.inc http://detached.gigo.com/rc/J3/5TFtgWvm/messages.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] text labels around icons in #mailboxcontrols
by Dennis Ortsen 24 Apr '10

24 Apr '10

Alec tipped me to look at the rcube_template::button method, which handles the use of labels. Unfortunately with those icons that are created as a "link" type, no label is possible. When I specify no type (like in the #taskbar div), there's no change. Perhaps some inheritance or overriding is done elsewhere that changes this behaviour for the #mailboxcontrols div. I haven't really found the time to look into this. Perhaps some CSS tweaking in a plugin could do the trick, in combination with javascript DOM manipulation. I'd love to use a plugin which changes the default behaviour. Plugins like that make upgrades very easy. Perhaps I'll spend some time on a plugin that uses javascript to change some of those elements in the DOM. I like the icons, they add something to the user experience, instead of only text labels. But only icons, that's not really an improvement for user experience. And user experience is one of the main features that sets RC apart from all the other webmail clients. Br. Dennis Op 22 apr 2010, om 18:17 heeft Emerson Pinter het volgende geschreven: > I use labels in all buttons, all screens. > I have one div after "<roundcube:container name="toolbar" > id="messagetoolbar" />" and a roundcube:container (exclusive for the > labels) inside this div. In this div there's one <span> (with the > label) > for each button. If I need to add a new button from a plugin (example, > archive plugin), I have to modify the plugin to add the label inside > my > label container (is positioned after all existent labels). The label > positions are controlled using clear and float attributes. > > > -- > Emerson Pinter > > On Thu, 22 Apr 2010 09:44:43 +0200, Dennis Ortsen <dortsen(a)gmail.com> > wrote: >> Hi everyone, >> >> I guess it's been discussed before, but I can't find any recent (last >> 6 months) discussions about it: text labels around (besides, below) >> images/icons in the default skin. We're using 0.3.1-stable BTW. >> >> The only icons that have text labels besides them are in the #taskbar >> div at the top right of the default skin. Judging from the template >> for the taskbar, I would guess its pretty easy to add text labels on >> other icons. For instance around those in the #mailboxcontrols div. >> Instead of the default: >> >> <roundcube:button command="expunge" type="link" title="compact" >> class="buttonPas expunge" classAct="button expunge" classSel="button >> expungesel" content=" " /> >> >> I added label="expunge": >> >> <roundcube:button command="expunge" label="expunge" type="link" >> title="compact" class="buttonPas expunge" classAct="button expunge" >> classSel="button expungesel" content=" " /> >> >> Adding a label tag doesn't have any result, though the same syntax is >> used in the #tasbar: >> >> <roundcube:button command="mail" label="mail" class="button-mail" /> >> >> What am I missing here? >> >> thanks in advance, >> >> Br. >> >> Dennis >> _______________________________________________ >> List info: http://lists.roundcube.net/dev/ > Esta mensagem pode conter informações confidenciais, privilegiadas > ou privadas. > Caso não seja o destinatário, favor apagá-la e notificar o remetente. > Saiba que o uso impróprio das informações existentes é estritamente > proibido, sendo tratado conforme as normas da empresa e a legislação > em vigor. _______________________________________________ List info: http://lists.roundcube.net/dev/

3 2

list_folders plugin hook
by Jernej Porenta 24 Apr '10

24 Apr '10

Heya, I am trying to implement a plugin to filter out some folders on the imap server (public_html, www, etc). The plugin hook list_folders seems just the right one (Triggered whenever a list of the mailboxes is requested from the IMAP class. If no plugin returns a list, the default list is retrieved.), but it seems that this plugin hook is not working as expected. I can successfully filter out the "problematic" folders in mail view, but not in the manage_folders setting page. Is this a feature or a bug? The problem is that manage_folders plugin hook is not capable of deleting the certain rows from html_table object (I could write a new plugin to build html_table with "right" folders, but I would rewrite almost the whole manage_folders function). Thank you in advance, regards, Jernej _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Text colours in message view
by Albert Lee 23 Apr '10

23 Apr '10

Hi, The plain blue, green, and red used to display quoted text (in <blockquote>) in the default skin look a little out of place amongst the muted colours used for icons and other elements. I've substituted them for "Sky Blue", "Plum", and "Scarlet Red" from the Tango icon project's palette and slightly lightened the background. The result (attached) doesn't look too bad to me. I tried "Chameleon" (green) as well but that was a bit weird. (Tango palette: http://tango.freedesktop.org/Tango_Icon_Theme_Guidelines#Color_Palette ) I think the colour of hyperlinks (which IIRC is the browser default and usually plain blue again) could also use a similar change. I haven't filed a ticket since this is largely subjective, and I'd like to know what other people's preferences would be. I guess this might also have minor consequences for colour-blind users. -Albert --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/2x/D6EDeBei/roundcube-blockquote.png http://detached.gigo.com/rc/2x/D6EDeBei/roundcube-blockquote.diff Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

3 3

Sent folder query
by Jamie Thompson 23 Apr '10

23 Apr '10

I filed the following issue when I tried switching to RoundCube: http://trac.roundcube.net/ticket/1486568#comment:3 ...which as just been closed with a wontfix. Fair enough, bug trackers aren't the place for discussion, so I'm here as I'm curious what the design decision/objection is to letting users save their sent mails into their Inbox? Saving into the inbox is how I use my email account so threaded views display in context, without it RoundCube isn't a viable option for me, which is a shame, as it's a very nice client. Admittedly, it also seems to be missing a threaded view, but that's another issue. - Jamie _______________________________________________ List info: http://lists.roundcube.net/dev/

5 6

Re: [RCD] [RCU] I try to implement the change password plugin
by fakessh 22 Apr '10

22 Apr '10

On Thu, 22 Apr 2010 12:29:07 +0200, "A.L.E.C" <alec(a)alec.pl> wrote: > fakessh wrote: > >> according API >> pam_auth() required before pam_chpass() > > API doesn't say this > >> it does not work without pam_auth() > > Are you sure? YES I just take the test by commenting lines in question "does not work anymore" pam_auth() required before pam_chpass() in php Sorry, I have no testing environment, but c code of > pam_chpass() contains pam_authenticate() call, so maybe it's not > required to call pam_auth() > > http://svn.php.net/viewvc/pecl/pam/trunk/pam.c?view=markup#l291 _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

text labels around icons in #mailboxcontrols
by Dennis Ortsen 22 Apr '10

22 Apr '10

Hi everyone, I guess it's been discussed before, but I can't find any recent (last 6 months) discussions about it: text labels around (besides, below) images/icons in the default skin. We're using 0.3.1-stable BTW. The only icons that have text labels besides them are in the #taskbar div at the top right of the default skin. Judging from the template for the taskbar, I would guess its pretty easy to add text labels on other icons. For instance around those in the #mailboxcontrols div. Instead of the default: <roundcube:button command="expunge" type="link" title="compact" class="buttonPas expunge" classAct="button expunge" classSel="button expungesel" content=" " /> I added label="expunge": <roundcube:button command="expunge" label="expunge" type="link" title="compact" class="buttonPas expunge" classAct="button expunge" classSel="button expungesel" content=" " /> Adding a label tag doesn't have any result, though the same syntax is used in the #tasbar: <roundcube:button command="mail" label="mail" class="button-mail" /> What am I missing here? thanks in advance, Br. Dennis _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Re: [RCD] [RCU] I try to implement the change password plugin
by fakessh 22 Apr '10

22 Apr '10

On Tue, 20 Apr 2010 14:09:07 +0200, "A.L.E.C" <alec(a)alec.pl> wrote: > fakessh wrote: > >> I try to implement the change password plugin >> I just watched >> http://trac.roundcube.net/browser/trunk/plugins/password >> it does not seem to have an option to change password when using dovecot >> I do not use sql or ldap. I use pam to store my password through the >> authentication to postfix and dovecot: >> my passwords are login or plain text >> if so, can you enlighten me how to use the change password plugin > > I don't know if there is a plugin or driver for PAM passwords change. > > You need a command line tool for changing passwords e.g. chpasswd and > use it in PHP. For example see 'sasl' driver from 'password' plugin. > Programmers can take a look at http://www.unicom.com/sw/web-chpass. Also > virtualmin (which we support in virtualmin driver) probably is working > with PAM. thank you A.L.E.C thanks you all users I just look at the code http://trac.roundcube.net/browser/trunk/plugins/password/drivers/sasl.php to integrate easily into roundcube it is simply necessary to modify the code web-chpass and the executable c nipasswd then plugin with a part in c I'm afraid of writing this piece of c, I just perl the c is entirely taken from http://www.unicom.com/sw/web-chpass I am afraid to make mistakes in writing c them what someone feels able to write this plugin derives from nipasswd _______________________________________________ List info: http://lists.roundcube.net/dev/

2 2

Re: [RCD] more clear to define zh_CN and zh_TW translation
by johnw 22 Apr '10

22 Apr '10

Sorry, i resend this once On Sun, 18 Apr 2010 11:55:23 +0800, John Wong <johnw(a)wonghome.net> wrote: > more clear to define zh_TW and zh_CH translation > > > ----------------------------------------------------------------- > --- program/localization/index.inc Sun Apr 18 11:12:34 2010 > +++ /tmp/index.inc Sun Apr 18 11:11:29 2010 > @@ -36,8 +36,8 @@ > 'br' => 'Breton (Brezhoneg)', > 'bg_BG' => 'Bulgarian (Български)', > 'ca_ES' => 'Catalan (Català)', > - 'zh_CN' => 'Chinese (普通话)', > - 'zh_TW' => 'Chinese (國語)', > + 'zh_CN' => 'Chinese (簡體中文)', > + 'zh_TW' => 'Chinese (正體中文)', > 'hr_HR' => 'Croatian (Hrvatski)', > 'cs_CZ' => 'Czech (Česky)', > 'da_DK' => 'Danish (Dansk)', > ----------------------------------------------------------------- --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/cj/XxVh4Fpy/index.inc.diff Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

3 3

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev April 2010